From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EF483426E7 for ; Tue, 22 Mar 2022 17:26:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13E8868B10B; Tue, 22 Mar 2022 19:26:09 +0200 (EET) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-eopbgr120045.outbound.protection.outlook.com [40.107.12.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8E98C6809C4 for ; Tue, 22 Mar 2022 19:26:02 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKxefwHxUqixqxNwM1zu6Jbld3hAWkBa3fIWtRl31L8NhyCKjdtBij/RUXQ0ioikmhQrW6/eloshD8TQQ4jBBrQZCHHcWVDTQSSK5743hFHzgn7YcCJ8GOfC9xjnFf50/H52WbuwuQMG7dT/NcLkSvxKGTQP9gMJqmdcPyw0loQS15yPw1ILMXr8spXLrZOnf4cXsglpEPwQ5SSsCJg0mIwAKIO/+QVQy3xWp8JzaVjSDKYBE4vuoStjhRMhm7yBZhz0e94Ke+VdQ45J4fk6EyD+KE4flBu6Aj0kB7tU9hJwhsPjzdKdwLo43T1HvITm7r5w0zYQyA6ExZAjHVdBww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yWvSPudooqBTZG94Aoe0u0zougNzDkhOTPgVUWjlfao=; b=R1zzAYMVEbegfWRL65Gi1Mpt4aZRd1hiys4ujyINZy6bYAF/TV950wTUuEIfYHfS2fGgR8QBJZG8d/ZIj3+Bn0aFN4Y8ykRk2mGT1CT3M6VXJkNulhH17pEVGLAcu8RXeHccPqr7uP1XpjjKA+D1G85e91q1CYCRo0l+Usf4c7oW9cSuKoGRa/M7JHsg3MNyidu4HiUCPckvtNrtgrQZGb1+nMhzlIqKFvQTi6NojCGBGNspVVHuV84uCWb7VIouO84iXI+QpqcLuNf3uAjcDuH5ZPhuRZhbZmftmFwRq4uYOsmeZKMGQxHF9i70inyaEabPQ7xJjUm3nHXoJztHPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yWvSPudooqBTZG94Aoe0u0zougNzDkhOTPgVUWjlfao=; b=gRlXr1ZLGPf41+B2lVjh1cxd6HZGVLyOlgYtrcD22JJVUkC9HCnb1bEjgG5S3pG2AmunAXXfLZ7wSeLhRL0xwYTkqSjX/8nnSBOUZWcJlinWN/t8ZdEUX8NrsoDPM1QwjLwX1h/Bh+xu9osnZHy3DxY2h7jZCKgSIjl7ZI2Bp8qC7Y62N4QvZfaIt5jbh4vmcCGgKw+3EadxI7QNzilpbeDXlgHxkT5Tk37yElzsadfkvuCgLg/gVro8i8wIKWy/6VbLDMZrSc3Fxsviyan9UTFosFM4887Nk9yGEudS7qyR46ZvKn28R4gNOzJEkTu+LUo8JM5jii204T8GSsWosg== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by PAZP264MB2493.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1e4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.15; Tue, 22 Mar 2022 17:26:01 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::c034:a5c0:117d:e8a9]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::c034:a5c0:117d:e8a9%4]) with mapi id 15.20.5081.023; Tue, 22 Mar 2022 17:26:01 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v3 1/2] lavf/mpegenc: fix ever-growing fifo size since the new API Thread-Index: AQHYPgtd+u9WU5izfE+b2nwXCWlf1azLn0OAgAAH4/A= Date: Tue, 22 Mar 2022 17:26:01 +0000 Message-ID: References: <20220322163911.64772-1-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 963eb8d6-1512-43f3-3000-08da0c290910 x-ms-traffictypediagnostic: PAZP264MB2493:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pwxBRaYtSTfKKxuXhDXCwOUNDAV0pdAuDybgzUrb0YAdhRWen2dATOLlHB5BQbG5J5sZlZ/ifvCLHZMaK9nXTIQs8UA4/TdperuiDpHEbmi111kPoewISca0QIitSm6ws5bJuyLEiqYPE8u4I/wr7W3j1uXhclhg0tGKPTdP1E1rMqTiJZ6R+Tw/SCao0UjnKGboJGvkTVXcVFzE9g3uaBcePy8dE//TFU5he3NOr/hxgaJmC+28m9dnC+DmmHaDPE721AZDKuIDKEiZAXFXrqKnF/KlCfRmD/c5hqjr61LTN5JF20GV70vuuoJ7BjmVIme/GwALXVSKaj2hay6xiOr6ZgLVRPQ7S4bKU7MwT4Da2dd1HJfwbi3+gti6hHxK2L4ROBItwd0qbCd56Bdg7svbKHj1VdghhYSR7FTOmbBxGlvB55dhOz/QhAsiuJlV9cUbrjVJBg+LyWLAPGcUQ6QkfjwsHhLYKY+B27BACeWMuX9ZjNV8E8X1N3jm2wXTKRyK7XsYt624lS8fIBxlOE9E1sbLSeY0xz++1wje9R5FM2H7ETSg1xIvQK2ufTQQegK4FC6SZd/jc3WLfX8mP4hGrnZjEwXjWsXWBb1+OLZf3PyWYGgIsAMX0VzFuK85lDtZn6HBbT0RRyoysfaMH9T8JzdVtiQWfyyg5hTkTQ+N7LtI/YXevK5GXWe6Lnjyb8Mfc1W/GbjxHRAMoKmgialUteDUeUMJSKXNA8qvkIg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(366004)(71200400001)(508600001)(6506007)(7696005)(55236004)(8936002)(52536014)(76116006)(66946007)(66476007)(66446008)(66556008)(8676002)(64756008)(122000001)(2906002)(38100700002)(33656002)(316002)(26005)(6916009)(186003)(9686003)(86362001)(55016003)(83380400001)(5660300002)(44832011)(4744005)(38070700005)(46492015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CKef3NpdPNYeuddO9YIAto/co6rnePHccxjNYk51iyC3tyTXpX20aMmisW/u?= =?us-ascii?Q?baP6O46FQMEKtVRHRYth8/jeDQ1dIGsqlB01ExzHRTIASxTMgKHRTYDleR9b?= =?us-ascii?Q?t0nP3bYpHmMQKPEvsY5UQ4pEI+9K1mDg9af+WTmU+QwXalYjh+K/4QqzSunO?= =?us-ascii?Q?Bc4G9TJthGHGXUU2q2HIGgeGWGPEQ+LszzLAN5GHt47uSdaSrk/DvSZGmrgV?= =?us-ascii?Q?2L+9VkRiX3XGJMovp1f5dBQ7t70HQJc8ycuk8LFHFO6tDWxD4eQgBnjTbCjd?= =?us-ascii?Q?myJ8hnRoiLMSLHHON3aOmymXcNrbxwC93D+Rp/NmK4cv+2mHtjuWNd83n+DH?= =?us-ascii?Q?Bo/AlapYFffBx+w66xoBHZCzrRhymDJvn1+zjhFmtUtDaoByGIxTGoJ/ZtMN?= =?us-ascii?Q?j/ilGNsfFgTbKyxmvnV+C9UlSCoZ3kLXO5g/8LcFvoMs+GFYsUbYB2BE+yra?= =?us-ascii?Q?ArN5Yiq45RD8S7jihlCXNAhlqq9VE2MOVsY44xO03LDmw58nDCbWy/NsYk0u?= =?us-ascii?Q?+0rVnMLjzdsY4Is8IXnQeh70mIPj4Rh2LLgyOCoJ4c+0NVHvKO9EC7X9hdYs?= =?us-ascii?Q?UcCQ9V0XB6TNkuIc3Lz0NaA0yJ+GJ98coLxaup44/6xeoscsmivBmTd++Kpx?= =?us-ascii?Q?Tw/e5lFga/DA2MMrxCs2ip1idqMzQcGv5hFKSN9Rpplcp9q39W11J3hFJ+YI?= =?us-ascii?Q?gqc1Fy/BvUD7bXrfZSUyULB924qH9hVOHYjiu5aSQejtdt9tkKbMC2WXG8+H?= =?us-ascii?Q?3y+HRY55HwerYYL65+E+FOjUN32oTcH014P2wPfpNro52uaHxPEa50clY9eK?= =?us-ascii?Q?0V9mN75DIymcDl2O2UrZfMzMIH4Thad3Rlh9RJdKfBnhT+7RuLuc8hg1nTTX?= =?us-ascii?Q?cIbn5fTWBkN8vKc12zZ5mjUS2hy2xHEBZZ59w43Z4mdgokBGuNPKRk1PRcqx?= =?us-ascii?Q?x5q5l//GRwJ+eQMXVj9B3b5GxYPoKvMvqbT8dZwXU+IwgjUxAQw5I7jXCLXJ?= =?us-ascii?Q?Bz9mTj95ZerJLH43XWFBzNs1nazoKSlF3m59VI16ur+RuYVIs/0rQMfwURy6?= =?us-ascii?Q?qGbYfzzQ+5/1tevez02RhausZJhMz0V9VcoeKW6UR/PyNzgf7SiQ66WqkXkf?= =?us-ascii?Q?NCTa8udUqK8JyFzguiSdvDwamE9eyECjrktP+YcQo6s3hRQeZaH9KHsSAhki?= =?us-ascii?Q?Y33sOJi5wtiPfMYAoPFZsuiqgICLmYekL7FNYXToH5hHWtdr8AzrWXJ32U+z?= =?us-ascii?Q?XiMQYk5OZzckwMsmruP9UshK/29VW2Q9sG0CwkXNi09q5latmCHGMiWGfEuu?= =?us-ascii?Q?PgR33dbwNNjHXSLD+RzuoIviKsuboQk1lv/WkxJL/LY0n7XJ7KVciG2H2fqE?= =?us-ascii?Q?t+IO2txJYxHPbwNrXVwz6iYFN12x+Li56Zib/ZkJl8cjMggyALjOh9dHaPdq?= =?us-ascii?Q?7QEZA9NC92QFDkLWNDCqjCyT2F/fimJ5fu/gvbU8MXi6FJIcVRdCsA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 963eb8d6-1512-43f3-3000-08da0c290910 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2022 17:26:01.1282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xx+J+LV6oQ17sbFkNz67rIuZnMcWAmlx3Njq9WdQrM40zNlyGvaQiGH5C0QNBebkVJJARjzEyVKW5edUH3jWjU8GCQ21rL0v0dDPgXPf+N4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAZP264MB2493 Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/mpegenc: fix ever-growing fifo size since the new API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >1. Options of type AV_OPT_TYPE_INT need to have a target of type int. >2. Setting UINT_MAX as maximum for such an option is nonsense; INT_MAX is the maximum for it. (FFMIN(INT_MAX, SIZE_MAX) would be even better.) 3. Allowing zero for fifo_size_limit makes no sense, as the above code allocates 16 >when allocating the FIFO. >4. After removing av_fifo_grow2() it is no longer assured that >av_fifo_write() succeeds; it therefore needs to be checked. > >- Andreas Fixed in v4. Thanks (I have revised the spliting between the 2 patches). Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".