From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F359470EB for ; Fri, 24 May 2024 15:10:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 395D468D557; Fri, 24 May 2024 18:10:30 +0300 (EEST) Received: from PR0P264CU014.outbound.protection.outlook.com (mail-francecentralazon11022019.outbound.protection.outlook.com [52.101.167.19]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0764D68D189 for ; Fri, 24 May 2024 18:10:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jSFRHCc1NLMIJ1oGBMh+dvBpwnObHj3nTQiEvXfE9gkYNrhmHQsNDwLH00esBEJznNKZR1xXt7t2pba1nBA+cUr7dxW7K6R95rAz0/cbOn/EIdzNwjOkk+cofLYwrI6A0iR7hToSXP7oNISTFMQ4WoXnAu9rFK8Y+yNQhpA8uEA0yP2bSBpYpqQOjpneJVO2cJpAVKZqv9i0AEVwJiT0MVgdMgccOXCphatbIaszcOPCAfr4VleEQTiUKLx/qKAtRnzwq3mzKfuxr8UlTt3JsPFue8EqUt5ARjTRt7hWSLLaLfriE1AWWiIbh9vYByha/8GPGGBN4TxR8x9Q3F2Y1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHq1nM5O3dmFX2m/PTXIaCvaZE6MK47Dno5xS9ws/fo=; b=lAXUPel4A79d2l6pdFRogpo6hlBvqmSt/T7LNEt4WNojowIcT2voUCAcLKx7LOUXBxa9lEsD7MDcvLdPnfSTTzSVKjifaDT/j4rf+2EH3PGimHUM9ZKl+cKLSlLq4UwvgaMrGmo0CuaXWh/4PyANNs41lwB7QBm9b5uqnXj+3UJF91IxpuVhWWpMd8WCaN3wiW4ujaGo2SL45Yjc8UuzCSKgHc2kwyGuUdbnIiUYB/7hQFM8l3IH/JKRsbxpAc702K/PyzVtWvkFXLU/NPIWiWkOyXaHC2mjuNWjXj6hZXB9h/IMnqYK9729gbStvOVKeKyYMDMzbO/nPZ8jARKMRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHq1nM5O3dmFX2m/PTXIaCvaZE6MK47Dno5xS9ws/fo=; b=QJtxsGaRkhG0sKN9OsfMlaxjD6ncHbENUyip7Es0EJexwdTtDh+QRdAaK6/K1opOCAJivgVv51d6Mz1Ul5Ra6/QuwcZGTBCT1WF8zZZG83Ds0Bz8KOZxYDTPEC1eIsilk3x+SlTh8fiBCmAYirizdOLG33lDHujhypb4GFnTuP7GbxZqbDAQJVaU9SZ+/YUSOLdVaO0a9CxSLtgEiUQQz3HrYJCSj3E4i3KYHUf/TT2+XNfxvMzgic0T7FuZvEA2Fpmneia10TnYfMXpY004038cVMOL6RTYbd3VYV4SQJyAwf10yzXdqMTAqRn0Sf8aqdo6CGD6ieo7bOcVGxGXKw== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by PR0P264MB2567.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 15:10:20 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::a9db:c8aa:ffcb:e463]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::a9db:c8aa:ffcb:e463%5]) with mapi id 15.20.7611.016; Fri, 24 May 2024 15:10:20 +0000 From: Nicolas Gaullier To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH 0/1] avcodec/h264_parser: fix start of packet for some broken Thread-Index: AQHaf4+npMWQneFcwEy4+/sKkezk8bGm2aEg Date: Fri, 24 May 2024 15:10:20 +0000 Message-ID: References: <20240326150946.314054-1-nicolas.gaullier@cji.paris> In-Reply-To: <20240326150946.314054-1-nicolas.gaullier@cji.paris> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|PR0P264MB2567:EE_ x-ms-office365-filtering-correlation-id: 1e1c6ab9-4913-4397-17de-08dc7c03a0e9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|376005|366007|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?MeGg0oALMaoi3nFpAOiCv479atebsnQFc52EAYUc6hy3yICJZ6J1zVnh1z?= =?iso-8859-1?Q?2MBRcL1ea18Ph6MsfpPenWp7T0MIv9l4agOmr4dXjVzkaYRP3H5C2pve81?= =?iso-8859-1?Q?El71N7RAWR038ii3zbEnkMMakWVw1h4NhkkWtMH3VL12+YYyLT/XuzNxGd?= =?iso-8859-1?Q?oAiRST27m1hVu1EeJKhvP+pfdcnjo74pqZLBOnN5qbzw0Bvap6lqNvKvq3?= =?iso-8859-1?Q?nJPAAwGMU2FWCUfbHWPlOwB6EjWrHlaoP1TErWvdVOjFX5niuhFLjyD4Nu?= =?iso-8859-1?Q?N8oeTYh7fBYCFJiSFFnUhLBCCNzx5aPFwZ7c168mMwZiqdzfQ5vJC0ACUw?= =?iso-8859-1?Q?8LLb2G/2Ta4yJkr8X20odJRvgr60E2nNf0LUjJeq0JwqpVhaKFeJ86yrVY?= =?iso-8859-1?Q?WBm/+NdY0HujaYitjG522M5qaXIQNb2keUSUznUnM8HCjID6gIeJFZnV8H?= =?iso-8859-1?Q?sfC4uXEegVqsnRvBA/kU3Gr5/MhocMnu3j2VrOZCl8EKfqiBdKSP0imzlo?= =?iso-8859-1?Q?1fNUnwKWvYf43m1ssypaXnuGNnqrpX2EyaSzN87kpeaV1zzkqL4h6+4p32?= =?iso-8859-1?Q?9OPakHExxROd6WzQBRzJiGyHnlcryzYdKkMpQLgBlehNp2YnPso8t1NvYt?= =?iso-8859-1?Q?G7SkF9b/fmhe+iY74tVtBX+USgv4uhcHKljgUHkmnH4XskW5JJUUHRsNIe?= =?iso-8859-1?Q?TTVBa1IMVgLTcnCihuuPkNEHYp7nhLv6W049yPB80XLN7QpMwDXJwk62SP?= =?iso-8859-1?Q?B2EO9N7Kx8zSHa7E3jkIZiDe3c2hdGxSPGVIrAq2q4hm9IuasU0/s8Wqtd?= =?iso-8859-1?Q?gupTmiekvxCsvDB3YkaMP+fsq6+d54LQTXDzqqf/7gNnLjZ13zMCnu9V/h?= =?iso-8859-1?Q?kYktu2Ww2nuH3Yc+Ip1p0k4+DDUgu651mklg6/UKluZmBf0yJa6MWSWda+?= =?iso-8859-1?Q?t2FnlNFvYwLoE7o8SW7BGHsR5HNahNAMM7dvMQlKINfeJUyS4v/oqNntNy?= =?iso-8859-1?Q?iZ0DT1GDSb8NTqjc1qpUmWI8/XqrzryM/GF8c3vr2GX1CNo2HRBIJnjYhP?= =?iso-8859-1?Q?OZryLZJCXd6uMEvRe+erA7EzB4TyCV5jOHVeP0vZlak+tHVoIk0bYMGKwn?= =?iso-8859-1?Q?DIMrx7Tulm7iiWmHZjAAAMk9noXudWgRKq+kGhKXseC7RfDXtH6CdVRWcl?= =?iso-8859-1?Q?NaoS+YHQl0UuJ/IUi0LjZJnd/w/qdM3x/XeNuhke/EPfMh19HfLCHumhaY?= =?iso-8859-1?Q?s2mDZmomzc3XBIen/pQ/s3HXYgKFdDM180XBZXhUzblbAgA4tljvw7Om8N?= =?iso-8859-1?Q?/+aUY3ChDHDnUveVbk8puACZ1A=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?NIwEeNB65zl5sUEF2QKHo3W/BUlfcOMpFVgiQKv7RoXJJqu3BUsc4p790G?= =?iso-8859-1?Q?TrOISnjEtExf3fEUNG+FEG1+nPypCdxAkKDNoV5JnOK0E7xmMM826Gq0Oq?= =?iso-8859-1?Q?0fs1EJEgRvxsWjlMwpfll3Cp4N1Royn7wUGxD8aw7KkChaJ2TMDdjHpQiS?= =?iso-8859-1?Q?jPzw8KW/hP0mPdA9PX1CU+SQma95oiNnW1WI32JFBWntNhtuTbOp75nvAt?= =?iso-8859-1?Q?8bs3M+um4/Oqdq3iQUIjv/85ToHQwiGRP9CZTCKr7oJ4CKZEvoKYpGjLjo?= =?iso-8859-1?Q?vALufDzaIjQuFIM+Q3ff5oC71jQ9zP4EubNBS37hgHGve1j4QNt2T4BrxF?= =?iso-8859-1?Q?+EYJPka44auV4+0NxMiFjv00tIBcH+GoswLqpPz4l81o3DNt1xSdbeU8OZ?= =?iso-8859-1?Q?dUNE4FSd1htqyE1zl/cfabkAqM4Y4k7A8SE3WFewtsqz1VQ9MFRB55Wyvb?= =?iso-8859-1?Q?ziiKVc23WE4qPz0g5RZvlT22pJF4UcOKY5tb6AOrlsBEgLbQM8H62DdpBp?= =?iso-8859-1?Q?RG2eHK6fP2DLWBi0f86KNpcJOrcZEEXW5AbkjeYSwwwgGv3iKIubk5RkvM?= =?iso-8859-1?Q?s6UJZgwxRfkc6o6CCoJ8GIanyae9cGujAPMlbbCPYAoj0Ifx8iTF2X2UnD?= =?iso-8859-1?Q?kOwjv6y5NKdw3GHn6GuFb/oK6iRRgWjlDXZJ+XZuix3KxhGqtk3FjDi9R9?= =?iso-8859-1?Q?ukqDCF+zbDjK1s+3n3fqoPPIRGXoexB5h3MN5Qj1qlVlIOuWjOcOpFVvWO?= =?iso-8859-1?Q?ScFnb/BFK7E1eHb8a0T7eHKm8o27Sr1YttcPQVmLNl5kMXg5KtU9lZ1u83?= =?iso-8859-1?Q?fZ24+Pe3pVK6ZhSGTDUl7qG67aTLmWe0mgxZwc8wjRazGzTGfuPeiwA9x/?= =?iso-8859-1?Q?87P0hT1Ggzf8EwAzS67iwEJhPVIgAOjEMrxURo6qF0MbxnpqtgEYQKj8Lf?= =?iso-8859-1?Q?NmYW1b6hr3WmrYhcceyZDAMIGc1ZHVXVb1cupMy0HI6Wo8svef6abp4dKc?= =?iso-8859-1?Q?J8Plp8V52EO23Pnn0y4a4FztE5uoPtRkQB2aqtL1Qy7PzVSY4CLzlG6A5w?= =?iso-8859-1?Q?7fXRPZtPxs8wUFD2B6TbZT3xuJyh+uwAfOfXXSufd/s9iSU1wKHo4TsbR8?= =?iso-8859-1?Q?umk/HiUKXnasGW2U73yu2BaDW4E6191QN+BhhJVYGHgpIiL81AmKzqT60o?= =?iso-8859-1?Q?suQjuDbW2mz55NjpbybsPoAMtvGB3AxqlhcqXIJzVIf8eCaPGFOyXHtdwV?= =?iso-8859-1?Q?5ok0ow74YrcUc3XO/C0xiE9rWAFWPO4kLFKkQhenAZB+VmBjZEQtSvUNmn?= =?iso-8859-1?Q?iSSMfA+3acTI8X6T1fcYJUCePn+RPxu9R4QKwwyLBTW2WhdFw6ZCpfH7qf?= =?iso-8859-1?Q?dofxvLAAukmwZ2k954QRWCfLEfp27o5ml9qJgS0GZRFA30436tOEYnKQ5D?= =?iso-8859-1?Q?FChgQc/XWwWmp0YwPHdIpsU23YlYbkqhoEPWtcaqkXa/kbhrGnPn+b+RW8?= =?iso-8859-1?Q?8rdQduOe7E/p9WchjB1i0w0z+I5HVol9xebwvSScs2kIznu2eGnqi+MHgX?= =?iso-8859-1?Q?OudrvMGaDscHkdOHDggq7n5cTkX4bRMG5BFUkaidlRANDaMAFVtI2oCgsg?= =?iso-8859-1?Q?EZaErk41NTrfGDhBETlufWPTxUOBUrVqPs?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1c6ab9-4913-4397-17de-08dc7c03a0e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 15:10:20.5560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g6IUv5DRDRsU/34mLfWBEcsdUuRnEy7BnDGWgyd6UBbP4QBmQuBnqT/1PcqRaUs3yFN6/CRyuxl79dmFw+XMDV2sG/S8ce5EvIZGu/VQB/Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR0P264MB2567 Subject: Re: [FFmpeg-devel] [PATCH 0/1] avcodec/h264_parser: fix start of packet for some broken X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >Envoy=E9=A0: mardi 26 mars 2024 16:10 > >This is a patch from my patch serie https://patchwork.ffmpeg.org/project/f= fmpeg/list/?series=3D10999 >Maybe it is easier to review it this way, independantly. >This patch shows some benefits by itself, but most importantly, it is requ= ired for my patch serie to avoid any regression with some invalid streams. > >This patch is active in mpegts/h264 when the NAL Access Unit Delimiter is = missing the zero_byte (=3D a invalid stream case). >In such a case, if it happens that the last data byte from the previous fr= ame is a null byte, this byte is "kidnaped" to form the full NAL_AUD... >This is not good, but even worser, with my patch serie above applied, it m= eans that the start of the editunit is in the previous frame, which means t= he pts has to be taken in it, which is not the expected behaviour in such a= missleading >scenario. > >Michael sent me a sample from the wild but it can't be shared, so here it = is: >I have another sample of my own with NAL_AUD missing zero_byte similarly, = but it is missing the ending null byte, so I have patched/inserted the null= byte (I shrinked the adaptation field) to show how the code behave. > >Sample original (invalid NAL_AUDs): >https://0x0.st/Xs9Q.ts >Same sample modified to exhibit the issue (invalid NAL_AUDs + an available= null ending byte at 0x291F): >https://0x0.st/Xs9j.ts > >I use this simple command line and then compare the xml, it seems quite cl= ear: >ffprobe xxx.ts -show_packets -show_data -print_format xml > >Nicolas Gaullier (1): > avcodec/h264_parser: fix start of packet for some broken streams > > libavcodec/h264_parser.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Ping ? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".