From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 94F2849C30 for ; Tue, 5 Mar 2024 11:07:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D06F068CD00; Tue, 5 Mar 2024 13:07:44 +0200 (EET) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-pr2fra01on2113.outbound.protection.outlook.com [40.107.12.113]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ADF5868CB56 for ; Tue, 5 Mar 2024 13:07:34 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aT+nNvs9ZDq88Zfbl2B+6cB5KlTmUps5CALA7PlRuGXVqKPmmMz2DPoV6LMo6cb/8CxXoxDbEqXy3z7zcK+NrKk+n1QYBBv7D+vV6xQG5gGJYqWSLE3TAtQELnZ/jfOOcEt9DvWV7SnmMlZjVAlP+UQt7a7bUn9QcOYh9r3x6kwcU2VXdKVKlthjo3p9uKsmoUjL3sAPdq98RLw5GDpFybGYj7PP2pT9JY186NAynnB5etJ9CXISL0C4/vmumcUhyMeosLJs/AEjeEzXhyDaujtCyrztdtrl86xQxmdl8ivmGyExW/cvuOVrtt9y8hbIETpp1guwq5O6QJQx7HIoVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ub7+JtYehItOykzCxOKW+ymjaJZmleo+OZDLx35CzTM=; b=I38MYHBwMK1+bnY5KRT7PpwJmYkm9h5Jr06/OUsw4qPq6TVk+t84O9Jqbvao2BvDzkcokvMbLQifgZ37RRr8cyAK5Ukqy63QFh6ukP9Y+Vbc7clOJaMyZxnAzUK5xvMSi4HaPJ+xFyU1eCVeer5Rcg1Crcdb7RLC/SFuCNlAJCrhrhq6/v/mfHn/RYtdapBNeYZ5cAquApkcb15q1zoCFokivVKN4Ytl50N+uC+I5hpmm190Gpndaux8SwqfOOJpqnj26dLotctFUKmEqFfR3e0uVFv2amVybg4xqiPd6/1Ka6wkEcrtQL+RWN9ksQEAs+COUCvU56xvaX7qIhC7cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ub7+JtYehItOykzCxOKW+ymjaJZmleo+OZDLx35CzTM=; b=OOjTDv+mn4J/X8BNe7pVQSoIDdoEJ8cop2wSjuPlBX1N3bPF5BEYRmKJp4m7XiUUi2j0ctiDYmVGyQwPu03frR/bLSJlr8AVcPPsqSoRja93caKIHkXxPFTmBXHYCb50BklglPQJ7zHiJHQebtMEQYjAYVMRxAJz7aMkaeMqIvhkraCrXAjUInx9d2m69fqk9f2TmccjGQtrt6AtvRPC7RDiLBOkFddJoTi8gDW2ABItqQopaVpEZvoKgn9g1hVZOjaOUWfiKF11EWIrDxAlwz98uOzgVJYRsdhpyNP9/c5Qu7l5CjkpS+WWgRlvymaEamyPBG6P3dkdzOmN3Zc/rw== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by MR1P264MB2418.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 11:07:31 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::e72e:6d51:32dc:b8d1]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::e72e:6d51:32dc:b8d1%4]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 11:07:31 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/1] avformat/demux: Add durationprobesize AVOption Thread-Index: AQHaWOqM5u+SZuBRZUSM9BD5WOj1b7D9/SaAgCsnIIA= Date: Tue, 5 Mar 2024 11:07:31 +0000 Message-ID: References: <20240206105209.315221-1-nicolas.gaullier@cji.paris> <20240206105209.315221-2-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|MR1P264MB2418:EE_ x-ms-office365-filtering-correlation-id: e262547a-5808-4c2d-4197-08dc3d047416 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oF5pntYEIAr/XBzAEPK0TCWR94OpOOxgcAILeC2vbZtnL1+Xr8Nt/9TAjInsh9ce068LpfzLSl9F8e7bM97SPe9jMkI9XiOQPKDXR0uVEQZrLC2XLob8Zm9d9CMcPv6sfDPcQtOVBMQKe0JDf5D3c7LvZzGKVBrjK1Y4NS32iL/GWQz1c+gCB6NAIo9E1clmcdpJPHCUf6uKUsVESZy627rcUrbB/tKstCwGgxeaVP0qM3GbNGujpkg+sIZ2DS6oZOjiS52mBDmZaBbgWNuJ/ilKn2eiTzHHVyGb8tmC9Q0xyEhOHiYIAKepjjtL1YzlgkVaLIcFOBz5uESN0Uo6mqLQyDT5YFPyzCA3aT28NwTO2GD4tP20axRnBi201K16Og6HtBaEarEkLb1ii5nFsQa05L+OZJd8MOfLxWfkYFkOEWxwblisFBcJJQFGWXVASm91iM00T0p72lWg4AEvIPUWPFZfovR8R9A5CSp8Lo4vg9AxVQALhm/hV5Bsg3c2IcQ//tVcciHNP9TT/qxyWgTmI2i8VxOuCxNgfXzJLAemoCQZTvKWEsppfGjqZeBztgH5AuIuQX8pEP2ibgwICCsDBUPDVXQ40K39OTew3EhUfVYYzdjJgbEVKlpZceA5uti00fqixegP57k+supP9S56PUpr6yuqpgn6V5/STzgVrkHEYsgJKYzh3tQ0bQkliWANgK+gDLOYGUoTDSmT6iVnpgP8ZOJgkBBHtIVD59k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rNNwnXlNbki3pqJ1OPI3p1AwBylKCBcc3hOPn/oO9KAq1kbFoccLN12uMn?= =?iso-8859-1?Q?bAmyKWCLIA1F9IDbaRHelyVKJg8fONZDaQJMaAacSe/qOkUWsk1cgxQmM0?= =?iso-8859-1?Q?8EEa30bEbkIu/VRq4F77o2QZMMA5GP1c3ABh3/1ZkMLVs8iTLfxKPvuGIl?= =?iso-8859-1?Q?Y54a3AAIsT8gK9zrsab1TecoxmSyP5U+VprfWke8ClIhULGFsnWzzsHO2D?= =?iso-8859-1?Q?S37UsHk05L4yCSofwB6q8H1iqmlZv95ySzE4065G2A+uOe+qyyDJjo3zqW?= =?iso-8859-1?Q?oFYE5dHuhmKS/U4kUl+V7fPMcHIuns111Y2d8vkvo/RVNAe1HyRYyylQhc?= =?iso-8859-1?Q?EfjHsLVzdmMaJ4+a9gxOS+ciOlp8LHfOsQzVPSWiadWVSitwFRbOB3Ogkj?= =?iso-8859-1?Q?hF6AS1xfSKlWoxGaLZ7toxDPjlzLJHgtBNZ1UwFpsMHfYY/6KojmF+XKn0?= =?iso-8859-1?Q?RxFyUkeYyeveNA0gH7dXBhHbBEwke7/57VbvsVEbXyxt3oDZCCsgs4e0h7?= =?iso-8859-1?Q?monu4+VhBoHpfGnrAU/UkTA0+upP7bop4OEjZTogEcgPySkoS982/wEl+5?= =?iso-8859-1?Q?7BapdaqLDlfmOwAG3mplIUuX9fYMvk5589S0CwkjTvLI1igoAurybNnNgA?= =?iso-8859-1?Q?vPb5fTuM58YRaZVPoUdYBRh+KGqsP1gqHcaB9qf1CvW0Q2nmWK3o95tee/?= =?iso-8859-1?Q?r5F35v2nEnozyzMObL1+tc4CEA8h6sjZ9LDVGIJUm2OLPOhP9jC3lBqbLJ?= =?iso-8859-1?Q?5rs7LZMMBLcwKF8SnaK0Ux738mPLMBQjiVhxdnuOWuiMl/rq7eK7VxjKc/?= =?iso-8859-1?Q?VIgfmO1NgtrKkDRNfQRPVfzSGtEjdwOhx2HMW4gJCCeBsGuIo9QyZsBOr+?= =?iso-8859-1?Q?CuOE8+mc7S7YmDzVheI2smO0m52ibr4CrkrvZnKzX9kEIIJxJmygMk+KH8?= =?iso-8859-1?Q?GKN6hivmW7VsEQ80fxy+XdAWhAdPcgRt9AcfF1WY+8pg+vv/0eztJZtbj8?= =?iso-8859-1?Q?EUCwi2O9qdEbw2+0JXYS8XxEwzFz8g9ENVBvAdJvHQkCFwCdeV4Ei1lx6B?= =?iso-8859-1?Q?Ev8BvAzXk7pIl2ly7s9TggnI+JycXRQfcGoBlf6bM51IstpOYvyNWlnlTN?= =?iso-8859-1?Q?p2TlxSTXvtddTxY724nBgR8v2H/ctFuViVsmz+YE+s7bvuU252g3X2rllT?= =?iso-8859-1?Q?0HwOTFEpkVqoh+/zkjX1CltmA60plu7f96BRwM6D+2+9Awtc6WphEZd+bd?= =?iso-8859-1?Q?E4Kegpyng3lyLqfbLiM5x6A773jBjR9ewcCoEaZIEXo/NfWKOW2Dzx9iZQ?= =?iso-8859-1?Q?8UB4p5dAkrGD0Slx5H5b0/Nh+4nGLi6FzV/ftlxFE7kCOiGX9zrBHeQ8Yo?= =?iso-8859-1?Q?Jsl94biD+lLHP6vHK8R1Syk1Fkqmt04zQq64WJp18J9wMgmm4vcJFAXYfC?= =?iso-8859-1?Q?T1konGNdRVTElGyWP5j3esPwnruxNCeMC2hoXv+UwA37BJb4rsep9c2nQF?= =?iso-8859-1?Q?720EtlI/bQe2kOURMl3NVNPgLzB56OjSnEYVOlwY5IHd7txw5Ac2y/DZZz?= =?iso-8859-1?Q?KRvHKXnBaE8SKUFqj4RGTnzFRjVHQgnBXRueO26HCf2fXo87pQDHIeCGTM?= =?iso-8859-1?Q?U+QJjgl5IoPT6bT7tIdyxhD2X1zgrxC9Lh?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: e262547a-5808-4c2d-4197-08dc3d047416 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 11:07:31.6171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5LLuljMc/Za1a9GY6VLmmGOBBwaCmLS0Ji6tHnlyECqnQK1PzuikvI6vafKHe0sJrpP2ycOnKRmHiqO46aRW0KddTaujMJk9wMIlQd8nlPk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB2418 Subject: Re: [FFmpeg-devel] [PATCH 1/1] avformat/demux: Add durationprobesize AVOption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >De=A0: Stefano Sabatini = >Envoy=E9=A0: mercredi 7 f=E9vrier 2024 00:52 > >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h index = >> + * stream durations. Used by avformat_find_stream_info() for MPEG-T= S/PS. > >let's clarify this: is there any reason why this should not be used with o= ther formats? If this the case, probably a private option would be best. If= not, probably we should amend the doxy as it suggests it is only useful wi= th MPEG TS/PS. There is already an AVOption in the same case: skip_estimate_duration_from_= pts, but indeed, it is much more appropriate to mention estimate_timings_fr= om_pts rather than referring to mpeg directly. The texi says "At present, a= pplicable for MPEG-PS and MPEG-TS". So, I will just try to go in the same logic. >> diff --git a/libavformat/options_table.h b/libavformat/options_table.h = >> index 91708de453..c2bdb484a7 100644 >> --- a/libavformat/options_table.h >> +++ b/libavformat/options_table.h > >> +{"durationprobesize", "maximum number of bytes to probe the stream = >> +durations", OFFSET(duration_probesize), AV_OPT_TYPE_INT64, {.i64 =3D 0 = >> +}, 0, INT64_MAX, D}, > >duration_probesize? ... to probe the stream duration (why the plural?) The option affects the probing of all the streams and then these are comput= ed to get the overall file duration. I will update all the wording. The naming of the avoption itself is a big worry for me. I tried to mimic f= ormat_probesize, but plural or not, I don't know what is best? I will send a v2 with same code but all revised wordings and doc. Thank you very much for the review. Sorry for the delay, I was very busy wi= th my other patch serie. Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".