Re: [FFmpeg-devel] [PATCH 1/1] avformat/demux: Add durationprobesize AVOption

[Nicolas Gaullier <nicolas.gaullier@cji.paris>]

>De : Stefano Sabatini <stefasab@gmail.com> 
>Envoyé : mercredi 7 février 2024 00:52
>
>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 
>> +     * stream durations. Used by avformat_find_stream_info() for MPEG-TS/PS.
>
>let's clarify this: is there any reason why this should not be used with other formats? If this the case, probably a private option would be best. If not, probably we should amend the doxy as it suggests it is only useful with MPEG TS/PS.
There is already an AVOption in the same case: skip_estimate_duration_from_pts, but indeed, it is much more appropriate to mention estimate_timings_from_pts rather than referring to mpeg directly. The texi says "At present, applicable for MPEG-PS and MPEG-TS".
So, I will just try to go in the same logic.

>> diff --git a/libavformat/options_table.h b/libavformat/options_table.h 
>> index 91708de453..c2bdb484a7 100644
>> --- a/libavformat/options_table.h
>> +++ b/libavformat/options_table.h
>
>> +{"durationprobesize", "maximum number of bytes to probe the stream 
>> +durations", OFFSET(duration_probesize), AV_OPT_TYPE_INT64, {.i64 = 0 
>> +}, 0, INT64_MAX, D},
>
>duration_probesize? ... to probe the stream duration (why the plural?)
The option affects the probing of all the streams and then these are computed to get the overall file duration. I will update all the wording.
The naming of the avoption itself is a big worry for me. I tried to mimic format_probesize, but plural or not, I don't know what is best?

I will send a v2 with same code but all revised wordings and doc.

Thank you very much for the review. Sorry for the delay, I was very busy with my other patch serie.

Nicolas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".