From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CA75A4AF3E for ; Fri, 24 May 2024 14:16:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACBA068D552; Fri, 24 May 2024 17:16:33 +0300 (EEST) Received: from MRZP264CU002.outbound.protection.outlook.com (mail-francesouthazon11020003.outbound.protection.outlook.com [52.101.165.3]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D25468D29E for ; Fri, 24 May 2024 17:16:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PtgNNsAK5oNm8z4GOkPYAfcuhg+I7U6bgqoG9sXiKjOI2ch1qHHyI5S49+sMYlmJRrw8PMtqYLrI5WjOIW7T9hhbMXEns7stD4whndV5zAKpBKoNukQMJ2tWPDrGKOaWUla3Wo+4DuQjIPLa4IaghvnHMJV8aJ7eJUuBQyxEFQGmVRJrfPK3zdFsHbaO4LuG5RWm/9xDafAcfRa/L6TwZxf8t4D1MjLCd/mQUkDb1NzCCFSSSk3xn1wg5KApHIcQzAaCKiaMPCyFMOCPHfvQHPvBI6jjT058aVcLpi+aZ/57OUru48rXbA2MzRfEHBGE4an8qjC139lpQcqac1gZPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FoIDHQKhn20H9Kpd4qEYyQ/uaqmGB8+/Txv5YUeZB0=; b=R/OOUubZgX+vA3Oq1LadxQ/mtDbRRCLxcRl4BpO06V+GoEboH371mlOlz5wDTfc6aIqberx3XJl6xUFxyktErLpaRUf6lzqWrV7wkiaU3WcGfFidJ4bDV5ignogJNa92TmRdktnf2UA02gK5j0ei0TN5ErCijVJTHOF3gWOloTsC2aSuO74VQgr6Klelmzmqji5T7ic0I3ExqPDefbUu65JJLNV3oWyiY8DKTF7O3+wwdBSUZ66g3cO4S735cfdqddJwMtwrFqRRV2UQDVx3GMIdbX3SGNBflnUDddfmkTgdu15uykTSCoyMWTA32jKL1b8etIOz/gLKN7RNsYrULA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FoIDHQKhn20H9Kpd4qEYyQ/uaqmGB8+/Txv5YUeZB0=; b=Nh4jmEEwl81p0p55mDtw8+rWCTeoLLlU8E4y2i25fakxDQpixquuQ6UqsIeM0o33bVIlaDRHZt78Dn+GI+K0BjEtFNKG1aUnvOkyv06Pl9B6eudt10+JbD2ow6vnMA24LA3eML1e3aKh5c3oSOILFK+RGp+k5B9MkN+Ka3aicbVULKK/H0mfLK2VGVXXu5i8AwQbJyrr7Hlu853inAviVUopOnfyVdfm1lA6AsTs0n1f01pgMtSsInnXV/QqiSqnbdBRfKOTvfTWVxK8NsXl4CSPyV0fWKdtFyfLJykWG7qnmN8mcp1fDd2Er8z2xJXeMz8KRq/PDkgvL3eZ4EfWoA== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by MRZP264MB2151.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 14:16:25 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::a9db:c8aa:ffcb:e463]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::a9db:c8aa:ffcb:e463%5]) with mapi id 15.20.7611.016; Fri, 24 May 2024 14:16:25 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [PATCH v3 0/1] avformat/demux: fix accurate probing of durations in mpegts/ps Thread-Index: AQHahURjfPGGs3SnfUWz0HlPCi6ol7F0VsUAgAtVpECAJxI3wA== Date: Fri, 24 May 2024 14:16:24 +0000 Message-ID: References: <20240402212609.572420-1-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|MRZP264MB2151:EE_ x-ms-office365-filtering-correlation-id: 72ce3369-4902-47d7-a683-08dc7bfc1850 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?B8jk7T+lIOJzo4JF8eMBlfPonNKccAVX9xdW/ALNxE3VLZ82G7Vcij+qqP?= =?iso-8859-1?Q?KqJK1R67IWRB5rmXSAk1czSVm5G0Ybr7f9gaKBabWs9eb2Os3vtGrZPra2?= =?iso-8859-1?Q?+amMen6kx9xHDxjZlQnXSvrj8RAWNLFq0Li4rZxLiqEPP1FB3/5bBcRyYa?= =?iso-8859-1?Q?19ezZ3b5RGrfJrdF3eJb3LMMQdndS/7zj5hwOv9bzJZ8qQVlvfGeY52xh0?= =?iso-8859-1?Q?9kueChjUuqC2IIBge6Hb3czMEB9HqAUxa0FY3CU4COzRlj3HkrkS+3pj8g?= =?iso-8859-1?Q?Y1Cnd2VCQ/vBeGZ0pBkSv47hmpitthJik5uvnT2J7NMYzR6ORALf/D46S1?= =?iso-8859-1?Q?58rM+ITRHQo7aeIGL200bsEArEXZpcZYrOALcKw8JvoNE/bOTy7R8/vJG8?= =?iso-8859-1?Q?mxHp+zoRRvOAgAFiEeqQRXjtDZuKAFVSZ9YuwIG1Zq4PMin1G6Gd7Hj3AW?= =?iso-8859-1?Q?+T10fBQvwBj8uoJPGchz7QxZ+j4CMC6zC4HEU5IfWo+BGb6LgItsLcUJfP?= =?iso-8859-1?Q?MJirfuDIfCR+Id8FfTSlB7kjTAqWkQEhTolG+3Kh94PfAmuvAy3icbb6g5?= =?iso-8859-1?Q?89mII0P7iyqnQPyQYc42zxr8wpOYFEbZOUWCQEceVCe9qqrHQpAjzeRqr2?= =?iso-8859-1?Q?smemrYZKQIzgIU8MGhhOqfTEcPDKybm8ugKFlCK+xnlC5G7muvLdeV7t3C?= =?iso-8859-1?Q?KBeHVQWD602v2i2KvrCvSsDgUjYImeImhH+Ih/EHFneh2k6ZtsZRt/hUuc?= =?iso-8859-1?Q?A3KWD1lwcfQh7V3C891XtQnqaHH4znZcDAUk/DAuSGKotnAPmIAtgDVgE7?= =?iso-8859-1?Q?8H+LuzRdSBmR5Tnxe1n3tgLZxl1X2SnQnbRwTLtd4bYEkvdSaHdc9beTgB?= =?iso-8859-1?Q?iSJaG9PdjYlxtZqOLGkQEinVdZFi2QLl5kEDt6C53s4SqvfNXDX/NmwtZb?= =?iso-8859-1?Q?4DQ3G8I72wH8zmKGZ8rJHJ51HnYuWiZkenRN93E4NQNHiKjM7azKNbTPIP?= =?iso-8859-1?Q?LG6Ox3E91M0Yau2bjYGs+mCAAe2YbRA8PT1FYrUGyrAVGnk9TpasmNwzLQ?= =?iso-8859-1?Q?R9QZg8XIfDNra0IgKI5KN9iBVwGJqCZ3TCDcp0V6FI4QKqsjt1BStfmRU6?= =?iso-8859-1?Q?3uxSOhJz6WitYHfc2jeetFCY96GjtV9L9gKYdi/tuaXOGGL4qoWuAx3GRd?= =?iso-8859-1?Q?QEW4S2tGHgL1fLRAZ0MAz3kpxG9Wi5x6j+CZP9smBugD41D0ZY+GM8mhzr?= =?iso-8859-1?Q?2UtVBN3l7tYiNN4A/GuHSJJCvwIRzUV5q5MsI+7rHB1kq7LWthh2ehIJuJ?= =?iso-8859-1?Q?xlJYfcyPLWo3klSOzXTJtB95dQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?FblvLtHbhVG22gtzGcun9vY1IjCSDnytMPwtYV3LP+mCEb3pZhYLmeOWLm?= =?iso-8859-1?Q?Q0tLKeqq7OOlDj5UNf32u6NrJ1HcFzLZcz3htugGUHK0R8hexEXA903/g4?= =?iso-8859-1?Q?+jAg0jNqiHj11izNC1EkUBzwW9klkBkdaumPEYFrP79Dz7l5yePG1wQuJ0?= =?iso-8859-1?Q?VINMy1UHjTYr4ankBlhgBMGDNcOfoNwpSMUY4/5+naZriMmZ1H45/NrcqT?= =?iso-8859-1?Q?SnvMkpLHOGVdfVx+7Y89lQCXr8WnGT89dFlKqEOuNChGYchbPIHFEccR1r?= =?iso-8859-1?Q?7gJRzOZlGEj4NFJWMhi8yYZuRl5YBhA1KAPEZ/lhHnuZthsU1Q8DhnQQAA?= =?iso-8859-1?Q?Iw8vf7tvXdRHWGiwjmKtLBqrjHGWRt5+a70g3Km5tx7qRyNnJ2xpqHb99c?= =?iso-8859-1?Q?W+r2kQM4S5veNTbP2mchPQYW0AstFwPxOVp/lXT9b3z8mOSuH5G8uo2zlX?= =?iso-8859-1?Q?/SAURZRURjtBplJy50/yJpVZ8RME8Uv7vHBXTs9jbARJHMS5f1xjRZjbke?= =?iso-8859-1?Q?mp3GAGCq6CBFFdI8qcFXPlSww6833LXfG4vebLkdFeaTK0hkTHORjhqq/I?= =?iso-8859-1?Q?Q1GfxmKmhxrCH1fuxCjHOv4B9SvxrUUa3VKcl9NQBB1IL7NsiEHyiD5QV0?= =?iso-8859-1?Q?D9qOb0p/ST+/VG3INEFuuEgKoWSpXe4cvAxDi9s9kPHz4an5Kq4mOmHzVy?= =?iso-8859-1?Q?t27GavQreYgzQ26aiS20djXPjVJiFueVonwBjRiYBerCyrDsMuicbUHuxD?= =?iso-8859-1?Q?lmhsgWoFu9GOHFW2xzHPao1TrruqOf3NKOGLDAjtWH8mPoO5aR6iXeuspI?= =?iso-8859-1?Q?eN5pgWTnmBCb7zAQm7eOFE9ZFm7nA0vb3TLNUW7Gg4P/JfrF/bFJDhm87b?= =?iso-8859-1?Q?9Rj1shHMQHvYtQLUydNXN1KywSDyeHXypjI9Jqq+AvSRSkGyK0iAwfA3i4?= =?iso-8859-1?Q?hBizL4Ot/UkwKQLIiq5lMCdBrxmvRV4ZDmGIhwc+D12rM0424T66YNTyGm?= =?iso-8859-1?Q?sFH4bcLDRlk/Rtdh9mrEMybJNJ3WuE0nuo1qTWS45HWWnEG6bOa3dRZFNi?= =?iso-8859-1?Q?8J61TXCmnYXkDH8q5dic+/5cuDn17H6rWjuhfsYdZEPXL1ZHvJnnXhEJZ7?= =?iso-8859-1?Q?MLFprR1mWLHFKQTz6gxWXHq0x4Nu3XEX6Oao6qZgbXUAOPwdMsiwOZA7ex?= =?iso-8859-1?Q?OSjL3MDtM3Z+xFnKCsDQuBMM+vnXGuO+v2u8rqxWyHNsfJA7oe96v/qDEX?= =?iso-8859-1?Q?Ph/dHaKc2CZbZGADhfeDKrlSFQ/KG7dfLPa7tlIbGH0J2FEMrEoelbN5Bq?= =?iso-8859-1?Q?XQz2bkNx4ZVn4wMQRb6mssvZ6XOoY4x9q88z6lxuiXgwtM99B1COBpB3AJ?= =?iso-8859-1?Q?hBwGHLh+hWw577Xu9e74ylwVLwlUW8BKGgPwGtfxQQhZEJfIxBLVNjilqw?= =?iso-8859-1?Q?fM9UHUVxXONvQgUn9nU5JyPpKAySOLoTuIF+pV2UOfnuBVxnqo4jBZeaNl?= =?iso-8859-1?Q?UEJbzXrby/WMswU8vkhMsW0m1twr1rc2VlpQyO8V6KpsEroIIGouIaBHkH?= =?iso-8859-1?Q?rThi0jCm7uLSvBHrqUAUuZrsngmSYCD9obTccftnoI92A5rweXiG7+c8fc?= =?iso-8859-1?Q?Trqw23sPHFrmaUsvjynQRPCgpMS15OKhWT?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 72ce3369-4902-47d7-a683-08dc7bfc1850 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 14:16:24.9659 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QtBi4k3xGdyG0TGVXFRw+G8TX+DuSPOb/YLagt/Ozs6Lwa8d5TegEiqkq4Gs1g7gY91lgN0SeD1x6P63zVjW3hrFEE4H7UMwpxVU2d4ukuU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRZP264MB2151 Subject: Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate probing of durations in mpegts/ps X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >Envoy=E9=A0: lundi 29 avril 2024 19:35 >=C0=A0: FFmpeg development discussions and patches >Objet=A0: Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate p= robing of durations in mpegts/ps > >>Envoy=E9=A0: lundi 22 avril 2024 14:32 >>=C0=A0: ffmpeg-devel@ffmpeg.org >>Objet=A0: Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate = >>probing of durations in mpegts/ps >> >>>De=A0: Nicolas Gaullier Envoy=E9=A0: mardi = 2 = >>>avril 2024 23:26 Objet=A0: [PATCH v3 0/1] avformat/demux: fix accurate = >>>probing of durations in mpegts/ps >>> >>>v3: rebased after ed9363052f4b8b8 applied tonight (add = >>>duration_probesize AVOption) >>> >>>Note: I have no other plan for demux/probing; with these two patches, I = can cover my use cases, especially mpegts-concats. >>> >>>For remembering, previous cover-letters: >>> >>>v1-------------------- >>>ff_read_packet() is more lightweight, but it leads to important issues w= hen looking for accurate durations. >>>As a side effect, the code looks also simpler with regular av_read_frame= () calls. >>>1)Updates in the fate tests do exhibit most of the results. >>> >>>2)See also more directly the case of an audio PES containing many frames: >>>>ffprobe tests/data/lavf/lavf.ts -select_streams a -show_entries = >>>>stream=3Dduration -of flat >>>Before patch: >>> streams.stream.0.duration=3D"0.757556" >>>After patch: >>> streams.stream.0.duration=3D"1.018778" >>> >>>3)Here is an additional (commonplace) sample to demonstrate the benefit = for twofields-encoded video: >>>>https://0x0.st/HFbm.ts (say h264-50i_mp2.ts) >>> >>>>ffprobe h264-50i_mp2.ts -show_entries stream=3Dduration -of flat >>>Before patch: >>> streams.stream.0.duration=3D"2.060000" >>> streams.stream.1.duration=3D"1.176000" >>>After patch: >>> streams.stream.0.duration=3D"2.080000" >>> streams.stream.1.duration=3D"1.200000" >>> >>> >>>v2-------------------- >>>v1: There was an issue with teletext where resolution is set just once a= t decoder init (teletext resolution is fixed/hard coded), so it is somewhat= fragile: when a demuxer context update occurs, it is lost/overriden by >>>= avcodec_parameters_to_context(sti->avctx, st->codecpar) in read_frame_inter= nal. >>>They could have been other scenario besides teletext, I don't know. >>>v2: So now at estimate_timings_from_pts, with one or more seeking involv= ed (seeking is detected by the mpegts demuxer and set last_vn=3D-1, so pmt = is forced/updated and results in demuxer context update), it is required to= >>>preserve the info in codecpar at first. >>>Thanks to Michael for reporting the issue. >>> >>> >>>Nicolas Gaullier (1): >>> avformat/demux: Fix accurate probing of durations in mpegts/ps >>> >>> libavformat/demux.c | 36 ++-- >>> tests/ref/fate/concat-demuxer-simple2-lavf-ts | 170 +++++++++--------- >>> tests/ref/fate/ts-opus-demux | 4 +- >>> 3 files changed, 100 insertions(+), 110 deletions(-) >> >>Ping for review ? >>The patch (https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3D113= 86) still applies on current master. >>Thanks. Another ping... Thanks _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".