From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3F2D6452D5 for ; Fri, 17 Feb 2023 10:12:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A23C368BE63; Fri, 17 Feb 2023 12:12:44 +0200 (EET) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-pr2fra01on2083.outbound.protection.outlook.com [40.107.12.83]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C2A6D68B22C for ; Fri, 17 Feb 2023 12:12:37 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RktHn5PKYhoYB69NWiwWJ5+BMuQUWyevFHZ4tKjQIOLrk7RaLgcjMKPrBvrNLmS8w7i+9lTTcy1EhZCefn1Q1DQeun2nbcjJvhiS3ojQjKAvDnLTGaTd2mIgPwdsXA157/gsr8OQPIDq8obbfbetMwqRZ12PzPT1ozQmQVK3ZdrSv7zt1osGEGocSRNx29EPO2mOI6xLAnXfPyXL/ERfZklLEJyxgojjFdFy52Jl+QuJjG/FUVGQy/tk8LWt5wQrH8vIFD0orWr5djhs7IbSTEXF4lHKgz2pbmNGi5w5SNyOqPbW5Iz/jELEl0XeeGkqtuEKcntKN5O1SguO7WUfMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EuxH60KQgh68krjQxXoMB4ItqYtBit3v2/WPB5FehfA=; b=XBN5iJm8N9SVfkOk6HkyAFEJSXJTpWC8weqo1gChy6f+aYnq6iQ8laD+h6bBguw41J4dzFa2M37UGius0ITUIl21u0EtCkokin0JJT65mQLYsEhUHD9j9LzjqW3qUpBt5yqRNPeWB1+urWWOZfRtHy6Pf/PzxH2tyG9sblIeAZyDqZvQufv2J3HKT9GzyFOjPLFEd3nqIhzRFAzFJAL04giuuiG36GogbK7A4L3T1mX2boV68upxyk7CDiTg11SfK+Q5lYHMCG1oTboYh05uE9iiyCJcKB1UI5D6rhawiuJIkysYlM3HAp11ZDPFlFhyg0x44tHFZz8V993I64RzvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EuxH60KQgh68krjQxXoMB4ItqYtBit3v2/WPB5FehfA=; b=NaAFDm0L03ga+S/8yCmpoMCQb+Z1yzRJyCS39r9HpPE5wae2w3WcsWiKGTeAiE1yKxY3Gmwil6aA/QK/AsQz95ceCQ6SfKyr95UgSDgSMHayF5W7JCIdEB92DBQdglkoP0BSf2YtYpcNSeLw+bEWda4+Fq1a3bssfAJURgNCOMzKiMOCvViYWrzYB+OXo1ewiD5TG7UlCh11GFzM1jLTcBOaIm4Hj8UMrkOfkxDYjLKQn/cEp98UepnM6Xcfd81SWz80smkEc2W3SnchohgfH/bIpE/yj4PjPCJgmvxzESNIARRAXwAFCVOladw1L68//NdevMiqLtkFjKKrg6xNsg== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by MR1P264MB1619.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:15::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Fri, 17 Feb 2023 10:12:33 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::8249:6585:3808:5dd1]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::8249:6585:3808:5dd1%5]) with mapi id 15.20.6111.015; Fri, 17 Feb 2023 10:12:33 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe() Thread-Index: AQHZP9ZaycyIAzEUREuzGaQZb4kUxa7RZW+AgAGFoFA= Date: Fri, 17 Feb 2023 10:12:33 +0000 Message-ID: References: <20230213180936.815-1-nicolas.gaullier@cji.paris> <20230213180936.815-4-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|MR1P264MB1619:EE_ x-ms-office365-filtering-correlation-id: 5e72e6ba-9895-46d5-5b7a-08db10cf7ca7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rvMwAEDaCWJo5iHKO9T0FUVL3xTLwZgbWlRDbmkNpBfjRrjJWjav1nze7ufehKnrPnPCDoXKJun+7zMpPEFdJP7OGplvnKicxnRsstZFLuFOko3DcnDjzYKbILaZX65kEZjE6Mq265txy6PvRATw5a57iSE6x3Gklc2Vymh/Ebu5OG9BVO5U7igEpY5MBeP4SfCx6W/hZ2mUTsRE2QBvooEvCiZtg/+pBAA3Yr46bCouylV95dM7oibRwPtVuO0JZ+gB6u7hw6DyzDAo6BcgSodW+hNYj5it7DBAmaKkfNAPP1WMgE6TjAnZ4iqYuTGYY4y1naN1KzXIOeupyzElcCG9SAIedn+ScmY9pTCPBRscsHUH9nCofE0Mb8nDtiiWJSoyG+Avwf6VfW7brcly8OOzNLA2XiYAnaBaLr5SKC8TVR4P/KEaXINJPS1sDzMFK1HAb0aEYk/c2mMKVK9oDpsZ6BJr7z8ZPcfM9YnYCd/EUu9PE5xdEuGLM9FllqlUUONLRA99lkq9xVmfXsn4bYe7GcQjSENVCmy6cWjJ3ZzBUAE/OWDqaAH0JFtc9VF8bWHN/INpjteyZ5DRomqKd4thSqZ2nEZP2w8mfpnuV7rjqzMQgTtkz9A+Zcm2l9wWama9tN/8nOjdzWsji82pnHWYRzsAfwzoSVEWtZlZLTgx2x2IQ23o/YhCtOMOHO0XtLxRXnWwwXgrIi9EtGFe+5Wnzj1t+JnaDPUEdd0XeMg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230025)(136003)(366004)(376002)(396003)(39850400004)(346002)(451199018)(41300700001)(6916009)(83380400001)(66476007)(66946007)(8676002)(64756008)(66446008)(66556008)(316002)(76116006)(8936002)(52536014)(5660300002)(9686003)(6506007)(186003)(26005)(478600001)(71200400001)(7696005)(33656002)(55016003)(86362001)(38070700005)(2906002)(44832011)(122000001)(38100700002)(46492015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MVlvWC91UnU2M0JLdkVRVTlRMmVvdnc3OUVORy9sN0QxUmpMK3BiZ3pURDRH?= =?utf-8?B?UTZDWXUyd3hDTUxndWgya1pud21LN2hUOFN6UjhqWkxXenp1MjRGY2t6RnBt?= =?utf-8?B?SU9XbGMyc2ltRFR3RlZXK3VmbXNZdHV3dFJFTWRnWHM4VUVzdVFrYVVaOWc2?= =?utf-8?B?MjdWdWplcVROSkhBVnE0TWYwUDZVMFoxZDg2TlpFajdsOHdYOVJ0Vy8yRThi?= =?utf-8?B?ZDNpM1F1NlpVOUd1djVQblpYZjF0d0Y3SVIwQjQrc08vYTJjMHRxTEhnNFN5?= =?utf-8?B?ZUJoNGtTelhFZHZkZG9GUC9xTXFMNDRPbDlKQzhMUERZcEdvMWdDNUVzQnJO?= =?utf-8?B?NzZZVjhqWVVIZzlmY0hCdWhuUWJPMGFMcHlLREpKbkxFa0xZdGFGb2paeUh4?= =?utf-8?B?Y05PeElnTWFFazVGNVNPc0FEdlhXZGs1TC9hYktNNjdkVzVWLzEwOFM3eDJj?= =?utf-8?B?YWRON2ZzS0hMZ2k4WHE5ZXpTKzByUUVWbEVEaGppRFphbXF4MmRFS1luNFNx?= =?utf-8?B?d2tTOFROUUdSU2ZkSWMwRlBmWjNESVlnZER4K0RONC8wdXlwTXJzMm5Zc2M5?= =?utf-8?B?V2lJOWFaNFMxV1FSTDFGTE5Wcy80RFFpT1g4ZElyWWl5YUdrSlV3c0FoUjRZ?= =?utf-8?B?MU1OZVVjRkJ5WnkrMjJWKzUrVCswdTZKM0JheTZBa1RxVmx0WDdpS0c2cFQz?= =?utf-8?B?NzdUd0sxYUowbWVQYkpNM21DK01DNHNGQy9tMHN2RVFtS2hUcDE1bEVaUHM4?= =?utf-8?B?YnowTlNISFZnYm8vRk5rTWUySC9ldWhRYjd3cGpTdWpIM24rTlRYTFF2aDZz?= =?utf-8?B?V2RaZTlEUkI2OTJVbjBVTU16VHVsQXhKOTFReE8wbDhkMTUwUDh4T1Y4S2E2?= =?utf-8?B?MkQvbW1NbXhpSldoS25MRXhyMXRWOUlrYUxiV3hDRExORklzSmdxYTVhcDlN?= =?utf-8?B?SWhVcFptWjFBZE5pV1lNclQ1U29rTzhzRHU0VHZUcVY3ZlRuaW16SHllMitF?= =?utf-8?B?Q0l6bVlVTExINUdaWXFRcDl2QUFqSHpqSGYvendmd1ZtdWY0ak9Cam0yc0xR?= =?utf-8?B?cjA4Mm9LRDFQOUl1YTVhUHN6VU0vUXFTbFZDUk9ja1Y1MlFUL0xEYiszNUI2?= =?utf-8?B?TlNyTGh4WHlYMFI1MkdQLzJueTNpemxMUWlEa1hubE9WVEtnUnBvV3BwKytP?= =?utf-8?B?SmlHTVpXcUNjWUIwSzRUQ1ZKV1JpSlMvUU56eW5rVnY1RkZLakhoMFp4VVlO?= =?utf-8?B?ZUVLQWtDbi9ZRDF6RENVS1ZQR0h1UWQzMlRkM3RmNHVJNDhFQW1KRHBVWDVt?= =?utf-8?B?UVcwTmVjN1E3bURJTDhjN09jWTVoeFdUNFVqalFhOXZKMGxNWi9OSEVOMUpm?= =?utf-8?B?MnRDTkhJS1dxVTB5TlZtUEU5dnpZZys2ck1xNEYvdFZkRDBLTFJpVnlnMWh5?= =?utf-8?B?Y1BUSzlDVk9hU1NUenYvUTVlZlp6OERTZjRZVFJ4YVFyRyt6L1l0eWJjb2FV?= =?utf-8?B?M2g0SVBucitqRnNWK1ZlZEJneXJVaytFVXV6bytPTkw0SFNsSmlzbm9ZZXNy?= =?utf-8?B?MzU5V1VyUGN1aWlTQ0JveXpXSGYzVDN0Tmx6MVVQYmo2bXZSa3lDbFQ1K0Fx?= =?utf-8?B?VlBZQzFUMDk4cXJ2U0ZpdmVHWFpiTTVPaDl5bmJZYVVtb0wyTkZwM1JkT3Bt?= =?utf-8?B?dlpkdisva0lpc3RvanRNNXJpNXdMZmVZbXg0Sno5YmdOUU4wOEdTMVY1a3Fl?= =?utf-8?B?dGY0TWlydVBYeXdESkQwWjZ2UzIzRCtyMTBISjNFQ2pSQ0J0b3NsZjBZNWtO?= =?utf-8?B?c2EzMDQrbzRON0NtS2s2ejc1ZGtXbUdMZiszbTFBdXV4bWphTkh5S01Va2k4?= =?utf-8?B?dzF5cDhSbHRpckE3dWJ3V2FGV3hrQkd4dXUwYkpaZ1A1YzRzRnlPdkdlcFIz?= =?utf-8?B?NEdyRDhuT3kzVDM1REozWm9yNWlIZGgwNGRldEcyUmdkTUhlN2dFL0Y0cFVk?= =?utf-8?B?SVhTVFd2anBUazM1cUhtdzdHeDdsbjJ3Y1YydEJpOXAzeWNLWXNKWjhoYThM?= =?utf-8?B?dTRha09hOW42aGVOWWdQRFNqeERGTXJ3YVRIbFMxWEJGMERCRGw3S1V6eUoy?= =?utf-8?Q?wgt071olLPjocw+j/AV9Hti0l?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5e72e6ba-9895-46d5-5b7a-08db10cf7ca7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 10:12:33.8518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shxwuVj7FjCxRgH89KlQ2A2WyxUJ6iiLKO0I2fJMkquGIYhMW+q5TcfXhgL7WDIHXaVaWyajT4+OiZuTwW2EKeOf0mw4UiVoJ6ba3M4BFTM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB1619 Subject: Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > The logic here is a bit hairy and I don't have time atm to digest it, but is it entirely contained in S337m or would one need to read other specs too? > >/Tomas ff_s337m_probe is very similar to s337m_probe: what mainly differs is the input parameters. The one little thing I added is the S337M_PROBE_GUARDBAND_MIN_BYTES. Currently it is set to 0, so has no effect (and of course I can remove it if someone object). There is two things to know about it: - one is that some DolbyE decoder implementations does not support the s337m sync word to be the first word, A minimal guard band (full of zero) is required in such a case : 1 word is enough in the cases I experimented. One developer might find it useful to set S337M_PROBE_GUARDBAND_MIN_BYTES to 1 in order to ffprobe-qc/reject such files. - one other thing is that, currently, the detection is based on 3 consecutive samples, But there are other implementations in the wild. A common single-sample implementation is to simply require a sufficient S337M_PROBE_GUARDBAND_MIN_BYTES in order to avoid a fake detection. (for 16 bits, this is really dangerous!; for 24 bits, I think it is fair but would still require some little additions to be 100% sure). Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".