From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FD2344F1F for ; Fri, 10 Mar 2023 16:25:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF57B68BE3F; Fri, 10 Mar 2023 18:25:47 +0200 (EET) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-pr2fra01on2089.outbound.protection.outlook.com [40.107.12.89]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EDA7968BE09 for ; Fri, 10 Mar 2023 18:25:40 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oR7gL3jWksKyqtKkmchrBIfBx1ylPFw4annLMNFfsp3jPjfznpfKrOyZZT49nkjnBRRSMhJgU2XXWHzfsaOe15zFP5CYyokGQLfUzLbxYkZu4DMd8V7aCGW/cPqKAevq8aj/7zAZEl7X+SULikWtngoDriZZTtwKRjjXvMvhVCdY8WGl3Died8HJif6MBDi/JL8L+Z/wESBtuuWzM092u7r9IrmNobKjcsDck/dBNrYEuaHTKeIDWFHNK61Vxs1iB/PT3hKvWoUWxsfqLiR0sT/L4apLkj5NWyxPqHTe4fnxFxd2kIKWKFO6Lj1agorH0puzS7sFRP0Hlk7N0SglTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=llmYjkr8x7rc2OXNkawA6aX8sW9VtRYG7kq5femgdT4=; b=hjQI25OLlie0dJ3aMUzybDlPkR6ShuQjho0PIBHH1QcED3JQJcKUP1XcNyUSlpcXh7H3ISydOXQHBS63C/2JvvrnWwi7l5/KV1S9S7p8FiMjJdKqMyXv1oVutBSwpaSwurqpeh8HVmIPdnWeBamojq5uuvOWU546llRD7kvQGBg3Xjiny9tAbqJzgwiDMbyDAqTEJEQXVixTI2Ud5HCkZH43E+NHFCGZSAxC5/n7h0mFbxk5QrbPSkIopsnd56pPdcViA2nuqpH1eBG4/lNfPakPWpGFSB99Hq0xh4tHZVDCWaRIrTEEPMdIWTb6TcWD5z+MLGO4uCwOaE1voc+h6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=llmYjkr8x7rc2OXNkawA6aX8sW9VtRYG7kq5femgdT4=; b=Pz4DF9Z9MY8AnLMbZVOcqAdGNPo6GT24Y0W/WMXgfkC6K8sYBGFRVe+mXSH4UvTj1EbR+ka0s3ewWreeeVOZ1hyFMAGWDTBOe9a8PDOjwmlo4xVHVavC2/ROhmdIrIJLHRHtwz9m3o4vNifw07w+uvBUpW6PkK2deV/2cot5tU50Qs/5CjF+gc3a9Nm42vKK+Y+QSXcKWse9a1I/cJ+wBnAyHmEOkONPTL94PjZzo9mOtkyXzhMcEq/kawwt1PJwSMbHPZcsMyRrP1toriICBziZ4YxDIxbzkJ1DmMlb0cDIIGyHj7PdbCoXcTL3Ifq2KD66ywsl9P7YjgIZLwxIsA== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by PR1P264MB2160.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1b3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 16:25:37 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::8249:6585:3808:5dd1]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::8249:6585:3808:5dd1%7]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 16:25:37 +0000 From: Nicolas Gaullier To: Devin Heitmueller Thread-Topic: [FFmpeg-devel] [PATCH] decklink: Add support for compressed AC-3 output over SDI Thread-Index: AQHZUpCf8MZXd2XNtkW3eljZI3rbTK7zoS7ggAB1KICAAB2r0A== Date: Fri, 10 Mar 2023 16:25:37 +0000 Message-ID: References: <20230309140808.5946-1-dheitmueller@ltnglobal.com> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|PR1P264MB2160:EE_ x-ms-office365-filtering-correlation-id: 64bb94cf-da26-41f5-d85f-08db21841540 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QuXcFyjUOpnMkFjQ4034eHrj0sEQGhYakBT9vhnFCimG+ULvNht8I622BEfU0Z3r2aTfcbAOzuSWD6QQoYTshKZxozikkJoC++3FIrpymnP2Ku4HXv2B+sZDFB1UaZqljdiBAqJ+fV3UwozdW26AaAR+qUeI0BsCKYh+2zXy4f4Fu83jTR0N5qGU2snxGCdKmsenp3wMwHy8gXJgr7px3pOwzqDlK6vWTuTb1e+jaBt2rc7G5mP/ZwsULX9fE/D8/KzkyHpWvC/rkPLMHnqXe6Ru2E2/2O9NdyGRbcL+Jb6cbRemQydobXRyhSSgyEsMGS9O0sIdJGHg9uW1qFFOScBP61/DIr4LjABCGtbd3rnTco+erK3TM/VPju7mivVjdYvE8vr0Kpow5VvKtA13hKODXcUF4z0+32tnyjnFrSFaStNEerR2s2gbPIvBRTxA68k54dmRfVl5s5SEvsvIjlEOmT78z66wlR7/jV337GDwzFvRfzIDk04xwzVe1NTVsGCrNi55ipxWPyVJDRMsSD9E4HmzkjiwztbY2lUEIoFBvyWm/nd3chOqtzgkdV/dhTfA62vKA9btGnM7vUGN1JO3IkJqcJBDdDp4lO5LKbgBkuuntT9eCpbC13LNOAcOMQ/38H20O4FVuxpPCyaR2Dv2S3KNVYFklpZ1Zb94QRtiis15Suybx/q0q9aB1YjLOZ13AXewSt1W6xwgbf87PK8mhTFuvOEiXD0pQxv3TxY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230025)(396003)(346002)(39850400004)(376002)(136003)(366004)(451199018)(54906003)(316002)(478600001)(33656002)(38070700005)(86362001)(55016003)(38100700002)(26005)(6506007)(83380400001)(186003)(9686003)(122000001)(52536014)(71200400001)(7696005)(5660300002)(44832011)(8936002)(41300700001)(4744005)(2906002)(6916009)(66556008)(4326008)(66446008)(8676002)(64756008)(66946007)(66476007)(76116006)(46492015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c0JjTlpnL0hXcnpVUlRJUHg5aXVURGhlVWFVOURWazBMTU0weTAzVzg4bzkx?= =?utf-8?B?VTIzYnl6N2U1UDczR1NqUmllVTJlSkxzaEdUMDJKaTdhNXU2Wkliak40UHll?= =?utf-8?B?eXUxejZUSFhRYkRsNFhrcDlqWDRwR2JvcU5pU3RRR254SDFmdVk3R3ZpeXVy?= =?utf-8?B?QnZ6b0c2S0daZFJJcDZmUllaR2o2eWRTWmpGYWZhSzdveHJ5d0xaWWdTbHhq?= =?utf-8?B?TzIzZWkrdkdQNjlDaHd1WmJPZmN2U1ZqRm5RKzNoeCthVjlJa1B4VWZ2WlRi?= =?utf-8?B?K2NaYlh4M0FuYm52NjdXU2F1V2JYM3VzZ1BMazd1am5yaXhFQW5KZnR1VGRk?= =?utf-8?B?NlJaSkw3WGtRa2srS3laSHYySCtvVmMrWmJ1eHR0MVRTWXZTSit6dGwvMGov?= =?utf-8?B?T0ZlekRCUm54Uy9IRzVFV1VYaTdPT0VXZzZSRXZQZFRJd0NUSkkxd1kvZ0JQ?= =?utf-8?B?T2dONlpPUEVLeEJKMUFOVVJtcUh0TzdwZXhnUllJV2xxTyt6bmI5aU5mcXd5?= =?utf-8?B?Zi8rbkxhdUNma2MxU3Zqb09CN1FwbmxpNFUzVDBncmlOUHY1RUEwZy8wcjA2?= =?utf-8?B?OHp0N3ZjQnM1b1ZCN1hJaVNSdDd0SUpKTGVZVzhhRGxiT3hJUkVFNUVmQ0ND?= =?utf-8?B?VFNJandFQ2hiSnlvQjVWQXpBR2RFd0o3cVhNUlJGc3loNWxxbUhEb3lRYzRw?= =?utf-8?B?elJEdVo1UzZCaWhQN2V1aVlmWjlQVk1FVGp4SGpiVVNQS2RXcE5iOW1SZGli?= =?utf-8?B?bFVmWUwxOHNSODFnVmloNGswaE8yNWVhZnU4NFBwY2c5TXNwV3BUWThMVkRU?= =?utf-8?B?NXdQUm1EdlZYOE9MTWhvWEpDTkxtY1JYSzVwS1oxenhhK2xDaDdHR2FBM24z?= =?utf-8?B?a1Z3KzhkdzRpV1FXL2Nnd2ppSGw1MjJDNE52QzJJcjdHR004NVo2RmlEM01T?= =?utf-8?B?MDFuM05BMmN0UWgxdzdEM3F5ZFNQUk4xZnBQUjhVNUluT2tOcmxFZWdwcHFT?= =?utf-8?B?OWRzemVmeWtNRGs4SmdTWngvUktFU1B1ZzdNWUdRN0w3aDZ4OUFUZWcwMk12?= =?utf-8?B?SjdYcStQcFk4cUV3US9CcGV5eVFtNjBqM21lb1NTZmdwV3Vhd2ZpZHJ0YllK?= =?utf-8?B?MXovMFFuWGRsdlFLbkQ4OHN1Mmo2cVUxZGlESkt5Ni9mT0x6dUhFeXA5MGxR?= =?utf-8?B?UUFZaVZUekw2SjhSN0lVekhLSXFLSGUvMEhtV2pvSSthMzJLVGo4U1YwRUc1?= =?utf-8?B?K095Q2RJa1ZKZmR1NmZFYmZNLzlpVldYYzM5SjVZOFVXd0YvUHBHeURxWFVW?= =?utf-8?B?aHM5T250MjNwN3ZXWDFTWEl2N2lQQTFIdVBwc2RCOThLK1dWT09VRGZEMWZu?= =?utf-8?B?ZUt3eklablJpaWJ0V3o5MVlCLzZUSTBzQ0E3MlF3V0NzVmJhYldUbGtXb2hI?= =?utf-8?B?NTE4Q2YvSkpPKzZ3MjgwUnhKZWkwUGNoYTEvdjd6R2tXSFNoTkFBRis4RWhU?= =?utf-8?B?aWNMV0RxOGpzMzFlV3o0VzFrSUZjWEJ5WExLNTFzSjA0eG5zOS9VdnBjZFpO?= =?utf-8?B?bUxJUzNCTnZycHNRMW1FL2N1cTJvbE1TZzl2am5FV2tUeWlzWWp1cEJUTmlx?= =?utf-8?B?L081RTRyMVJPUkdmdWFsTllacUNpTmVQUFhwTUFvU0JQQm56NjR0QzFXVVhW?= =?utf-8?B?ZXBiMTdsS1JjR2ZIM2xRWUVmYUxwT0c1UzRQRHZZazFyRUV0eGJ1S1kzdWJ2?= =?utf-8?B?WEJuNnUxcThOdm53RG5jU1hxQ3FiSTU4SDFwdlFDeWVkalBmZnM1WDVKdzVr?= =?utf-8?B?VmZmQnFPZU5NZjRPdDJnaGVnamYxL0dhZkpRTk1LUmk1VStXWWRHVHRXcTM0?= =?utf-8?B?WjdkRnN6bHh3b1Z3TDBZSUNyaUpUVTR0VGRnRjB5VUE5YlRQMU9pdHhBOVVK?= =?utf-8?B?dVhzWkRlc3B6Ty80cXNadEtOdCtaL3JqTGlxRndkUUwxdEhXY00xcmM4ck5T?= =?utf-8?B?Z0hvMTVPdXVQN3ZwR20wbXdXTThsWXJzMDBTZVE4WEp5VE9XM0cyR3ZCcDM2?= =?utf-8?B?dXg3REZTa09vMVhpY1ZCK3VRUytRL09RNDhET29DM1E1VHpVdFRQQXk1UUxr?= =?utf-8?Q?zZaKbbvnLMm/gmYHe9dTTvmxE?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 64bb94cf-da26-41f5-d85f-08db21841540 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2023 16:25:37.8402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Nzk1fVkk1hMVdfRNTTpUPcvuMCJRPQSduHjPAvQhh/zgtEVWzsrdP4/mTZoJ0heXrsHcKwTFMNbwjHuDmNxhNVZbG+5xyc2VfJXPWYSAWM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR1P264MB2160 Subject: Re: [FFmpeg-devel] [PATCH] decklink: Add support for compressed AC-3 output over SDI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Devin Heitmueller , FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >At this point I'm inclined to keep the code separate/private to decklink. It's limited to AC-3 and only produces packets which are >s16 little endian. At some point I think it would be worthwhile to have some common code that supports 20/24 bit, both endians, and other codecs like Dolby-E, but my concern was at this point that would require a bunch of extra testing (much of which I don't have the >streams or hardware to do), and I didn't want to lock us permanently into an ABI that I didn't know would meet our needs long term. > >Moving it from a static function to something that can be shared is a relatively simple operation, but I want to wait until we have a second use case prior to refactoring the code. Fully understand, yes you're right, thank you for the answer. Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".