From: Nicolas Gaullier <nicolas.gaullier@cji.paris>
To: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
Cc: Devin Heitmueller <dheitmueller@ltnglobal.com>,
FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] decklink: Add support for compressed AC-3 output over SDI
Date: Fri, 10 Mar 2023 16:25:37 +0000
Message-ID: <MR1P264MB24834C40A153A132F564ED739BBA9@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAHGibzGV3sRzpE-GtrsHpjE=nK=ZoEWrOhEhZOh-C2V_UjTMEQ@mail.gmail.com>
>At this point I'm inclined to keep the code separate/private to decklink. It's limited to AC-3 and only produces packets which are
>s16 little endian. At some point I think it would be worthwhile to have some common code that supports 20/24 bit, both endians, and other codecs like Dolby-E, but my concern was at this point that would require a bunch of extra testing (much of which I don't have the >streams or hardware to do), and I didn't want to lock us permanently into an ABI that I didn't know would meet our needs long term.
>
>Moving it from a static function to something that can be shared is a relatively simple operation, but I want to wait until we have a second use case prior to refactoring the code.
Fully understand, yes you're right, thank you for the answer.
Nicolas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-10 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 14:08 Devin Heitmueller
2023-03-10 7:44 ` Nicolas Gaullier
2023-03-10 14:36 ` Devin Heitmueller
2023-03-10 16:25 ` Nicolas Gaullier [this message]
2023-03-13 23:38 ` Marton Balint
2023-03-17 12:43 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MR1P264MB24834C40A153A132F564ED739BBA9@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM \
--to=nicolas.gaullier@cji.paris \
--cc=devin.heitmueller@ltnglobal.com \
--cc=dheitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git