From: Nicolas Gaullier <nicolas.gaullier@cji.paris> To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org> Cc: BUCCIANTINI Francesco - ADECCO <francesco.bucciantini.adecco@skytv.it> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits Date: Fri, 14 Oct 2022 08:03:18 +0000 Message-ID: <MR1P264MB2483307D0B7DF46F58BC394C9B249@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM> (raw) In-Reply-To: <20220913213127.1756-1-nicolas.gaullier@cji.paris> >Envoyé : mardi 13 septembre 2022 23:31 >Mantissas are the last data in the channel subsegment and it appears it is sometimes missing a very few bits for the parsing to complete. >This should not be confused with data corruption. >For 5.1+2@25fps, the occurence of this issue is pretty steady and about once every 2 hours. >The truncation is at about 950 out of the 1024 values (never seen below 923 so far). >The current code raises a severe 'Read past end' error and all data is lost resulting in >20ms(@25fps) of silence for the affected channel. >This patch introduces a tolerance: if 800 out of the 1024 mantissas have been parsed, a simple warning is raised and the data is preserved. I did not received any feedback yet (except trivial wrap-lines warning from patchwork). I tried to contact foobaz86@gmail.com > 2 weeks ago, but with no answer, I fear there is nobody behind the screen. And no activity in https://github.com/foo86 for 5 years. Maybe MAINTAINERS should be updated ? There are a lot of things to come as DolbyED2 support (rawly already decodable with current code) and broader avformats support, so this is not only about this single interoperability point issue. Thank you for your support Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-10-14 8:03 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-13 21:31 Nicolas Gaullier 2022-09-16 8:28 ` Nicolas Gaullier 2022-10-14 8:03 ` Nicolas Gaullier [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MR1P264MB2483307D0B7DF46F58BC394C9B249@MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM \ --to=nicolas.gaullier@cji.paris \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=francesco.bucciantini.adecco@skytv.it \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git