From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CB266457A4 for ; Tue, 21 Feb 2023 10:57:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E8E868C0D4; Tue, 21 Feb 2023 12:57:20 +0200 (EET) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01on2058.outbound.protection.outlook.com [40.107.9.58]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0939D68C091 for ; Tue, 21 Feb 2023 12:57:13 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JRAa1J6hRu5i5K4ITGsPHVvxsbZNZxrVl3fePBjy3y7e8VP1Ya1fFC4ujpgipKB7IHVrLDfALGTdUlkj7qpxRFug/XyjUpBYFfh49jvGMY0qLr2KTsRH/w6VueJvWTDmXKx5idOyW8rQ7EcqcNOQDgY1tbtBkA/pZlezrEWKMXQkagqfa2zoy92knwheUJFXpm308Bi1UAHvV9mje0MwDIjr8tTf+p5G4VTzrXkkCWnIqSWz9WGsww86pyjMgRkAnNOZ0GmQnXIIly7dPOZmop4iHNqsepnUqYdMj1te5tOQCRT49V1bPRFac7z13l+0DeU67ydyAyEhIR/PHuCooA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=or2fvSIm5lnzwjACzso2+R9XEFEgK6Uylksh25IXq9E=; b=kTJFDoa57AZw6jNMHs4K2cDSRjy4+Qp/ohyI8MZQUDOZG6kcKDAbm9exlc6JBMD2WG3+6H8dqtaAI6xC1ZCLyUuOQfY/StN0IECv7aAS10cDFOw3z9q0/cOY5l6j4BdZQ1KswiHgkzF7BHgxRyzjXFJXjo7e++R8uRugHhInnB0aInnNSWzea3ULhpPP10DMTF8lrWywNUjyk4l8SzMk2u6DB5UXEK8Lzaj/tSqdW9tJ65w0U73kzoCFUtkeAh2DbIjQprZn69LH1YXrBx1go5a/ZRYeEOqTaWhL271Xhpvy9M6HHLH4IKQDI+nApOH2qly7XzNTc334FVcFVZWWBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=or2fvSIm5lnzwjACzso2+R9XEFEgK6Uylksh25IXq9E=; b=kz87m9vp3hwSK7O9Xcixkut77mo/WtwinJxtnKGdhBnIKLgenMJwK9utddc6J9iNr92z9KSKsUgn2HdilAyFFMyj0cfRPTR3QW0VvkewMWWb4R2TleWSNZSMZb8C8DzEnhpCkSeVpfyylAdaVIV4/XAHXsD3xJYjs1AYkVxmWAnNEVk6d+BSIwpPw1SViY0KW3TXkZjz5WPVLtoPq4cWW4GZtw+MctURPNaiCtiwjYLpTTFkI4oRNhOZDuOwMlNU/5rI0VqLK7uygd2exbA5kx3dTZoR/iX1jPkKJk0w68EKANCdEaRqL53wO8LzU011kqMZzKImk1DB3jmVKeSZ0Q== Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by MR1P264MB3153.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:57:12 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::8249:6585:3808:5dd1]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::8249:6585:3808:5dd1%6]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:57:12 +0000 From: Nicolas Gaullier To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe() Thread-Index: AQHZP9ZaycyIAzEUREuzGaQZb4kUxa7RZW+AgAGFoFCABkapAIAAE3xQ Date: Tue, 21 Feb 2023 10:57:12 +0000 Message-ID: References: <20230213180936.815-1-nicolas.gaullier@cji.paris> <20230213180936.815-4-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB2483:EE_|MR1P264MB3153:EE_ x-ms-office365-filtering-correlation-id: 5fd42ccc-abab-4c35-a7dc-08db13fa62c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F9w6jV1HlmPDFRR1njbcPRvaupjy4t0ojtqhLHH4ZTaAdEJX/w2/rLPERd9xZUXY7nyRFT9koQ4vMiKR4CQ7jFk6oW83elH8NkJYf4mVw46PcrVeQe/8IFYqTEyi/lYeBlpTudIjY00poQmbZ0WapSaEj+ofXxFbxYR0De0L5Cwvkd+pAg/Csxv9vHqa3hqUHLpSbRG7yQeTJQq1Hd2XN+xA41HeYweLSrBohWYg+n7VipwUL8AC5f/5Fot0s2mWXxOf22RqqJrFwJBGWLukVDcgbCfm2ER3evz12orvBGNkUqGqcxOUIrUBmLqQAgraRvICbrsT4Sw/p/eESL1Obxkm91rviUgm+aX4Kbt1HOr7bLAEkEB/P9aWf2F5TnQmgTDraMKJg9DuMjgWvk/bCamGNHy6sZa5qTCbXsIO8SgXcbZLqw9li6pGHUazaE/CpYBpQyuqbJMiQcXreoEpUhVzvW9mGeGzgCwdBcKihrBJJ2/fCLQxfuFoRprmV/9JG4tky2ANt3/ojZ+GskUu8ZRmVwM5dlQLAJyKgo5oWbPdX9R55XZ8VGVjMTdnhfkZDjHingPGCr2nPfFXHNOijHvmMXOjigBziIijzlnfUs6xcDzBTCenagaA01gmSJIuSXVBNOaXVkDR7LaGiCi9fiUHShIXCdfbJk8X5eFzK3u1/NB5eDY+8TENbCHiL5/KruBwVxNNGOaQl5rKmPOxwFEVEt7QLfovziqVh0EJ8To= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230025)(376002)(346002)(39850400004)(396003)(366004)(136003)(451199018)(41300700001)(83380400001)(76116006)(9686003)(26005)(33656002)(316002)(55236004)(186003)(7696005)(6506007)(86362001)(478600001)(71200400001)(55016003)(38070700005)(66446008)(8676002)(64756008)(66556008)(66476007)(66946007)(6916009)(2906002)(122000001)(38100700002)(5660300002)(8936002)(52536014)(44832011)(46492015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V/bNHFWTFpqm43Wrt4Hmaq3esnkLtrxuAuuFYDN//kYJ9kNObHMwrOECTtsV?= =?us-ascii?Q?kcb1heuawMkd1/K2IAbm1CNzWi7J5ZAosq7PhbyvxEO9arb7b5TquBaDtqkm?= =?us-ascii?Q?32q+2QNM/quV5XAw/oBuD/mxhcf0lTshq9KQTm6+WhGMZfowv3huh9/2sJ2O?= =?us-ascii?Q?HR5V6M5YZmipFC4hAuUo05nTgULaGQ1YggUoU5AzgJ+IqeKaGammQrugGJJz?= =?us-ascii?Q?BZrDi8iAaAXr0NQHABK7MKUVx18i92E1vtm36B+8J0wW02XNYsVmDeILro1i?= =?us-ascii?Q?rYaxab+o7cbtIpoYG5p1+6578Ctn2jpH1lMYiZqa1k7L5vZP49pf/2KZKHDD?= =?us-ascii?Q?mUCqOYsXBwWNZt2bKQkZXklYLojJNLzdgu1lUNsQALQMlCg6/IjY0arQt3S2?= =?us-ascii?Q?uSHvN2HklQn0Q7+r8KapPLaahcOR8kz2NUHjlkEZpoBDmGYdBzNl9aIX/vGQ?= =?us-ascii?Q?/UoTwg2VMuOLfufj5b3+r7TiJsoOn2AGNa/gwnMfEA9G/8xsGFfuUZZJsJh+?= =?us-ascii?Q?dbpBnUWUYsGZGyLSk3WX6kMGvwPEbznbLotePiYa9WDDL0QXCiIa/Nzr5/qx?= =?us-ascii?Q?rJebHVaK38mNjwTrw1lb3m31z3IziLgTWFmzWbCWp1YuHgRJ2D3GLtl2eORK?= =?us-ascii?Q?NUXnFwrTWifaogDI+4/ANs6z7rhqYl4A9tBdMKfxER+7PuqSr8vgIcmeKVoS?= =?us-ascii?Q?WvW1hsA5bIusyRWEyxqnolSpFFVOmuOIGAFqT+ZQ5Twn9E80sxGhD34SdgCJ?= =?us-ascii?Q?89gt2Iu+9q7TIE6SytShWekcORsYk82Nzh6z5R7hKs5PM8GJkQ9zn8myYwzu?= =?us-ascii?Q?VuS0JBWcTsSjPpNwjDU3CcGp+kqVZB1YJiqYpYYE+c9xsIL2CCcQfk9sj0r1?= =?us-ascii?Q?NQrpGXYmN/XaWr0jtbFZKt0HfyL3SwP80fXVq7qqY9p8fhpWRE81EUgk84w6?= =?us-ascii?Q?0xuxRLZcP/DmhILzeefVwvlOwUVJ1i/UZeC50onQ5aHGaB/uKmE/diUdzUrp?= =?us-ascii?Q?vrdoYFSV6msdFl1u3Yz9r4saoJw/6CWVbwswY5Oi42VNKKpqBT51MbrLkH6Y?= =?us-ascii?Q?btS6BPiN9NB9MBV8a3kYOTKtbTePI5EOyhep+IEzk/i5LQrtepxyCYL1Pp9x?= =?us-ascii?Q?KjbKk1K+vRKyfYvpr0ULinps2YHfSqoMZcfZ9jj4SwHGDlgfEQHOsRx/PAz1?= =?us-ascii?Q?CYxmzCvGMMqoX5fqSvrg53vdjbqTwR8urMzha7kbGhwps0HmjmURGMGWogMN?= =?us-ascii?Q?eZ42hWFitU7c38K3zM+Y9Rn+tM1Tybyftyuj3vOhljdA+CpS24TmU3ydVTqQ?= =?us-ascii?Q?EIFBTqPyFqK1lBzytkaYEFoqG8Bwk0l/bxUzH8gUkZvQiLqt9zH8e+1w+UV1?= =?us-ascii?Q?QgNEmjTKk+gdlqARB4256y/VJBRgdJ++fP5cZB5xh6jmI3rzhdPuqYtp8lXT?= =?us-ascii?Q?mO5BbHDc93nzeD4FpUyfL1ptn9QHA3pET/47r4/6jA3QI3wjqkU4/kzIxAIN?= =?us-ascii?Q?gJ8/R8bI55ot8TPaPFwFqf7Wn2rtIB812IBjyRa+LGXENajIQTxndPU9q2MH?= =?us-ascii?Q?6JmKqbglPGHleu378bBAtzUF2tCK4Gg0hNrXqdd+eycOU+MoQZnlvBEAQnhE?= =?us-ascii?Q?pQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd42ccc-abab-4c35-a7dc-08db13fa62c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2023 10:57:12.2435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7V44WP8aV23J+dFnROcZvrGZG3i6wbrzAxFBcWUJIyQErNpcb3aX0/1y8cuk6vTtCl6CakCjXOEx8tSwQqkHOk4uUEmQf0Ql408z/mkrlW0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB3153 Subject: Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >> ff_s337m_probe is very similar to s337m_probe: what mainly differs is >> the input parameters. >> The one little thing I added is the S337M_PROBE_GUARDBAND_MIN_BYTES. >> Currently it is set to 0, so has no effect (and of course I can remove >> it if someone object). >> There is two things to know about it: >> - one is that some DolbyE decoder implementations does not support the >> s337m sync word to be the first word, A minimal guard band (full of >> zero) is required in such a case : 1 word is enough in the cases I >> experimented. >> One developer might find it useful to set >> S337M_PROBE_GUARDBAND_MIN_BYTES to 1 in order to ffprobe-qc/reject >> such files. >> - one other thing is that, currently, the detection is based on 3 >> consecutive samples, But there are other implementations in the wild. >> A common single- sample implementation is to simply require a >> sufficient S337M_PROBE_GUARDBAND_MIN_BYTES in order to avoid a fake >> detection. >> (for 16 bits, this is really dangerous!; for 24 bits, I think it is >> fair but would still require some little additions to be 100% sure). > >What a mess.. And there's no other way to reliably probe this? > >/Tomas No! But the statistics are such that at some time, a fake probe is not "possible". Anyway, we already have stream probings in current code, not only considering wav. I think my patch is similar to the spdif probe and safe. Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".