From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DC0CB420EE for ; Thu, 28 Apr 2022 11:23:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E05BC68B3BF; Thu, 28 Apr 2022 14:23:39 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2086.outbound.protection.outlook.com [40.92.21.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB08D68B39E for ; Thu, 28 Apr 2022 14:23:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OaV8TROy+KTD+tliFsRMgz++8NPFBAqIq6UhZErD749BJMrtDmmKBVJRAJIr/naCBmOpyTCvCTVZBj3+93F1DHCjHQ0uSxqpv8WCMtAw5NqM8QuXuC7HMphDFiBlRCaFdMAUe6776mM5727bSEXzdxS33ELTdYkR2DHw/RS55m4GHJahe456dLahEquqrUY/APQQ9NAPCGhe46zgoDwamd1kHkYr5ssy2xHygEkG5Sut7NvuR6D2dvSdlQl67rwDGSxcbdQcfAw0I3a91feTkpoI5JMPUxK3DVmRuSEa0H6/1d0Z0tJBRmAw6uJOwtcYLEJ+84spiDLY3TNs3p9c7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2S3sP9AlfqRt+7NIXBqToCdw6s/ap/uWnCzsEZoU1Y8=; b=OwKRv8HisOO30znJi1Ho+hUgpPBSrWXlq/GXt0H2/zP/qdLpm9EyXsDw2a61AQShgIPbbSV3+Ej3S52+rjh6IZdO+984UlZfSQutm0ebVaojZPdEvPbnXsii6kG8PuAirpHfLHXtKp7cczY772vfbYrNDRjQbFlRg/cuNAda02FjJe+nwrShqr+AJi7iNaDs5zK0cts9O6kB2P+byp7AAqBLPE3iByBx1kCknozbqB9T5nRfMS6AikzPqPDIyb8lFD2OP3LUytyYVKr5cr7UAQdt3wdSVoPsffwsEV6q2Exjm12mhUHhuCV2FKUNaGVT7VP54hFFuVZBoJyTMah4Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2S3sP9AlfqRt+7NIXBqToCdw6s/ap/uWnCzsEZoU1Y8=; b=bYqi+jdurvAlnASwPeqsjBeQbEyaEtHRT+tfj2ZMXCLOX0skGPWPA1XvAM9/jfu+UjDuKFKNuGWP0adgNjsA4OjJFxWsgwGdWrEbNrott3JHnzHPdreVlsAyX0M2DUXG6K+iPVS/yUooPD9UWZvZaRjIsmgPDhZJ2j5FSl7jMWqeeGODilMOOmbRbQ4pWgb2G/GryaRwElDFQ2zQAYg7gwPASJYUdIhZiIrTaKt1FrZWNBEGUxA223A4fZWQeKMQoY8OcH7rYE9sH1gg2OZjtq3WgoeqbrC/R0mEOAue2E5v+GweiD931NBKJg5gBntAqhpWqWwziGr8bPJkuQFAog== Received: from MN2PR18MB3328.namprd18.prod.outlook.com (2603:10b6:208:165::16) by BN8PR18MB2546.namprd18.prod.outlook.com (2603:10b6:408:97::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 28 Apr 2022 11:23:30 +0000 Received: from MN2PR18MB3328.namprd18.prod.outlook.com ([fe80::46e:9af4:d749:f44]) by MN2PR18MB3328.namprd18.prod.outlook.com ([fe80::46e:9af4:d749:f44%5]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022 11:23:30 +0000 Message-ID: Date: Thu, 28 Apr 2022 07:23:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 From: Felix LeClair To: ffmpeg-devel@ffmpeg.org Content-Language: en-US X-TMN: [HjDhcne9YdZg4wnd5W3xZj/jv+sptmV4] X-ClientProxiedBy: YT3PR01CA0100.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:85::33) To MN2PR18MB3328.namprd18.prod.outlook.com (2603:10b6:208:165::16) X-Microsoft-Original-Message-ID: <5fcf3fe9-3245-82fa-1811-88d67072010d@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87baf54d-7da9-4171-25b7-08da2909859e X-MS-TrafficTypeDiagnostic: BN8PR18MB2546:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3BCJc6++QFK3isg97o3lKTWy4W4NBzd7FmuBp98am9kGhXUc6eMLev9wabmaevPL/Ec3RwaTgD5xXqaY5lcFQsAOYAZ8nCC7pURUXvGKIlgwISA8PWZOFRCam83NAxwTQmOi+jGkxrrkskWQzFWrVikVjJwxRwUbd9tQPb/Q+MUdTVjZ2J9eEUqJziYgEmY/78hXcfE0jfPT0kTIt+/1GWc/QNUQvT9z5cqHRIUkUC0WVstou4563B3t2RUCfxRVLQku0c9Zi1GIj2dHkUH+o+NwvGS3fBwwpRkNpveSEPmLjl8kOT/tcI6JrMhtPa+AxLjBm+415pC3sbXiZicYwUbcLjD6c6WOv3rADYaxuho3oF9NikY++eFqIgIcE3H3Tr1dTH2CeLRQREyEwdwaAVMLqhzwBwITbLzlWjbaa1+r1tCQNjOObWClNCuiU0Qy0qneygkQ6ZfQnGeLe/Vg01oEcpx1pVrQDtNNpEm1p74b7XyK0rVVCNoDHjb0K1QXrw7Iw5d23FnTxrGAOSX8CnWT9D5N4zIwr2zxeQuk0YJcdcwWTeWgBUmB2yR9lzPTx8ZbApYi8MnkhBZlEKeGEw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVVwNVJHZnJzb3FvY0V6bkZMRmpIVjQ3bk9XNm01WVg1VHd0M1RJS3YweXVD?= =?utf-8?B?OFdNZVRhOEduYjZUdDhGeEswN2JIOXFGWmErSWp0UUpKNkdUTG5Xc21zeEdl?= =?utf-8?B?WldMZDFDRUhQZmwwU2FGZFQ3RXdENWpBdXBBVTNRejVyWkZHd0RtaHJIMmV5?= =?utf-8?B?SktKakxDbWtiVnZKeVl4dmFjUGhiSzFFZmwzWXQzekhUdVhSeHhHOEltQll2?= =?utf-8?B?NTByVU9hK2dLUVRYMi9TbkhkdjRGZS9wWDJ1Z0ZNakc3RTFERU9Rb01CbWhB?= =?utf-8?B?b05zb1E4cGMvZkw0Z3pFZ1RYMHhUMzN0Y2pYUFZtY1pIVUhqOUpESTk1MGZo?= =?utf-8?B?a3M0cGpPbnlibnJqMHMwTHJKNDhSZWRXVkVOcHNYVll2TnIycVZNeXBpOEJw?= =?utf-8?B?T0RLTHZ3cm02Q3Iyb012Smh1UklPSzlyQmdGMmoydEdKQytnUnpZTVdMMTh2?= =?utf-8?B?T1RqUjlFb3F0aUd6UW94YmpwTjU4c290bUZNdS9vdDgxVVIwb3BVWEwwTHZN?= =?utf-8?B?YzEyWVBFOW1ST2dwdUVaWkIrenV1RVU1ZGl0V1h0dFdkVVMwcVlUcTFKY2xh?= =?utf-8?B?Z2plS2l2NlNiS0RQWEdwL3hLNXpPdEFVNTMzQlNNYnREZHNMVmQxL3UzSVFJ?= =?utf-8?B?R2ZmM213V1lUMVhBTnBHTnN2R04vNmxoSXYwSzluRGlnbHJxMDVSeG9qMmxk?= =?utf-8?B?aVFqY25rS2pma0NxMXpYV0tIcUx5OHJURERidlZPdytXNEZtdGFOYUlXOUla?= =?utf-8?B?azE3QjBRdEczYWNqWEhyRy9NWmhrbkxKSkdyODVpZVM4M1BKMUtVR2kwd1p1?= =?utf-8?B?emVuRVYyOWNkVEhMajNSUERWaUpxWlhaLzh3RVIyU2FId0NzVE5lb1ZoektZ?= =?utf-8?B?U0xuNXYxVEtMR1JmYnlaS003S2xSc0xZMjI0QWxycXdneXY5d0hYK1lTdFY0?= =?utf-8?B?MWtoNVlmeitHb3FuR0Y4VjZwMEVvL3ZYYnNnTy9KSGFNM3BDYjkxRlVUaWNx?= =?utf-8?B?ZjF1dEtMSk5ObkRnQlo2dkFRWkt4M21hb1hUU2F3KzhwL3FQaERtRFd1V3R6?= =?utf-8?B?Rm8yMk56NWN5RHJYVUZYd3QxM3hTV1lBRlFzcWYzRHE4eTFKTkZwdTdwaUwy?= =?utf-8?B?Z1ZETVk4QU94amVUajBSY1doejBjNmNyM3k3czdaTHdLRnlkcWxoZEp4anpS?= =?utf-8?B?QWp5R2ZrUkFZNGN6dWhJSC9idTR0V2tuUDhZM2F5RlpxS3hVYThmRFRMWlVn?= =?utf-8?B?L0ZxNnk2bkI4MU9XWHZvZ2xNbkRGb0k4b2pGS2VtV3VJN0tQZndXZnE1czVC?= =?utf-8?B?d0VpVUJ2QjA0TlRUeVlsQTZJN0hRVU1rNE41bUllLzNTUGJiL2RiZ3J4VzY2?= =?utf-8?B?OVZObitxUzJheTNZdGNiSHdnem14d2dRVTd6bTB3ODFMT0dMVXNyQlB5VlMr?= =?utf-8?B?K0t2b1FhR0k4anNaZzdiWkwyampMdktoR3ZPOC9pK1Jlai96QVk2UVlhRGRZ?= =?utf-8?B?TXY5SUpSY3FQbkEzVU1iY2dDQVNwL0JOWUhrM2pFVzNSVkVUQ0ZVMmMraDlS?= =?utf-8?B?aUUvS2hXL2g3T2VRekpUOWlsRGhWMzJwaVhCRURBUmtOSW5OQUJyeDRsRGpx?= =?utf-8?B?bUNXQXV0RGFiREp6am1hd2g2bStaTXhQdnhUTXcxaHVJTk9DTkMzVU9MWkpL?= =?utf-8?B?WkRJRFh2c3FDZHlxZ2xjUk9PWEdGWWR2Yy92YXJjV21MUzBIWXByNHZKSDNk?= =?utf-8?B?cWlZWGhLalVGTXhYYW5LYzdVTTBLeGRhc1R0Z0RPb3VlTVBNOVBDQ29JUWpi?= =?utf-8?B?U3Q1OWYvMEJ3c0tON2hzMC9peVVFYVRVMTQvNXdkQTdGWUE3Y2dYdUNlWi9v?= =?utf-8?B?L1pRTWNQK2Rid1pncmdKalhsN1R0U3d3YjZIdFlDdllSbzE0MHB2SkFiS3JG?= =?utf-8?Q?zj+I2u37wyWyIW3hVofISQEJqnEK83FL?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-db494.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 87baf54d-7da9-4171-25b7-08da2909859e X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB3328.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 11:23:30.4993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2546 Subject: [FFmpeg-devel] [PATCH] Fix AVX-512-VNNI__hevc_qpel_filters_avx512icl_v_%1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Issue: On extremely new hardware using either IceLake or super sets of Intel IceLakes avx512 instructions, commit d4cd8830bdac3e26c8e75cd92e574c159fecc4f7 causes build issues. Specifically a NASM macro expansion of qpel_filter_v is never properly defined/initialized. The issue is the definition was erroneously placed inside a conditional which will not trigger unless the original definition failed (has to do with if PIC is defined, becomes a bit of a catch 22) Specifically the error is ``` X86ASM libavcodec/x86/hevc_mc.o libavcodec/x86/hevc_mc.asm:1854: error: symbol `..@88472.table' not defined libavcodec/x86/hevc_mc.asm:1806: ... from macro `HEVC_PUT_HEVC_QPEL_HV_AVX512ICL' defined here libavcodec/x86/hevc_mc.asm:1730: ... from macro `QPEL_FILTER_V' defined here ... repeats a few times... ... make: *** [ffbuild/common.mak:100: libavcodec/x86/hevc_mc.o] Error 1 ``` Specific error was discussed by kurosu and myself (fclc) on the ffmpeg-devel irc. This commit fixes the above by swapping lines 1796 and 1795, moving the define out of the conditional Side note: It seems fate didn't pick up on this, may merit looking into (as mentioned by nevcairiel). Signed-off-by: Felix LeClair (FCLC) Signed-off-by: FelixCLC (FCLC) --- libavcodec/x86/hevc_mc.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index c07948dd9b..e159adccc7 100644 --- a/libavcodec/x86/hevc_mc.asm +++ b/libavcodec/x86/hevc_mc.asm @@ -1792,8 +1792,8 @@ cglobal hevc_put_hevc_qpel_hv%1_%2, 6, 7, 27, dst, src, srcstride, height, mx, m sub srcq, tmpq sub myq, 1 shl myq, 5 -%ifdef PIC %define %%table hevc_qpel_filters_avx512icl_v_%1 +%ifdef PIC lea tmpq, [%%table] %define FILTER tmpq %else -- 2.32.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".