From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81326421AB for ; Thu, 28 Apr 2022 17:17:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D376E68B408; Thu, 28 Apr 2022 20:17:34 +0300 (EEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08olkn2035.outbound.protection.outlook.com [40.92.46.35]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78D526800D1 for ; Thu, 28 Apr 2022 20:17:28 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JTn8/ZwaXtmOhvQD0aNOGxQyBtJqmkmAQjBXZLWp8Oxrvxu+wAa96Vvbsd+SMj3ODPRQ7wPwGLNba1uRZbV5FQqN+e7rjtxAShmh44B8wGHhuE3FSgw1Fp9TqO3UlD/U7j2SBi3hbMuWHGzFruXaX/NQb2fQculYyZSyriU5E8gvE3S10aQWGLlpM/Fgj3PyuMd0LTg1iUO+/SL3Tk+KqfpTmcO7HiJLU1nQ9WuMjnFVJYrR40Gaohj7PX+/KrmmixQHYezDNSqIocrgjc618mCCUdgFl40I4cp8SMaC8DUHYID5TAwAsyDr/NNZmoEc6TagP7dts330n85re53+mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E7DSHuVEsfW5BfOzWt/nO4rVHu7nBF7xGOe7MnKT5+I=; b=AAERMIpLKVhbcQCthXAym4LW6rW5/WHJ6z0JRUnFdQdULlQ2I9RWUqQpdz5zftuvt+XBorl+4GvFHHduAO7zSIHn4L8MrHal5jRHiyZEXVnI7fGXxe37nR2ttFIKNH5T27EPqgrctx7yJL18BZT6Aq9tmLR8VI/scsj7BAo3atQK/xw+mbpy8c9MCX8Wh7ATdUyVwxQ8sxg29mspQL+iuxSWx0w9QODUn1f/DxJrKzc/swoc1cyFyj4Zy2GOVbS4O4n8bJcwgoCNbE6guErpyIEyfZP3dOjtQdda2N5mfshyFK24qtyP101bsbjNS4ydekWgMqbB/iuQiy2kJV1+Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E7DSHuVEsfW5BfOzWt/nO4rVHu7nBF7xGOe7MnKT5+I=; b=QiakaJ6SmIwfoRV9m3qKRIoBs18TxIyKLLVg53VQmOvFE3lg2EHHY+Jobi73lRh55LYeFMWbqphQDwgu9lGToYqmFmwNb8/n1DQSQ767TiWxLWP/R8YrQAEkB58GdCaxUMO92VfT990urDjPAIJ1l+eFBqqd02G1LqWw+FjgY+f1ZR5w+6F4s19Gjc+D64Qw3DFxbj6Ydv2tiruO1O+QVN03z87Pt31A7MonUkwax5frKgZgqoXbLnNMZm8vgPD78WVYHRI/kE8KlSYjTMt72reDy5gXMGYwPGIV9L6gbBPViu5ghkrjnvpNH8P2IKzQRqEF7lS0XF+mQ57gBpbgRA== Received: from MN2PR18MB3328.namprd18.prod.outlook.com (2603:10b6:208:165::16) by DM6PR18MB3619.namprd18.prod.outlook.com (2603:10b6:5:2af::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Thu, 28 Apr 2022 17:17:25 +0000 Received: from MN2PR18MB3328.namprd18.prod.outlook.com ([fe80::46e:9af4:d749:f44]) by MN2PR18MB3328.namprd18.prod.outlook.com ([fe80::46e:9af4:d749:f44%5]) with mapi id 15.20.5206.013; Thu, 28 Apr 2022 17:17:24 +0000 Message-ID: Date: Thu, 28 Apr 2022 13:17:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Felix LeClair To: ffmpeg-devel@ffmpeg.org Content-Language: en-US X-TMN: [TheXgCn6moUJC2Nht+FWBZbywK6VxrOh] X-ClientProxiedBy: MN2PR15CA0050.namprd15.prod.outlook.com (2603:10b6:208:237::19) To MN2PR18MB3328.namprd18.prod.outlook.com (2603:10b6:208:165::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dfbf1a70-396c-428a-9cf4-08da293af58f X-MS-TrafficTypeDiagnostic: DM6PR18MB3619:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8lGD4ph9oYaSf17L10TlsCPg56EDqLLr30nMico/HEGpa2XK3DuYBpS6VoLxruR+epWtCuEdQv5xfoLaO9UBTBRmAbuFhvgvNaIMlgTsDPCseuzBasaTKkiyG3EXYSEdYmrkga/tWpLg9l48h2evxDPP6ca28eAol8t6gQT4odGJAwltXr/aYEQ9MzVJ4y+XoNqFMsg6nr4cdHAdGS9gtjZzNnhhTvZFr3b2dKXpFVFEy/R0vLgwccgNCsw5u8YUsBpi22cFGQDyTHZzMy5g3z8eX5ikROUNICKMwni6QcChAwtjsNpXm00XN3cDTtnsPD6iH0pCCjRc1BjeERDVaPBOat9TqEKqDll28oGeFRvfTW5yLD1HU3xlQQ1ikiuFLY/s/h6LauCrGegZ2fEOzOpAWZkb68nuWb5siqFC7LW61aqhZt5V1ZnNVNAboctVPw2ioo6fEXbadxoVWbZgLf66coPTEo0FKFCrVZuIQxtyU9sNxp0W3qm5LaY3zLM9NEeRyT0MrYiIQKY4m2r1DoR19cUicUUz686xuOwwUcNY9DBOiGzk9VhuvPkVd4jHZUUGTxHuhuoqFYzY3HzmnQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFhuT3ZrWDdBTUg1a0RJV2VHc1RXTGdMQ1JQR003ZmlNazRiTkhqSThzZW10?= =?utf-8?B?TEpGSWZEL1JiZWpDQTZNcG05aktJOEtnWGl1M1BkcmxvOWZxbnU2bUQwbUpN?= =?utf-8?B?NklrYWs3c3dZMUZ3bkJXc2gxOTV1VDcra3ZmNTBFcnA0d3pETHVKRis1T01V?= =?utf-8?B?UWtBalF5MDNkZnkyMExuekdGb1pjNmdjV2JLQVdUb3VCcTRsdTd1clNPNHQ5?= =?utf-8?B?TG5JTjlHanp0ZXMwVE1ablJzNEVwT0syb3B0eWgvVXY0OU53QTBldk5ZYk43?= =?utf-8?B?MGxpRDJsOUhNT1BDUHBEaHc3MStDeEw3QVZmUHgyNGNTRjVLb2ZDYlJWVmJC?= =?utf-8?B?WHNaV2trOWt3QlNUcXJXb1lmcHdXNExTQ1Z0THdjUEd4eE5IekVOL3VHSFF1?= =?utf-8?B?RkpSY2gzR0NEdFhadmZhQ3Iwa0FUbXBIb0ZLa2tNaDZRZkkvaFgrZ2l3YVhZ?= =?utf-8?B?M1d6eHV6eU5SazBRRW9RQWFTN1BFZU9zY3FLaS9kTWs5bkFhUHpkSUhiVkQw?= =?utf-8?B?TDFRTVNOMko3eEluZHFJc1Z0ODI3eXA2cEEzY1JMejBsUzJSUHRRWENXR0M1?= =?utf-8?B?RmJadDh5ODhZMXFYc2FlVkp3bS9CMWxlb1p1dklMTXl0TWV3UDlrc3VlbTNZ?= =?utf-8?B?WG4vME5OUC9DQ1lNREp6K2hNeGNvNlNtZXBEb216eWhkTWxkMFJPaWMrSm9z?= =?utf-8?B?WDlUNVJkK1hkcTgxL1ZvbmM1ZlRqTi9vN2xIODQ3YWY5RmM1UWNGYkJFbWRo?= =?utf-8?B?akNRRXhDbkdETjJ2Q2M3K01BTzdrT0RRYm95eWhWY3ZEam5JRERkL0lNQkdG?= =?utf-8?B?LzlvVVFSZHlWeXNSTGF0L3h6VEU4TExjV3kzazNTYUgwQ2lPN1gxNVhwY05v?= =?utf-8?B?OHN1QmZwWTBib0J1bFVrOWgwQ0oyZ1BUYzltMFhmNXV3MEUvSVFmdGl0ZW9a?= =?utf-8?B?U0FDRzFhT1AzdnBlRG5OLzNvS2UvM1A0QmhUL3BkR2NjREtDQXV0U2Q2bHVE?= =?utf-8?B?U3hzK3hnVVNoZTJsTG93MTNlR3lESGdXSWlTVU5HL3o4NC9ETDFzcmRyMmh0?= =?utf-8?B?SjAxc0g4bVNReWl1OGM5eW5WU1YvMmtrWVhPRUJwWUNVM3dNZ2NkVzVFcnRu?= =?utf-8?B?bUl5Y3cvc21zSXJ2T3pPMUlZR211TVE2aGtCYWNyUVhtZ3Z6V2JKL3pHUzAr?= =?utf-8?B?MDR5blRwbHhHcm96ck0zWmNHcEZmRVpRZmw3V2ZMRFJKWTdvUVBRKzFoL21P?= =?utf-8?B?bDc3b0ZWQXl3Qkc0Z0lFMG5uRmkzb1F1TEtGcFZzS1lPU2JmL0hPOCt5UHlO?= =?utf-8?B?MmlqS29JU1Arb1VJRGVUbDZxNlZ4YWtCaWc0ajZEeGJVclBZMElEeEZaTVo5?= =?utf-8?B?SlM0dXk1eHNkQndjVndrcHA0MmlEOVdXWGhWa2I0Yk1FdkFLVzBxckxJSWlL?= =?utf-8?B?M0JITDZpaE9tdEJXM1poUWUxRGpBdEkyYWVEU2Yra1BQZDA0WStTUmtoTFpV?= =?utf-8?B?WUxKR3Rmd3hNUHdONDZiR1NzdXZWUUREdzMzajI2aWJRUkl1b0o3dTJWK1Bo?= =?utf-8?B?aWxBNnUvZXpZQTU2aUFFbS9LVHR0Wk9WSGdxd2FLUnZoaDVLZTdKYkxQVWhl?= =?utf-8?B?dUxzeEpjdSsyVTN6UWg1N3pSWVRteDlaSmYwaExsL0UxY0IyUnNpbk9zcDl5?= =?utf-8?B?K2ZDVG9xVXJCV1QwVEs1Ny92SERTTVJnZHN1YlI5M2tjMUFyQmszRDVkdUxs?= =?utf-8?B?QTYrVXRMa21hZmN0ZTV0SXRwZGc2UGg2WkpwOFcwWU53VVZCVGRtVXd3NHgx?= =?utf-8?B?b3krRUFlUTFSK08ydVpFUlZiRTdpaFBtWTlUSytCV0s5L0lhcWRQUGhwZ3ZW?= =?utf-8?B?MUtDVDdvNHB0MDNZOVJPK0JuZlg5S0hzWEg4SzRpSVZtZFRJQ3ozNDRocnl1?= =?utf-8?Q?+U4r3sVrc4P0G8vMM57JgvasCsEgKIzJ?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-db494.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: dfbf1a70-396c-428a-9cf4-08da293af58f X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB3328.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2022 17:17:24.9142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3619 Subject: [FFmpeg-devel] [PATCH] Fix AVX-512-VNNI_hevc_qpel_filters_avx512icl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Issue: On extremely new hardware using either IceLake or super sets of Intel IceLakes avx512 instructions, commit d4cd8830bdac3e26c8e75cd92e574c159fecc4f7 causes build issues. Specifically a NASM macro expansion of qpel_filter_v is never properly defined/initialized. The issue is the definition was erroneously placed inside a conditional which will not trigger unless the original definition failed (has to do with if PIC is defined, becomes a bit of a catch 22) Specifically the error is X86ASM libavcodec/x86/hevc_mc.o libavcodec/x86/hevc_mc.asm:1854: error: symbol `..@88472.table' not defined libavcodec/x86/hevc_mc.asm:1806: ... from macro `HEVC_PUT_HEVC_QPEL_HV_AVX512ICL' defined here libavcodec/x86/hevc_mc.asm:1730: ... from macro `QPEL_FILTER_V' defined here ... repeats a few times... ... make: *** [ffbuild/common.mak:100: libavcodec/x86/hevc_mc.o] Error 1 ``` Specific error was discussed by kurosu and myself (fclc) on the ffmpeg-devel irc. This commit fixes the above by swapping lines 1796 and 1795, moving the define out of the conditional Side note: It seems fate didn't pick up on this, may merit looking into (as mentioned by nevcairiel). Signed-off-by: Felix LeClair (FCLC) --- libavcodec/x86/hevc_mc.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index c07948dd9b..e159adccc7 100644 --- a/libavcodec/x86/hevc_mc.asm +++ b/libavcodec/x86/hevc_mc.asm @@ -1792,8 +1792,8 @@ cglobal hevc_put_hevc_qpel_hv%1_%2, 6, 7, 27, dst, src, srcstride, height, mx, m sub srcq, tmpq sub myq, 1 shl myq, 5 -%ifdef PIC %define %%table hevc_qpel_filters_avx512icl_v_%1 +%ifdef PIC lea tmpq, [%%table] %define FILTER tmpq %else -- 2.32.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".