From: Felix LeClair <felix.leclair123@hotmail.com>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] libavfilter/x86/vf_convolution.asm- fix missing decelerator for AVX512ICL sobel
Date: Fri, 24 Feb 2023 03:00:13 +0000
Message-ID: <MN0PR12MB6053315D52BDB52D9372A989D3A89@MN0PR12MB6053.namprd12.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
Fixes: Compilation of Sobel with AVX512ICL
Caused: Comment left without deleniator in AVX512ICL version of SOBEL
Testing:Confirmed working on AVX512 Alderlake (AKA SPR without AMX)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-libavfilter-x86-vf_convolution.asm.patch --]
[-- Type: text/x-patch; name="0001-libavfilter-x86-vf_convolution.asm.patch", Size: 1213 bytes --]
From 2b12db24d2bbe8a1544a9a7f3a08e1a693a6c2ce Mon Sep 17 00:00:00 2001
From: "Felix LeClair (FCLC)" <felix.leclair123@hotmail.com>
Date: Thu, 23 Feb 2023 21:36:32 -0500
Subject: [PATCH] libavfilter/x86/vf_convolution.asm
Fixes: Compilation of Sobel with AVX512ICL
Caused: Comment left without deleniator in AVX512ICL version of SOBEL
Testing:Confirmed working on AVX512 Alderlake (AKA SPR without AMX)
Signed-off-by: Felix LeClair (FCLC) <felix.leclair123@hotmail.com>
---
libavfilter/x86/vf_convolution.asm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm
index 9ac9ef5d73..8b85897819 100644
--- a/libavfilter/x86/vf_convolution.asm
+++ b/libavfilter/x86/vf_convolution.asm
@@ -232,8 +232,8 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2,
psubd m4, m5
vpermb m3, m6, m3
mova m5, m4
- vpdpbusd m4, m2, [sobel_mulA] {1to16}
- vpdpbusd m5, m3, [sobel_mulB] {1to16}
+ vpdpbusd m4, m2, [sobel_mulA]; {1to16}
+ vpdpbusd m5, m3, [sobel_mulB]; {1to16}
cvtdq2ps m4, m4
mulps m4, m4
--
2.34.1
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-02-24 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 3:00 Felix LeClair [this message]
2023-02-24 13:09 ` Kieran Kunhya
2023-02-24 13:51 ` James Darnley
2023-02-24 13:51 ` James Darnley
2023-02-24 15:12 ` Felix LeClair
2023-02-24 15:45 ` Felix LeClair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB6053315D52BDB52D9372A989D3A89@MN0PR12MB6053.namprd12.prod.outlook.com \
--to=felix.leclair123@hotmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git