From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7FFF640929 for ; Thu, 11 Jan 2024 03:00:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F084C68CF61; Thu, 11 Jan 2024 05:00:03 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 89A0068C900 for ; Thu, 11 Jan 2024 04:59:57 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704942002; x=1736478002; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=mZXXXCckAk1IpKs+SsiIMKl18nSfzywEQg5AXFghZLE=; b=lWh+NHmSCheIt/s1LSEHuMXyHdBHFbSTXxSOG8bnXxk8B0tE5DlWSSDI kg2/CQngTSl7cVSw/SSM2UalkiExii6KqNbnYjCoC8U95iBetPt/e0tqd OPrEg35cNeUif3/bowPWxUQY+77MdF+MwUgCDh1PMPSyk3tSjIgkfRe2H vzXf+GnRrU3a0MGBeeETHrxXXWPMfdWCyu4bR0nu4FFYZeCZGKwSRNPSx LgKK78sHDKB+N7nkervkXVgtR/3J5mbiJvXt36y7rM8AV7wyV202Ixrkc BDOfCSuzzg+RwYIsLaRvqB330UXycDXp9IRJvdB5zFxE9wWD9guwCLo4G w==; X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="429906726" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="429906726" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 18:59:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="816563797" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="816563797" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Jan 2024 18:59:54 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 18:59:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Jan 2024 18:59:53 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Jan 2024 18:59:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8wZxz/Jl1mWNrax2VwA8PgXXV9LGAQL2oHnKoWr041cIaHOMApAqr8zazgTO4N3J+wk4PbY1vPzliEpazPZgG+8+5fmUMtLSTIOR98cAarGVCJCq5w40LQwtfHjrziuUmtNGdMQujl5GxNfkj9yci4P5kNxviw8VuBPu2E2CNgzGehvDDzzDc6WQstZ56JLm/jr4EiClp8QNH+/8HiZHk0Iae0x3aUkdplQ3ZujqNw7Jq208x7KFu4OYxqkkLb49EVzOBXBcO/QYK2WvlTnWQ8wSMMHNGpY9GfaD9qI6dLTZwQ8LLSoE8Abds671qD0UzDBVk4/XN5H4FQgWxWRBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CvfvbNvtCtyKM/zzpD1jQAz9OyJ+2kr/qlk2Iniqx28=; b=i3jSEpSeBjiF9yhczRl61K+XxAc/WDoP5B0LrjrogQ+IWIN4Jv8mH/Kj/fAePpv+x4eNJrmtevnaYvtQ60Wr7SiEI/aH/LRJSkimOShXYUhNDxCsZb5WEri13nuMscZqV/8IZVCaRU1gr7JcQAUz7ce7c7BZdk3q53YIH49zOgSFCuCzKpyUT1KkHryQqfb8ND+BvZ79J6nWtEoQ2gXYYYnhqXH2KD94kKAiPNXo8i2n9mFWUBGrK/A4MxJmDN1mQVL3EAZx3F9RyoOon9QI2ysRxXcz0y4HytOL+CngF3aYF4J9M0vEk+QxlixFv4F7DKmiurtWxKy9AmXEniCi6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6396.namprd11.prod.outlook.com (2603:10b6:208:3ab::10) by CH0PR11MB5489.namprd11.prod.outlook.com (2603:10b6:610:d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Thu, 11 Jan 2024 02:59:50 +0000 Received: from IA1PR11MB6396.namprd11.prod.outlook.com ([fe80::a248:6b05:70aa:3e61]) by IA1PR11MB6396.namprd11.prod.outlook.com ([fe80::a248:6b05:70aa:3e61%6]) with mapi id 15.20.7181.015; Thu, 11 Jan 2024 02:59:50 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float Thread-Index: AQHaFka5vsNNxQls+E+a0PE2OTs4VLB5F0fAgBRonZCAReHFAIAA5JVg Date: Thu, 11 Jan 2024 02:59:50 +0000 Message-ID: References: <20231113153234.8812-1-ffmpeg@haasn.xyz> <20240110141540.GB92986@haasn.xyz> In-Reply-To: <20240110141540.GB92986@haasn.xyz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6396:EE_|CH0PR11MB5489:EE_ x-ms-office365-filtering-correlation-id: 12e34851-e5a9-4d49-ff13-08dc125160b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IkYKy8nqnlO+OXP2RuyEumgWYIusg2Luxkci1dNgbJ678gfXmwvlc6CnPjW4QMg8t7IYfhJK2kE/Oq0MdioMBvZ9LLx9SDeT9kR4Hv40YoMcdJLw4O099NJ1FLq7qHx70r6yTWfIIO+o2xmbBnfThRx+f0WOEelLBsrSJv4AFCEH7Crf1MidfTNDsBScbwWa13Nrh7yp4igOCuy1FIMcD7+9/tBt7lBatTtzVgFMDi7Q4lGf6O16nvPP4o1mKb+bvab60kxzJbDxILJfDC8ob7i6etVnD/4vLOKe+g9nhJ73eO47mGOHLxHTzq4OTZmdcemDKK8EZ8QSwLfNxULt2KYPmRS7NzhC3sIgO3aLifsaWG2sNXAWY+rAVxd5TIKD3egsomsKWgJHh68E8EdzfrAkFJ5Zv1mTbvhHS3WRNeBIffVp3ProA814AE7tQCj7G1xAftVO99uM2PIMeNzodJWGvtwUmhfPka4SqLOv3uCk5KAM3LDOg5+hbfGcaRLu7j0k7QCsMXOMkUejxUWR6cWCg3M5XD+pKPMbg7S8bhoJwvZumnDvdMZegxml+Ztme0jNCJGemx0hY7/y6anAqjff4SyB8mSBOTzWIhusDLU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB6396.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(346002)(136003)(366004)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(83380400001)(33656002)(26005)(71200400001)(478600001)(7696005)(6506007)(9686003)(966005)(82960400001)(8936002)(8676002)(38100700002)(66946007)(76116006)(66476007)(66446008)(66556008)(64756008)(316002)(6916009)(52536014)(86362001)(122000001)(55016003)(5660300002)(2906002)(66899024)(41300700001)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KhQXv/Ld2lCoLLxSi56v6mfuLyslYmAGUhgccQQYP0r5cAttlXDaLHj9rkEb?= =?us-ascii?Q?sHLmAHKDFN0wspXiMtvPi3dMFA93l+CEFVcRBn5re4XHqwP2MfAHWBoSe5Pz?= =?us-ascii?Q?NS5Xd4zAFVp9cBiuTA1XeMEL7pXHDJKWEYCCF2Cwr5PtyCD6OGOplLpsd7u4?= =?us-ascii?Q?1TER5s6ZSxg7EWobtwXeryHFliB7dqo3fPmb4XNWlwgTqJNu0IQLrXcbSzAV?= =?us-ascii?Q?dQSgJhNhK1+NnPLxt7QIlxtCqOOHCAL9Pmm6gplH50Ckh/efbm34u8GwXOfU?= =?us-ascii?Q?RaHvYDFJImK9ojcsrEPONnbGgnIDvc38F0cbSCAMNXjkfFhPzeefkid9vXo6?= =?us-ascii?Q?d/ZJJorfrwJOYAw9XBAlWd7bd+8ir+j1HRLnpAI/C7WkeT50YLmFLP7ofe6Z?= =?us-ascii?Q?bSk2zjCiKfB8EAu3HieYJCbVJEIg7U5L2/a+AhA/E7k9V3KPWDCTUbQzOMWy?= =?us-ascii?Q?5bwW5+LWdlLJpdZkey+ybM561qYhHQMpwP8LrucB4bJhjd8g/sHc65Dc7AYy?= =?us-ascii?Q?hOnPcqLNWuzaKtaSIcIEfncWJcbSpvi+eINmDtgjq7jtXxEfwoqkXxKv/2ya?= =?us-ascii?Q?mkJiPzXAw0NqjefgIjzXs10sUMl+GulbkfEjYcEKAHYNVZA4yuyhm2A44nAO?= =?us-ascii?Q?SBrkuQbnjNej8b4zt1Ssl3RShE4Jm0GzEcvnEudbhvkYNZruK+knj0y6Ujfs?= =?us-ascii?Q?Qfj7uERO+i5AyL2RI4DWLOpi82h3CU1HsYz/QuDuO9+3A7G+/EupXeJ3Fhz+?= =?us-ascii?Q?AnxaPOcJ3CuriZz0M7kIp2GZPPaDFnc9jd9Co5trrIelZz+5qWjEbZvjZoDC?= =?us-ascii?Q?6Awil46cSgrv+m23+/xieecnkgkV32xHmzv3wSWEDHDRPogGiB1b52iYYj7Q?= =?us-ascii?Q?tkEXBDEBvQrS8O1pLB+RZPeJW2iPWtSsRzzYFNPoenj264AUWS0dF8j7oPNm?= =?us-ascii?Q?oSXjNPDVXmP0tPqnBGkkBU5yRFqJ/z4EnNZLw+aMLh4GOQP0sKyC9pySdp5q?= =?us-ascii?Q?nbYdolh5Re9tL5bOgQmHqV29FU5CC3B/Tk7oHL/HnHeL2egVrT24Ulc4nBnr?= =?us-ascii?Q?R3PdKPDKOjTZGLkBIxgjZQcxgyjTvf2+rqnXTUQuD9ZGz9gf03gBIKZ3UQBs?= =?us-ascii?Q?EyvfmGRmy0hAJ9UhNR9Z4DdSv/fYAqsozpLGSpwwUtOcwMK2jT5rF+vXQ+IA?= =?us-ascii?Q?y/IB3JqurCMzfURivsNbYoRZF/qBlpRVeTe+enpkyx1yY0KqWmxyVWKYzp22?= =?us-ascii?Q?o65BNIl/5nCm8jXAt/JrcgMHwAx27encSYAvTo51VFfBBnZ4OBsHeF6Sx030?= =?us-ascii?Q?NXNihsAIzXVPRTb5WNDViSp2/3LymZljVInghSBl4RZumyOljfm6oHX7s5wx?= =?us-ascii?Q?s5G+qzl+KbhADOaCPN1yX07CEpWkGVWc6HLj+W5AhNHZW+Aofs1UeolZDvS9?= =?us-ascii?Q?t2cuDZT3cSrDL93Xz8mkSuK3b97ew/xqdpCEM5uZ8Uq1Dpi/l1jnNPu597jN?= =?us-ascii?Q?2eW1r6R5bjABN60P9ZLGZsghBbQkBr4us5ZJByQl/Bt8OaT17ZmTMPhZk2hy?= =?us-ascii?Q?Zm714bf7WXlkHSBXEhioiJ1H9NKwRYSb46pWfho+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6396.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12e34851-e5a9-4d49-ff13-08dc125160b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2024 02:59:50.3920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qJFZ2c5DV6ngwDDgvXekLYEKEeAxTU5oaHCjTWP1DdtgKuFMKESI236m0DyAEbW2f7FF6DwmylC4qPoo+/qOCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5489 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Mon, 27 Nov 2023 02:10:11 +0000 "Chen, Wenbin" intel.com@ffmpeg.org> wrote: > > > > From: Niklas Haas > > > > > > > > This logic was incongruent with logic used elsewhere, where floating > > > > point formats are explicitly exempted from range conversion. Fixes an > > > > issue where floating point formats were not going through special > > > > unscaled converters even when it was otherwise possible. > > > > --- > > > > libswscale/swscale.c | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/libswscale/swscale.c b/libswscale/swscale.c > > > > index 46ba68fe6a..a66db22767 100644 > > > > --- a/libswscale/swscale.c > > > > +++ b/libswscale/swscale.c > > > > @@ -534,7 +534,8 @@ av_cold void > ff_sws_init_range_convert(SwsContext > > > > *c) > > > > { > > > > c->lumConvertRange = NULL; > > > > c->chrConvertRange = NULL; > > > > - if (c->srcRange != c->dstRange && !isAnyRGB(c->dstFormat)) { > > > > + if (c->srcRange != c->dstRange && !isAnyRGB(c->dstFormat) && > > > > + !isFloat(c->srcFormat) && !isFloat(c->dstFormat)) { > > > > if (c->dstBpc <= 14) { > > > > if (c->srcRange) { > > > > c->lumConvertRange = lumRangeFromJpeg_c; > > > > -- > > > > 2.42.0 > > > > > > > > > > This patchset works for me. Thanks for your quick fixing. > > > > Ping. When can this patchset be merged? > > Hi, do you still need this patch, now that YUV negotiation means > vf_scale no longer changes the filter range dynamically? The problem is not solved. Command " ffmpeg -i input.png -vf format=grayf32,format=gray8 output.png " still reports error: "Assertion c->srcBpc == 16 failed at libswscale/x86/swscale.c:533" After I add --disable-sse2, the problem is unseen. > > > > > Thanks > > Wenbin > > > > > > > _______________________________________________ > > > > ffmpeg-devel mailing list > > > > ffmpeg-devel@ffmpeg.org > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > > > To unsubscribe, visit link above, or email > > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".