From: "Chen, Wenbin" <wenbin.chen-at-intel.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float Date: Tue, 12 Dec 2023 07:54:58 +0000 Message-ID: <IA1PR11MB6396DBCE1CE219921CBB429FF88EA@IA1PR11MB6396.namprd11.prod.outlook.com> (raw) In-Reply-To: <IA1PR11MB6396A170577FC136166BC0D0F8BDA@IA1PR11MB6396.namprd11.prod.outlook.com> > > > From: Niklas Haas <git@haasn.dev> > > > > > > This logic was incongruent with logic used elsewhere, where floating > > > point formats are explicitly exempted from range conversion. Fixes an > > > issue where floating point formats were not going through special > > > unscaled converters even when it was otherwise possible. > > > --- > > > libswscale/swscale.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/libswscale/swscale.c b/libswscale/swscale.c > > > index 46ba68fe6a..a66db22767 100644 > > > --- a/libswscale/swscale.c > > > +++ b/libswscale/swscale.c > > > @@ -534,7 +534,8 @@ av_cold void > ff_sws_init_range_convert(SwsContext > > > *c) > > > { > > > c->lumConvertRange = NULL; > > > c->chrConvertRange = NULL; > > > - if (c->srcRange != c->dstRange && !isAnyRGB(c->dstFormat)) { > > > + if (c->srcRange != c->dstRange && !isAnyRGB(c->dstFormat) && > > > + !isFloat(c->srcFormat) && !isFloat(c->dstFormat)) { > > > if (c->dstBpc <= 14) { > > > if (c->srcRange) { > > > c->lumConvertRange = lumRangeFromJpeg_c; > > > -- > > > 2.42.0 > > > > > > > This patchset works for me. Thanks for your quick fixing. > > Ping. When can this patchset be merged? > > Thanks > Wenbin Anyone who can help to merge this patchset? Thanks Wenbin > > > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-12 7:55 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-13 15:32 Niklas Haas 2023-11-13 15:32 ` [FFmpeg-devel] [PATCH 2/3] swscale/utils: correctly return from sws_init_single_context Niklas Haas 2023-11-13 18:30 ` Michael Niedermayer 2023-11-14 13:14 ` Niklas Haas 2023-11-14 22:52 ` Michael Niedermayer 2023-11-22 12:45 ` Niklas Haas 2023-11-22 13:16 ` Michael Niedermayer 2023-11-13 15:32 ` [FFmpeg-devel] [PATCH 3/3] swscale/utils: don't early return in yuv alpha blendaway Niklas Haas 2023-11-14 2:27 ` [FFmpeg-devel] [PATCH 1/3] swscale: don't assign range converters for float Chen, Wenbin 2023-11-27 2:10 ` Chen, Wenbin 2023-12-12 7:54 ` Chen, Wenbin [this message] 2024-01-10 13:15 ` Niklas Haas 2024-01-11 2:59 ` Chen, Wenbin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=IA1PR11MB6396DBCE1CE219921CBB429FF88EA@IA1PR11MB6396.namprd11.prod.outlook.com \ --to=wenbin.chen-at-intel.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git