Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Chen, Wenbin" <wenbin.chen-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] libavfilter/dnn: Initialze DNNData variables
Date: Thu, 21 Sep 2023 01:28:24 +0000
Message-ID: <IA1PR11MB6396ACD291EB2A027443736DF8F8A@IA1PR11MB6396.namprd11.prod.outlook.com> (raw)
In-Reply-To: <tencent_C2AB3E0156859D22E0B45AF034B981CC3409@qq.com>

> > On Sep 20, 2023, at 10:26, wenbin.chen-at-intel.com@ffmpeg.org wrote:
> >
> > From: Wenbin Chen <wenbin.chen@intel.com>
> >
> > Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> > ---
> > libavfilter/dnn/dnn_backend_tf.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/dnn/dnn_backend_tf.c
> b/libavfilter/dnn/dnn_backend_tf.c
> > index b521de7fbe..e1e8cef0d2 100644
> > --- a/libavfilter/dnn/dnn_backend_tf.c
> > +++ b/libavfilter/dnn/dnn_backend_tf.c
> > @@ -629,6 +629,7 @@ static int fill_model_input_tf(TFModel *tf_model,
> TFRequestItem *request) {
> >     TFContext *ctx = &tf_model->ctx;
> >     int ret = 0;
> >
> > +    memset(&input, 0, sizeof(input));
> 
> Can be simplified with DNNData input = { 0 };

Thanks for your advice. I update it in patch v2. 

> 
> >     lltask = ff_queue_pop_front(tf_model->lltask_queue);
> >     av_assert0(lltask);
> >     task = lltask->task;
> > @@ -724,7 +725,7 @@ static void infer_completion_callback(void *args) {
> >     TFModel *tf_model = task->model;
> >     TFContext *ctx = &tf_model->ctx;
> >
> > -    outputs = av_malloc_array(task->nb_output, sizeof(*outputs));
> > +    outputs = av_calloc(task->nb_output, sizeof(*outputs));
> >     if (!outputs) {
> >         av_log(ctx, AV_LOG_ERROR, "Failed to allocate memory for
> *outputs\n");
> >         goto err;
> > --
> > 2.34.1
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-09-21  1:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  2:26 [FFmpeg-devel] [PATCH 1/3] libavfilter/dnn: add layout option to openvino backend wenbin.chen-at-intel.com
2023-09-20  2:26 ` [FFmpeg-devel] [PATCH 2/3] libavfilter/dnn: Add scale and mean preprocess " wenbin.chen-at-intel.com
2023-09-20  2:26 ` [FFmpeg-devel] [PATCH 3/3] libavfilter/dnn: Initialze DNNData variables wenbin.chen-at-intel.com
2023-09-20  9:26   ` "zhilizhao(赵志立)"
2023-09-21  1:28     ` Chen, Wenbin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA1PR11MB6396ACD291EB2A027443736DF8F8A@IA1PR11MB6396.namprd11.prod.outlook.com \
    --to=wenbin.chen-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git