From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8C0D64D95C for ; Thu, 27 Feb 2025 02:43:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F31368CFD7; Thu, 27 Feb 2025 04:43:04 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 013B768BF20 for ; Thu, 27 Feb 2025 04:42:57 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740624183; x=1772160183; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ZPITLST//OZT6YNbGaT0BNwZTYydHctDs/HtzZ8WI9A=; b=ddXDO2mUtmueYASXLJKa9gMFBj+o5ibFv1OLxQDHDOUFflH3aKlJNAz8 7q6iGwppdWt9Lslhs21/gtOdOyc49ucZNQycg7Td8e71kcnlxlIPX9D2b LFGQ08GXrrFUe5U7wXdfyuiIWgocRQTeDe/RczQShjs3K8y3Xy4aMNcnF 2dK8qZUm5s+KlFroP/IBUKh1X0MfSvb40gJpRDMy2HcExCWaGe96ztrUS gvam2YH9g+JS89lHIjH8BKDF6EhgexnGNiL7QEU4GT6YCSHS24SSmm97T 9DrYyuYs2Xqx8/9mKiYUt28r5S7Mt2+XW18A0U5wOkcQBw9g6w26WtiHD g==; X-CSE-ConnectionGUID: TXbYRa32T9WnC1vLN9E78g== X-CSE-MsgGUID: q4xCd0AhQjiPfZ9XuM9LUA== X-IronPort-AV: E=McAfee;i="6700,10204,11357"; a="41351419" X-IronPort-AV: E=Sophos;i="6.13,319,1732608000"; d="scan'208";a="41351419" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 18:42:56 -0800 X-CSE-ConnectionGUID: Ep9YPxxfTK2P5Bg1d2uECg== X-CSE-MsgGUID: GGWHT0ZjTxuZMkNLN1vLHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,319,1732608000"; d="scan'208";a="116890291" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 18:41:51 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 18:41:48 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 18:41:48 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Wed, 26 Feb 2025 18:41:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kTW3fFbInb/vemg/2ZLgK97bvf/AJH1+HEI6CBkwN3U2z+E1WB2WdzVfMeTuQEpYeUAfc1VnCrEB4yjUDuRhn+DACTibMhp5cn/TWe1z4fMZn8QDdpZ+KKGeOU0Vpzgs1bPboETqPhmxm4ARa+xEdYdVmQltKyL87bY6ZjK77RufxZ7YV6/eGB5RUX/P8/6g0lfim3HdSlKr4/tX/i/m32A46lzbwFpYKhaquIh0WzJreSLeJ2X4WvM9zPo6UOZXJsBo39llTBcYvxJkrB7oMAc4nMi6f4A6MbAHZ9C089UpfggzitYUe1LsK2P0MjHgR5DGpAKsmugRusSgiDwwZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dkuM73HhJNNT/V1h4HofecpFjeg2z8VI1z6YpGX8YE=; b=EwdmqDIwjzm505BbIFnxfsGEujJ6lRh9WuJue469yLSFebvrnpXkplzU4LHzSeKD8zg/5rPHeVKK8mtZI1H149Vnt3Tly4cjKBoZ+q/+B2xPYaFanKUTXQiP/rv6vofGvCJ+5zii9386Zs8Z1Pabm5viaOarKgW6r0Xnj8Ho7v9F5ARbSfrJknZu3EyiWDiPboYlXu3ZcwPgzkKDIkAGOSIDlMaIJSvRAGQzd5GOV/5WdLG4YVruLrir1Gv2iofzmo2qfrLIGhmJTHVNcPnoaVxxJ7fKccwQUipUTctyr4zxDyVcV7gtN/apAgQkbVTTEqSvHa86lCWu7mRs3eJOpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6396.namprd11.prod.outlook.com (2603:10b6:208:3ab::10) by MW4PR11MB7008.namprd11.prod.outlook.com (2603:10b6:303:227::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.19; Thu, 27 Feb 2025 02:41:00 +0000 Received: from IA1PR11MB6396.namprd11.prod.outlook.com ([fe80::79e6:58f0:788d:b45]) by IA1PR11MB6396.namprd11.prod.outlook.com ([fe80::79e6:58f0:788d:b45%5]) with mapi id 15.20.8489.018; Thu, 27 Feb 2025 02:41:00 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if mandatory anchor option is missing Thread-Index: AQHbiFk9QvaVjGleLEuprTjICRGKpbNacM2A Date: Thu, 27 Feb 2025 02:41:00 +0000 Message-ID: References: <86f226c0-ea73-410a-8ba7-5e416faf0a59@gmail.com> In-Reply-To: <86f226c0-ea73-410a-8ba7-5e416faf0a59@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6396:EE_|MW4PR11MB7008:EE_ x-ms-office365-filtering-correlation-id: e6d0241c-ebe7-4168-6d17-08dd56d82bcc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|4022899009|376014|1800799024|366016|7053199007|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?3AUglXdLM+bwZGVboP4bjAKQ62oLj13XpOsJIBIcInb7WH+ePwdPjTLZZJdA?= =?us-ascii?Q?NvA6hKKa3+/NhMuUEL+AlqPRHCq91dtmaAEC4k2+jbHKSQ0nfxOPIbIC/Z3m?= =?us-ascii?Q?8HHJRbY7N4fkPtUsbDT1a+Y7bb7XmW1kdw/gXU2D8lXm9UUQt2GNbR76W0YL?= =?us-ascii?Q?ZuWYas7FHnPi/kjlk6L9Lc9d/bYLcAZd6w3bW9eODmIYBT+60KY1kRygqtv7?= =?us-ascii?Q?pcovIKHgk38TkNec77YSoG390T62flYP7cc5Fk2SGOOK9qB3yOsD7NxE87u9?= =?us-ascii?Q?3TLsAcNfI/CA358fQxh/mfHaYb4b56smJuto252XkhZHwU/8oVPa2WuHJC4D?= =?us-ascii?Q?oQ/2E50bOLsnztg+Kx6iFPN/2G1SA0nXJ8cGRpC4iTuvHsXCRJFzH1tkcSZf?= =?us-ascii?Q?dfC9lhJ6oVDKawRAmMa+Ba2ZCIdfRqLOXqkosLggFChAuchjVZsjjzczAI4H?= =?us-ascii?Q?/oAs/XSvglXhUcMdJRoviEsOQjZ3uj2kA7W6uZrDTEFB0a+ZUmNTqbl23oMt?= =?us-ascii?Q?XNCIhNiJZO4/DhTY9IRPp4RUk4OhYdORDPK2J1/mX4bcKe4tgHATZzT+vsQq?= =?us-ascii?Q?sp1sSdOkb+QuTIe8VnW8FWI3sGNwCSudtMmybjzn7fZHO/HbBx+jlJdUEhwr?= =?us-ascii?Q?7i1wERNTGGgmT7Q4pK12foFRw9OOkqmIo4AK7YNbbYWxF6D+SZXPV/1SCG+j?= =?us-ascii?Q?8wM9koyNL4/vXXHpYA7ieSzB378MP3W8bdXJ9ZVQz9zFHULUogGDEoY3JYjD?= =?us-ascii?Q?QL0rjsoajl3WSIF+5yp5exq+4CJl2v79AlxedlHp2E2NY2g59v84d/hNl5RA?= =?us-ascii?Q?R5BXiQbDeqtfGcGVZdTv9VFBJVSI916tFjvnA/sV32T9OFguIHuW20jCXxaV?= =?us-ascii?Q?Ndz0mbnoN7LYsn7D/5erUa/ajgVAR2HqlPqUGcxE6X67McQSd5jn5hhqTXOz?= =?us-ascii?Q?FsKH3AR83qPy1ItspHlrWbOaOb/r6F0xRWpqZlxB6TAro3iAFA/YtW9G2NmK?= =?us-ascii?Q?2wKJNMfN7+CsCddO5X2ASdiGd6horFsQaY+OGI3K+c44LvMv3k+EgHb9pvLI?= =?us-ascii?Q?P9LYvvoyZNcVvqunp267Q/CQuKfBfSwS9lVsZTyj6yZByCstoyzdgHPY6ocd?= =?us-ascii?Q?luH5DQ0FGIchatDv292G9uV6g19Ldnyk1ao9yU2csmUpiSXP+OF1mRPXkeAd?= =?us-ascii?Q?IU10CQngGsCBx8W4xMv+Ry8sqP0T7+0AFb93Mzb0dbyaTGx1HW2TRpH5eQaN?= =?us-ascii?Q?czGl2Mc4lAl7DbkGWRdJiTd/5UrCuIIMfXpC6IOOwZtQ3cqpoKpqiYD1QC0O?= =?us-ascii?Q?tHHUi1Cb42IAemyk/OdtivspA3+pnDitcvvS+DO71vXvqqXtJKArbyxN0wO8?= =?us-ascii?Q?8nJ9C7uzmoj/mzEQeEHdPBC9eUuH?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB6396.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(4022899009)(376014)(1800799024)(366016)(7053199007)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GqmhM323cwUtdXoyZPGSav0elmRFGY4o4Het1hwbInld7Zpg0vRsmnutsdLn?= =?us-ascii?Q?8xbMMvcs4gpdCKL44M5H+uzs6j6G1C/ePm4CD+ypD1turoff/t0/lWv7C/w7?= =?us-ascii?Q?dfqgV8Vomtn+kPcIuJw+TSdbgKMusVLyNY6p0VzoRL+I+hCHVQtUMCVYIcYE?= =?us-ascii?Q?Kemh64Q0I3JRjLEM7tQm6xdH6b+/fH6iKARVWjBdlJouTG2ossoTade9cuVr?= =?us-ascii?Q?NOYojoMwnKeXU1kbNzLBa6pljJx2ufTZe2jXniwNEA7gWoxI+4Z+qZCl8NAL?= =?us-ascii?Q?lkuJxqmMvCd4lDJrNLTysQRJKPcC9OxudubIx8UIhwqTPmP+ztHxlukBLJMW?= =?us-ascii?Q?e3R5fLLcqV+qAwt6d85CA6piRJQ3LWBRgG8FYkOBIRfVoceAcF6X99QJ9rxq?= =?us-ascii?Q?1lFhVj4062hCaDX/H8iSKxpA81BC8MmT0yYloFJvMDW4ONOi7Yu56Safm098?= =?us-ascii?Q?nXxkItU1cd1QMl/mr781FxsJAYhaLtUw1TutYurhR5xcc8AOFFtGn1htYyuU?= =?us-ascii?Q?Kwr1MMfo1h2S+MlFQQK6ZHnnwRBztwOYT8uaGdPohBZ07qAKvRnVr0WRaof1?= =?us-ascii?Q?Dlf//xK+QOBf2BOP2nLXMeVNMbS/n+jPARXFZf3bjkjNSL6ar/zf2NRT6o9W?= =?us-ascii?Q?9DIuJnGQVXFBFj75HAN+CFgXKNN7gxjXvaSgMF6HtluPTRGppAt2Sq5Fc1Wh?= =?us-ascii?Q?Wj/+UNehqjaeIGweL0PIUtgGo5LGi5cGbt5bf0JxVsRf7MYFfVZJUXisdWO5?= =?us-ascii?Q?aE8Se3WKZdVSi34TNBqpwwIMqSIJqYMnO5QUiPJEEPlZNVqfQN2vNiLlBSz7?= =?us-ascii?Q?wz61fPfmu5SA2DzBn4HqDoUW5Q/RgoDz/OEWakb+7DkbzvMTd8LbT2r8zzdZ?= =?us-ascii?Q?Bew/36Q2CTSAjGyD6DVdzfztvLsZcFc5Hq4az+qXRu3pli0ZKOpx7dyPtJvo?= =?us-ascii?Q?78GOiqCF82W9LEZ2HrNTDaSNBVI+T3zPYRkorTa00tU/AI5NiQrM4LCRIAn5?= =?us-ascii?Q?YvaSohFfYPM7P0ShDDOocFUNvCPnoggQDQ2IzQtiDKl1zU71ReAC2cwe83Cs?= =?us-ascii?Q?zVnTisQpzKiI+0cQVSQMFlKTg8lmqByMYGIozD+/McbT84slh4aeRZS/LKwP?= =?us-ascii?Q?BimBU6y5E8Ilasl4eMzjjP2z8mzCvUX1tdayH/GIMbpBeCZd+cE+7ZmNb3RQ?= =?us-ascii?Q?efYa0cH+cP4Nv4zxW1aLTJ40TEwF2EAzxXdIzbzkJpWt/ptov/VU+brrYYGW?= =?us-ascii?Q?WZhzCVPUN2NSS4/wee9xeFh/L7jgCWtluxULe0zTVAqiWSe6DRvuOyfUQfwH?= =?us-ascii?Q?mvmpL4pmsDvCSFlh1F54HJ/pifUX7ZjVpyk6twmmLYudTn8/miG4vlHOsI3B?= =?us-ascii?Q?mgNYkaVmhBeXDalVXICNs1eP/OkxbtcFppLqaoy66uId8SH3syokypXOlbMz?= =?us-ascii?Q?fbV54klL3L6ZlKI8IAarmJGLaFJqrtYwgNotF96LU+766ee/2ZASCCBao19W?= =?us-ascii?Q?t+GfqbBDstJnXuSSwWcWvVAwStUSwtIyODMYG5RHt06QkTTR3KXw3GYWpS5l?= =?us-ascii?Q?aOIXG1kBDCCzTZKFII/CDrHbGh6020i14pLbLpqr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6396.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6d0241c-ebe7-4168-6d17-08dd56d82bcc X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2025 02:41:00.4083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V1xSiDM94KCZ8J9XGf+Kpe4Tr0VRi+8hb4ewwNEe/uEaSQ4O0TPxGk3HEvfQOICvlplAAbgUotJIy7Hj1A4jkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7008 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if mandatory anchor option is missing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > It prevents the filter of running in case such option is missing, > failing early, during init() instead of simply logging an error > during runtime. > > It depends on this other change: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/6c4d8098-bb57-4f7c- > b86b-9221492b7ced@gmail.com/ > > Signed-off-by: Leandro Santiago > --- > libavfilter/vf_dnn_detect.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c > index cd70c64e98..bc9a1777ff 100644 > --- a/libavfilter/vf_dnn_detect.c > +++ b/libavfilter/vf_dnn_detect.c > @@ -173,11 +173,6 @@ static int dnn_detect_parse_yolo_output(AVFrame > *frame, DNNData *output, int out > return AVERROR(EINVAL); > } > > - if (!anchors) { > - av_log(filter_ctx, AV_LOG_ERROR, "anchors is not set\n"); > - return AVERROR(EINVAL); > - } > - > if (output[output_index].dims[1] * output[output_index].dims[2] * > output[output_index].dims[3] % (box_size * cell_w * cell_h)) { > av_log(filter_ctx, AV_LOG_ERROR, "wrong cell_w, cell_h or > nb_classes\n"); > @@ -656,6 +651,14 @@ static av_cold int dnn_detect_init(AVFilterContext > *context) > DnnDetectContext *ctx = context->priv; > DnnContext *dnn_ctx = &ctx->dnnctx; > int ret; > + int using_yolo = (ctx->model_type == DDMT_YOLOV3 || > + ctx->model_type == DDMT_YOLOV4 || > + ctx->model_type == DDMT_YOLOV1V2); > + > + if (using_yolo && !ctx->anchors) { > + av_log(ctx, AV_LOG_ERROR, "anchors is not set while being required for > YOLO models\n"); > + return AVERROR(EINVAL); > + } > > ret = ff_dnn_init(&ctx->dnnctx, DFT_ANALYTICS_DETECT, context); > if (ret < 0) > -- > 2.48.1 > LGTM. Thanks Wenbin > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".