* [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset
@ 2022-09-23 21:19 Dmitry Rogozhkin
2022-09-26 1:51 ` Chen, Wenbin
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Rogozhkin @ 2022-09-23 21:19 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Wenbin Chen, Dmitry Rogozhkin
Fixes: 005c7a4 ("libavcodec/qsvenc: Add max/min qp reset support in qsvenc")
CC: Wenbin Chen <wenbin.chen@intel.com>
Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
---
libavcodec/qsvenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 84c6e29..8bd9272 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -1760,8 +1760,8 @@ static int update_min_max_qp(AVCodecContext *avctx, QSVEncContext *q)
if (avctx->codec_id != AV_CODEC_ID_H264)
return 0;
- UPDATE_PARAM(q->old_qmax, avctx->qmin);
- UPDATE_PARAM(q->old_qmax, avctx->qmin);
+ UPDATE_PARAM(q->old_qmin, avctx->qmin);
+ UPDATE_PARAM(q->old_qmax, avctx->qmax);
UPDATE_PARAM(q->old_min_qp_i, q->min_qp_i);
UPDATE_PARAM(q->old_max_qp_i, q->max_qp_i);
UPDATE_PARAM(q->old_min_qp_p, q->min_qp_p);
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset
2022-09-23 21:19 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset Dmitry Rogozhkin
@ 2022-09-26 1:51 ` Chen, Wenbin
2022-09-26 8:35 ` Xiang, Haihao
0 siblings, 1 reply; 3+ messages in thread
From: Chen, Wenbin @ 2022-09-26 1:51 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Rogozhkin, Dmitry V
> Fixes: 005c7a4 ("libavcodec/qsvenc: Add max/min qp reset support in
> qsvenc")
> CC: Wenbin Chen <wenbin.chen@intel.com>
> Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> ---
> libavcodec/qsvenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 84c6e29..8bd9272 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -1760,8 +1760,8 @@ static int update_min_max_qp(AVCodecContext
> *avctx, QSVEncContext *q)
> if (avctx->codec_id != AV_CODEC_ID_H264)
> return 0;
>
> - UPDATE_PARAM(q->old_qmax, avctx->qmin);
> - UPDATE_PARAM(q->old_qmax, avctx->qmin);
> + UPDATE_PARAM(q->old_qmin, avctx->qmin);
> + UPDATE_PARAM(q->old_qmax, avctx->qmax);
> UPDATE_PARAM(q->old_min_qp_i, q->min_qp_i);
> UPDATE_PARAM(q->old_max_qp_i, q->max_qp_i);
> UPDATE_PARAM(q->old_min_qp_p, q->min_qp_p);
> --
> 1.8.3.1
Thanks for your correction.
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset
2022-09-26 1:51 ` Chen, Wenbin
@ 2022-09-26 8:35 ` Xiang, Haihao
0 siblings, 0 replies; 3+ messages in thread
From: Xiang, Haihao @ 2022-09-26 8:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Rogozhkin, Dmitry V
On Mon, 2022-09-26 at 01:51 +0000, Chen, Wenbin wrote:
> > Fixes: 005c7a4 ("libavcodec/qsvenc: Add max/min qp reset support in
> > qsvenc")
> > CC: Wenbin Chen <wenbin.chen@intel.com>
> > Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> > ---
> > libavcodec/qsvenc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> > index 84c6e29..8bd9272 100644
> > --- a/libavcodec/qsvenc.c
> > +++ b/libavcodec/qsvenc.c
> > @@ -1760,8 +1760,8 @@ static int update_min_max_qp(AVCodecContext
> > *avctx, QSVEncContext *q)
> > if (avctx->codec_id != AV_CODEC_ID_H264)
> > return 0;
> >
> > - UPDATE_PARAM(q->old_qmax, avctx->qmin);
> > - UPDATE_PARAM(q->old_qmax, avctx->qmin);
> > + UPDATE_PARAM(q->old_qmin, avctx->qmin);
> > + UPDATE_PARAM(q->old_qmax, avctx->qmax);
> > UPDATE_PARAM(q->old_min_qp_i, q->min_qp_i);
> > UPDATE_PARAM(q->old_max_qp_i, q->max_qp_i);
> > UPDATE_PARAM(q->old_min_qp_p, q->min_qp_p);
> > --
> > 1.8.3.1
>
> Thanks for your correction.
> LGTM
Applied, thx
-Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-26 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 21:19 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset Dmitry Rogozhkin
2022-09-26 1:51 ` Chen, Wenbin
2022-09-26 8:35 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git