From: "Chen, Wenbin" <wenbin.chen-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "Rogozhkin, Dmitry V" <dmitry.v.rogozhkin@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset
Date: Mon, 26 Sep 2022 01:51:44 +0000
Message-ID: <IA1PR11MB63962C883D669312007F48A0F8529@IA1PR11MB6396.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1663967960-15148-1-git-send-email-dmitry.v.rogozhkin@intel.com>
> Fixes: 005c7a4 ("libavcodec/qsvenc: Add max/min qp reset support in
> qsvenc")
> CC: Wenbin Chen <wenbin.chen@intel.com>
> Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> ---
> libavcodec/qsvenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 84c6e29..8bd9272 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -1760,8 +1760,8 @@ static int update_min_max_qp(AVCodecContext
> *avctx, QSVEncContext *q)
> if (avctx->codec_id != AV_CODEC_ID_H264)
> return 0;
>
> - UPDATE_PARAM(q->old_qmax, avctx->qmin);
> - UPDATE_PARAM(q->old_qmax, avctx->qmin);
> + UPDATE_PARAM(q->old_qmin, avctx->qmin);
> + UPDATE_PARAM(q->old_qmax, avctx->qmax);
> UPDATE_PARAM(q->old_min_qp_i, q->min_qp_i);
> UPDATE_PARAM(q->old_max_qp_i, q->max_qp_i);
> UPDATE_PARAM(q->old_min_qp_p, q->min_qp_p);
> --
> 1.8.3.1
Thanks for your correction.
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-26 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 21:19 Dmitry Rogozhkin
2022-09-26 1:51 ` Chen, Wenbin [this message]
2022-09-26 8:35 ` Xiang, Haihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR11MB63962C883D669312007F48A0F8529@IA1PR11MB6396.namprd11.prod.outlook.com \
--to=wenbin.chen-at-intel.com@ffmpeg.org \
--cc=dmitry.v.rogozhkin@intel.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git