From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: add missing linebreaks in error messages
Date: Thu, 7 Mar 2024 01:39:39 +0100
Message-ID: <GV1SPRMB0052FAC9D1E2EE05A0F6C3D78F202@GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240306080250.5120-1-anton@khirnov.net>
Anton Khirnov:
> ---
> libavformat/matroskadec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 5d3d18a146..6d6a60c552 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -2036,7 +2036,7 @@ static int matroska_parse_content_encodings(MatroskaTrackEncoding *encodings,
> {
> if (nb_encodings > 1) {
> av_log(logctx, AV_LOG_ERROR,
> - "Multiple combined encodings not supported");
> + "Multiple combined encodings not supported\n");
> return 0;
> }
> if (!nb_encodings)
> @@ -2055,7 +2055,7 @@ static int matroska_parse_content_encodings(MatroskaTrackEncoding *encodings,
> encodings->encryption.key_id.size);
> } else {
> encodings->scope = 0;
> - av_log(logctx, AV_LOG_ERROR, "Unsupported encoding type");
> + av_log(logctx, AV_LOG_ERROR, "Unsupported encoding type\n");
> }
> } else if (
> #if CONFIG_ZLIB
> @@ -2067,7 +2067,7 @@ static int matroska_parse_content_encodings(MatroskaTrackEncoding *encodings,
> encodings->compression.algo != MATROSKA_TRACK_ENCODING_COMP_LZO &&
> encodings->compression.algo != MATROSKA_TRACK_ENCODING_COMP_HEADERSTRIP) {
> encodings->scope = 0;
> - av_log(logctx, AV_LOG_ERROR, "Unsupported encoding type");
> + av_log(logctx, AV_LOG_ERROR, "Unsupported encoding type\n");
> } else if (track->codec_priv.size && encodings[0].scope & 2) {
> uint8_t *codec_priv = track->codec_priv.data;
> int ret = matroska_decode_buffer(&track->codec_priv.data,
LGTM.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-07 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 8:02 Anton Khirnov
2024-03-06 15:48 ` Stefano Sabatini
2024-03-07 0:39 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1SPRMB0052FAC9D1E2EE05A0F6C3D78F202@GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git