From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B675749CD1 for ; Fri, 8 Mar 2024 10:20:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6DF2E68CEB0; Fri, 8 Mar 2024 12:20:11 +0200 (EET) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2086.outbound.protection.outlook.com [40.92.48.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D533568018A for ; Fri, 8 Mar 2024 12:20:04 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6VwepEZxgAEwKvdY8wrCShNF6bln+buoO1wyFSPeURE1y/eTk1LdTR9h8b/mlfiE6upCQ/HslY3yeEXCDU/x9C06vnRGmm2c/0zwbFF3EKPbRoCj/BKoFoeXFA5zPvAoqNSo/Iz/c1pFgav3NipBYGS1mZp0D8sPfPKamXQdov5Kl+ali9mDv5RslhzIHfDtj3xJ1mA2AFfWS335rMYmU+K5HkvC+yBs4bxNaTA10DLnfhIWUCzGaj4RPIOjd6hCZH59vedGp21bLKft7qE/oc1ZxmWxct2vXn8AY+fTYXrKjgeTbCMljWNHMyjRa4ymqHoo2PBl1viZ1pKlDpFyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rALn7cEFaUFC5d6ShMWlZRbJGHLJk5H3Iuubhtzv6jo=; b=T2WzY3MWto1v6gvVpaA+rCAQL9l4kufFdcii3A/aBprx6iOYN7QuigsvTuPZ9DTQ2TUZlmL0GQ6wh8CQFRDMQwaBTluBtxWO0uiHbwRKy2vP+nyNDGRqci0a2OV41EWzLScKaFV5T458AymbVhaU/3WPrB13lKokYJuC0ccMisePKFb1S0TfWef/vAvMK0REGFxMO+R8Q5D40g8ZlDo9EdzYTJ+RxSK1blGm8PeX5Fw7ijnnwfqvPiRcj+4O7AyoqdrPEvvjtW09E+Is/bQuGFtm59OPbBia7mQvFQ4evBS6Z5BzQhnuulxcCLbNODoNtQB2hhgt9Fal+BKfPZGg9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rALn7cEFaUFC5d6ShMWlZRbJGHLJk5H3Iuubhtzv6jo=; b=SB7zj/QvyizPGMwJJFGapYmozq/T7N+ZXRmi7NnwEij4fYo4xDvcTsPs8InwazsPAzGPyqMB1G3KCbfLgHyGxHtAeDXIZAdbtSLSA0Y0t1iITyduYtW71kCux9j06lNeztEG6nGH16QJNjZsmDjkSvlLrb8hQGKmq8tGEd9ElPqiHiuD5D5Ik6Up5Eruojm7N1fQ79OpEU40BwMpd68+51QSWsxVxaQXLrSUDT2sEnu+jaJ1uWp1sJaNPhf3ykn2Ku8TVH67IujfiWDZJUwsqELhoXkrzNzAQJESzw5KEarCF6cFIYYL3rG1yoHo5PyvZsOA++QsyuaVzsnNA+zU5Q== Received: from GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:109::15) by DU2P250MB0349.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 10:20:01 +0000 Received: from GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM ([fe80::a8f2:5082:22e4:8d1b]) by GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM ([fe80::a8f2:5082:22e4:8d1b%5]) with mapi id 15.20.7339.035; Fri, 8 Mar 2024 10:20:00 +0000 Message-ID: Date: Fri, 8 Mar 2024 11:19:59 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240308082749.20028-1-anton@khirnov.net> <20240308082749.20028-2-anton@khirnov.net> <170989285192.7287.17016576053815588581@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <170989285192.7287.17016576053815588581@lain.khirnov.net> X-TMN: [o6CTgtngcIDbHgbi/UQfg5UadHC4K8MfAa6UKKw+Kdc=] X-ClientProxiedBy: FR5P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::14) To GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:109::15) X-Microsoft-Original-Message-ID: <03d2b4ef-dcef-429b-a833-6dd4eb8d9014@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1SPRMB0052:EE_|DU2P250MB0349:EE_ X-MS-Office365-Filtering-Correlation-Id: ae3a63a4-a0ed-4137-02fd-08dc3f594ff5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dH2Fg/VdfNFZoryW+VOkw89VMrXKHxXV6SfSTYcaq1upFWWlqx0vyvUyBHftecBqr3pdt+DzrG0wA4uo5W5jeNYmg3uUnKRKIN86ZDxK5C4qQU6N7el6bd4wAVCulOWbzU/ijM7zVL8g/3U2Fkko8EDG3FQj8r46+TGLEkl1g2KBTPNcUuwGnIH/659ql6038Mu1n+iPCGdZVwQ14pX/DOUEnCJDZPZM0BRZUmXTs9caquzUywDMAvsDkYL/nWNo0zuYctQ5J0JCbWJ6oq55z2VvzSKikID9PYJggI9Z7E2yRkzkknItrbNBrfKKJuI1+YCo8aU+RBkKIvaXHL4KgZ+cOALn9looY3qkisRlKfH5PXpMcR2emc4HMCOfgJGSAjge/FuVkXs7KIMqxCMuComFZxBQdpxKJ8sTlbYCKFKrE43jPrNEGc4N37rDtrgvyK8iz+5DCvV6qGeUR5r1IX4SSHvQNOwuPtJQFeT/53b/S9RD6DeU0wD43b6uDBIfVpUCf+neJlFr7S+OrAylPHx8yzymgBmyARWsFgRLHdSoNESP09ux+5vrKQciWK+v X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGpTaTZHWDVEMTVsc2l5bTI5VmN2dnFBUHFkanpkTXFoN25DYUJZS09VSmhN?= =?utf-8?B?UWVJQXV5Q2c4ZWpGQ2lXZ1RtZ2NabFlrV2w4NjZ2L1AxaVBha3dlSTgyUjI5?= =?utf-8?B?TitmeDhodEJoQVFEbVE2SFZTMU9EWmFvNWNEdjEvZTNBWGpUajNQNTlGc1Yz?= =?utf-8?B?cDh5Zmo0NGpJT2ZVeTF4dG5oZnpjRzB0R01UQmUzVWtFTE1vZnNHL2c2cTc5?= =?utf-8?B?aHREejRCelRCTS9qWFhoQ0dtWTUxWVlZWXRvR2Vuc0dsb0w4ZHRNSlR5QmhE?= =?utf-8?B?RExkTkM3YmkraTFtTWFkMzRTSTAwQVExeFBselFiaFdVb3RIcTZPVEhJbU05?= =?utf-8?B?cFlMOXBGZjd4b2thdmprVXRmdHlkeDFGNXhQdndmQno1N200akpKenc3cnVo?= =?utf-8?B?WWFTZW4zVUdiZUNJOC9sNDhPSFZjajhxUzE2eTNxSHV6OXpRT3dZTkd6cC9a?= =?utf-8?B?WVZWL1JpQnlCamtUT1R1YWthTlphQmUrRkpvVlovTVI1RzVDNDgvak42K3Rw?= =?utf-8?B?QUFTb2ZOUGtIVnliSjFOdXpERWFwQ2lQWG5kQ2djeVo2VW5zYUFWOW1RZGh5?= =?utf-8?B?NUM3bDd5eEhzdmowZWNkY3Z1ckZQeFZqSENCWFRQSjdZNE9zbVZhNXk0RWov?= =?utf-8?B?T21ndEFpVmxENGR6ZnVuL1RrVm16ck1DYlRtMFJNR21jRmJJNGtQckQycTV6?= =?utf-8?B?b1piQ1R2eWk1OHJtUHZtOVJlaHRjNWxFOFRNK1N1cTVlZW5wUm5SVjI1K0lk?= =?utf-8?B?N1Q2RHdvZWVzc3VKNUtPVDJrdE15NUowVDdIYk9SeFJObGVRTUJnV0k5UVRO?= =?utf-8?B?ZnBuYytNcmR1a3l4VlRIcFdDc3JUaGUyMGh5dWhWaTZtT3c0S1VZVzhxRmk0?= =?utf-8?B?bTJkSzB6ZW5CaHJadFFzdTczdFJNRWhYbjdTU2JGMDR6RnRtQWNYWEZSMS81?= =?utf-8?B?dHVoRVNnR2VsY20xdzVJUUJwLzZTRTh0Z0RHTDJxYThSZjN5WHBWT0xLRWpE?= =?utf-8?B?RDlxaURtOTY5Y2R0aS92L2VhUy9kTTlCUmJWWEZlck90QU9aVytxL1BvOHg2?= =?utf-8?B?V3NmUEhPUmllRnZET2lwT3UzRkc1cExGUkJOQ3FKTGVad1UrMnFaQ05MQWFQ?= =?utf-8?B?Y2F0MmFCaTQrMmxDVXpvTUdpZk9pRHJGUU9uNEdrOHd2cVp3ZlJuYUs1dTBO?= =?utf-8?B?MHBOR1BlT2VFYlRNQkV4cGdJMlBNWjNlb0hXaDdtYmpMdzF3V2ZBKzROK2tD?= =?utf-8?B?anNZeDlEZWVTeEs3VkFoaW5nWjlVRDFxUzFJaXRTaklhT1JlMk1WcFpsUzF0?= =?utf-8?B?b1pFYkUybGhEVlpuektCWVhIRkFIaFRJeWhvTEJMZGw4WGdlM1ZkTUlKQW9n?= =?utf-8?B?L0lDQmxyUWltcG1nVktBbUk4UjZsd1Y4QUNHNDc4SkpuN0VIbWMwYjNTaEhr?= =?utf-8?B?YnlDL21yQkl5cm9OeGNFWnZMakFHcE85WU5NeTI2OXNkdTBTZnNERitMZ25r?= =?utf-8?B?NFJENDVVY0RIT0tPUUg0dGVYajV5Rzd5RUsvajRReWpJVVFFWFgyeno3d1pw?= =?utf-8?B?Z1BZdWRucUtRUXNYU3kyaGVwSDV1cXZobjhMSGVKVEtzckVsTnFiSUNQamhq?= =?utf-8?B?NUF5R0dDMG12ZU5xRzRKaGlJWjlmbHJOaVVJaFFwV010N2dMNXR1ek83Nlhh?= =?utf-8?B?eFFBTU5jWTBvSWlmcUkwMjZ1bXE3TXRWckx2Tk1LTk9zQXljdmR4T3FnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae3a63a4-a0ed-4137-02fd-08dc3f594ff5 X-MS-Exchange-CrossTenant-AuthSource: GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 10:20:00.7450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0349 Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-08 11:03:18) >> Anton Khirnov: >>> ff_thread_get_buffer() has exactly the same semantics as >>> ff_get_buffer(), except it is supposed to be used in frame-threaded >>> decoders. Since the decoder instance knows whether frame threading is in >>> use, there is no point in forcing decoder implementations to use a >>> different function merely because they happen to support frame >>> threading. >>> --- >>> libavcodec/aic.c | 4 ++-- >>> libavcodec/alac.c | 4 ++-- >>> libavcodec/av1dec.c | 2 +- >>> libavcodec/avcodec_internal.h | 13 +++++++++++++ >>> libavcodec/bitpacked_dec.c | 4 ++-- >>> libavcodec/cfhd.c | 4 ++-- >>> libavcodec/cllc.c | 8 ++++---- >>> libavcodec/cri.c | 2 +- >>> libavcodec/decode.c | 13 ++++++++++++- >>> libavcodec/dnxhddec.c | 2 +- >>> libavcodec/dvdec.c | 2 +- >>> libavcodec/dxtory.c | 12 ++++++------ >>> libavcodec/dxv.c | 4 ++-- >>> libavcodec/exr.c | 2 +- >>> libavcodec/flacdec.c | 4 ++-- >>> libavcodec/fraps.c | 4 ++-- >>> libavcodec/h264_slice.c | 2 +- >>> libavcodec/hapdec.c | 4 ++-- >>> libavcodec/hdrdec.c | 2 +- >>> libavcodec/hevcdec.c | 2 +- >>> libavcodec/hqx.c | 4 ++-- >>> libavcodec/huffyuvdec.c | 4 ++-- >>> libavcodec/jpeg2000dec.c | 2 +- >>> libavcodec/lagarith.c | 12 ++++++------ >>> libavcodec/lcldec.c | 4 ++-- >>> libavcodec/magicyuv.c | 2 +- >>> libavcodec/mdec.c | 4 ++-- >>> libavcodec/notchlc.c | 2 +- >>> libavcodec/photocd.c | 2 +- >>> libavcodec/pixlet.c | 2 +- >>> libavcodec/pngdec.c | 4 ++-- >>> libavcodec/proresdec2.c | 2 +- >>> libavcodec/pthread_frame.c | 7 ++----- >>> libavcodec/qoidec.c | 2 +- >>> libavcodec/rtv1.c | 2 +- >>> libavcodec/sheervideo.c | 4 ++-- >>> libavcodec/takdec.c | 5 +++-- >>> libavcodec/thread.h | 10 ---------- >>> libavcodec/tiff.c | 2 +- >>> libavcodec/tta.c | 4 ++-- >>> libavcodec/utils.c | 5 ----- >>> libavcodec/utvideodec.c | 4 ++-- >>> libavcodec/v210dec.c | 4 ++-- >>> libavcodec/v410dec.c | 4 ++-- >>> libavcodec/vaapi_av1.c | 4 ++-- >>> libavcodec/vble.c | 4 ++-- >>> libavcodec/vmixdec.c | 2 +- >>> libavcodec/vvc/vvc_refs.c | 4 ++-- >>> libavcodec/wbmpdec.c | 2 +- >>> libavcodec/webp.c | 2 +- >>> libavcodec/ylc.c | 4 ++-- >>> 51 files changed, 110 insertions(+), 103 deletions(-) >>> >> >> -1: This adds avoidable runtime checks. > > What checks and why is that a problem? > It adds a runtime check to every call to ff_get_buffer() by every decoder not supporting frame-threading (by checking whether frame-threading is currently in use). Every avoidable runtime check should always be avoided. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".