Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] libavdevice: Fix the avfoundation device after switching to FFInputFormat
Date: Fri, 8 Mar 2024 11:10:03 +0100
Message-ID: <GV1SPRMB0052B29C1852C861E1B32FA38F272@GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240308082515.53722-1-martin@martin.st>

Martin Storsjö:
> This was missed in b800327f4c7233d09baca958121722a04c2035ff.
> ---
>  libavdevice/avfoundation.m | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
> index a0ef87edff..d9b17ccdae 100644
> --- a/libavdevice/avfoundation.m
> +++ b/libavdevice/avfoundation.m
> @@ -32,6 +32,7 @@
>  #include "libavutil/pixdesc.h"
>  #include "libavutil/opt.h"
>  #include "libavutil/avstring.h"
> +#include "libavformat/demux.h"
>  #include "libavformat/internal.h"
>  #include "libavutil/internal.h"
>  #include "libavutil/parseutils.h"
> @@ -1292,13 +1293,13 @@ static int avf_close(AVFormatContext *s)
>      .category   = AV_CLASS_CATEGORY_DEVICE_VIDEO_INPUT,
>  };
>  
> -const AVInputFormat ff_avfoundation_demuxer = {
> -    .name           = "avfoundation",
> -    .long_name      = NULL_IF_CONFIG_SMALL("AVFoundation input device"),
> +const FFInputFormat ff_avfoundation_demuxer = {
> +    .p.name         = "avfoundation",
> +    .p.long_name    = NULL_IF_CONFIG_SMALL("AVFoundation input device"),
> +    .p.flags        = AVFMT_NOFILE,
> +    .p.priv_class   = &avf_class,
>      .priv_data_size = sizeof(AVFContext),
>      .read_header    = avf_read_header,
>      .read_packet    = avf_read_packet,
>      .read_close     = avf_close,
> -    .flags          = AVFMT_NOFILE,
> -    .priv_class     = &avf_class,
>  };

LGTM. Sorry for having missed this.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-03-08 10:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08  8:25 Martin Storsjö
2024-03-08 10:10 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1SPRMB0052B29C1852C861E1B32FA38F272@GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git