From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CC695492EB for ; Fri, 8 Mar 2024 13:07:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3934168CF38; Fri, 8 Mar 2024 15:07:36 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2093.outbound.protection.outlook.com [40.92.59.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E5E6C68CE1C for ; Fri, 8 Mar 2024 15:07:29 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZXsVDPkhEJ9QLRxtyCV+kg5V/qwl9YbX0qby8ioSK0FntJetHKipOfmt72jekScln0uQXJ1nYKnk63DllOiZb25tFuS05Z+ikDV/DZltPJPyVt70YK/j1Yt/6XqPXC95d7Nn+0qwN0ElPde8FfrcXRHWZaU9DiCTQuiRNRc89fuqHYe6Zjhzv6w146sMkyRPV6iqm0mH5HrS+ihCuwXDcWzSUI0aAsTuV4JsH32AIPlQhunXg++NlBJsIelww7rYbkH0P4oxPglHwMlj5bSk2IipjmUWDyCF+gz4XyGbmfRj39LwZ4UMFZqGSu+QLN6R3qnimXVgCznkVsVzylm+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QWBhqQUYCGfXP1U6yn1c67knY5cEP+/CtSLTzidbwe4=; b=XEHUFfB56P45fcXEkkAe0rIXRX5RbnlWR8qxIhCFQFstmyg9W1eJZCtf2DrTct4xUzMUrgf8H/ZyybP40HfQ7psdIAvz+NNC3ep4q6b2wTpS3k48J4g06GWGbCJnk7npz0IPynBN7L3S60l6uTfLPz3sEouSMsa8BRNw2eQG2SoacuDXUfXAZ9HUnD5MNjiEeKNMpMqLF6031VXgVeF2aPB1ecHJ64+uGMN7VRRPzJ8ErBSOVPz7GjYFYO05UiFPqmOSNCAK7J59LjYW3XnoEQ4mZDd70PpEWieXuKEaICJCXSQL4a4i81BWXRoqU0ZNKev/kbD7ufIt5F93Igg9Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QWBhqQUYCGfXP1U6yn1c67knY5cEP+/CtSLTzidbwe4=; b=I+2p2ltZF0Ct+kMrCLit1ecdLYDDdASjweZ6veQoNBPn/EJZDuDOGF6My6AR//jEZmBtFeMg8zkCnENAzPLjaKgEdo0/tEhGVH+AuqM273Wwr4b9Kq9aEfhlMGGnNsjxAtCI66yO8NB9kyCWLE6ZUw+OdE/6T4XWck48wsg9QawS8d453tOAWMXTgaI3DQ1gwPifZ5pgyIhGSZBetLJzwK/LEha2WwAGdM4BQgtdPMXqbETL7KD4ff/g/SY1bHbfsjjOlEbwDGUVUlUAU61NvKSkkgxa53FGUZ/mRzfwqLfZVIKpqgTeqxvv+aL/Bxs9imi0+qzrguIvmUymEKz/cw== Received: from GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:109::15) by AS8P250MB0283.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 13:07:28 +0000 Received: from GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM ([fe80::a8f2:5082:22e4:8d1b]) by GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM ([fe80::a8f2:5082:22e4:8d1b%5]) with mapi id 15.20.7339.035; Fri, 8 Mar 2024 13:07:28 +0000 Message-ID: Date: Fri, 8 Mar 2024 14:07:26 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240308094928.62556-1-lq@chinaffmpeg.org> From: Andreas Rheinhardt In-Reply-To: <20240308094928.62556-1-lq@chinaffmpeg.org> X-TMN: [jxHteU3y65Ug4j+pzgMMKqmGf4s2lUwvc/qc+RsEtDs=] X-ClientProxiedBy: FR0P281CA0255.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::18) To GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:109::15) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1SPRMB0052:EE_|AS8P250MB0283:EE_ X-MS-Office365-Filtering-Correlation-Id: 6059a2ee-0fad-4032-87e9-08dc3f70b497 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6JMHSTY3V3fAI3mnwB+txb5ObOom8iQ1Y9efYEpYjvFN9PwKVdMszAL1yo1RSAFCdXKxm+AAAD+NWJdxSN/kE4qdB3+m4W9gkTK7qLpWVGWubbpa10bwDlLWgtBXj2Dv0OCOqV+JsJW5SM4TnZ6JiARquA1Q1KnYkMhLP6/TYbrW0X15v7UQCY4By8oBHYkONu0YKSaIeoFSYKEOa7W6KQ6a0ow+18+iQMkyrV4ykyOVFni+i8rloP+ihkdTKU4gUHYQsS26ng7GqSrlFpFT0AIFlRSXcL8Ie96wiaW5tvn6gHmXid+7zJosAqyn1L0F/aQyVv4KSJNuAnX5jkdAZIF1sRhbh1E7S4fN7E7MV2YEEDvNiR8jmlVsBn7172XjoLReF2UF1aTXDfT/pgDtTKmSpKFoacgVXheH7DUJauAMRXOyZfOMm3gRgARMA+Gy/TKC1Q4iplHEkQKgQJWVFHownqsgNB8paweQzu6VxCz0UT5uxDy09ENsI46vqo1SB/6i12B/bX5XxPyQgy1yrNycu+T5eI3eO9djEg+n+qbbty1sHAnNEhKqyiPOeIuN X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHZsMlh3OCtELzJtb2RqcmhiV0x3QlhXVzZhS2NuQUdDaWoya3BRUWxtUUVr?= =?utf-8?B?VHYwU1NpRjVFdmkwUy9TdGRUWGNFZzQ4YWtibTc5Wjd2QUFzN2VYcWhMdWg1?= =?utf-8?B?VzAvMEtOTklKanUzR2tibG1WNzZ1djY1QmtNaDdhMmUxd3NhSlI3UktCTmN0?= =?utf-8?B?VVljeEZGY2R4WW5kbnE1c2lJL203N0UvbS9mSTg2eGI5a1JTZEgwSUFoVUJN?= =?utf-8?B?YnRLR2tpY3luVXlpaGRmSWlNNWNpSmtqaVVqWlV6R254aG9leWdDZnNkcXMw?= =?utf-8?B?V2Nsc3U0b0g5K3kvN3M0Z3IxSENWN3NWR3QxK3ZnOEpZak9pU2N3V1pLLzNH?= =?utf-8?B?NU83aXcwL09wS29waDJTWWxsTExhL2hndUVIVE4ycGZROThsQmJTZ3A3d3Nx?= =?utf-8?B?SnJBQXZ2SHlOWnE1RlhpTHJ5dzdDdStRckNPMjNoRDZTZkh1Y2xFQWYxQU8x?= =?utf-8?B?VTBVdmViUUFucFhYVy9Mbmx0dldoZGNkSHpidENsZlkvNlp6cU5ob2pwcW52?= =?utf-8?B?UjJlY1dJK2dNejFSNml3eGtnMTdtR1JGc2VSakdFYk9qVTE5WjNxcmlOdTls?= =?utf-8?B?aTFUOEhsajVJbnIwQzVyQzJVOTNNaVhDRGJTd2crMFNNQ0hCQUNqWGgvNU5P?= =?utf-8?B?aFlkTzBENW5hZlNHbEJ5Zmg1VWJLaHd0b0U4S2xYQlhGeGJCZWU1RytrUlBB?= =?utf-8?B?cnhXVzI4c0RJa3JmRUxBQkorYnJyU2FQZ0I0cmlTYTN4Z0I3ejE4ckVIV3Q5?= =?utf-8?B?ZE9UbG12VHVvdElmVDJjZmUzWlhQbU1Hc2V1THBkYWtxaTAzS2szdld5Qmpl?= =?utf-8?B?eTJ1M1BvSitRY3dSUE5nWlIzK2VyOFZ2eFpYdzhLOTdqKzlES0ZtVkFidnQ2?= =?utf-8?B?aVhSSnRyUFhTek9HVllLbk5lQnpFSlFrQTBFZ0lQZnBOTENTUEhJTXhuN0hj?= =?utf-8?B?Nm1KRHBIbGZHZEhFUFRPdWtPenBxbHhQNjFEejZibXBzczI4QnVEaHhSZDRD?= =?utf-8?B?QW5RQWloelBCK3locE1Fc0lqSnZoNThkMGhGTlQ3NkRqNy91Rit1aHFKajhu?= =?utf-8?B?ek5VZDUvUjJHSGF0c1p5SkRuR3RiZEhiN09jZHR4ZmhPaWd1YWJacEh2WFFZ?= =?utf-8?B?ZG9WeXJoa3ZiSE1YRjZWTXlvaEtqOWpENUlGclZTNWt5OWU3MkxvNEdaaTIz?= =?utf-8?B?MkVoUFdlRDNrV3I2NGU5ZHFtUkNmUHpLczIvZ1psMlNpNmZndjJGd1Z2ZlRN?= =?utf-8?B?ZTk1MUxpdXFCSTBNdm1SVFRHWE1GbGl2NnlidlRkZVJnVzU2aGVSZlltUlRw?= =?utf-8?B?VVdHb0p5a0ZpMDU0dmpiNVdhMFFOdFppenFMU1U4TXRLMDViVTNoa3VKbmNY?= =?utf-8?B?azdCc21kWk41dmZ3b3Y0QVJSTXJyU0tzUUdRRTdhanVIdGQyQXBkNTJmOCtD?= =?utf-8?B?bUY2UEZZWkF6eGx2R1JWRnVnODlHMGdCNVFNZ0NONmJIaXhqNEtYeUtQZXpZ?= =?utf-8?B?TGhPNDFmdm0ydXZWUENTWnkzaTJ1YWM2QVFlNGljWDRWRGVrT2t0cFZrU1U2?= =?utf-8?B?dWordGYvb2RvdGxzNExIeU9ndkEvWDAveGRZcE5nTTQ3U3pwakpxWVlNS0Vi?= =?utf-8?B?M04zSWNYZmw0blJuN3M1UUpXbTZVTEdZaHMwVTh4ZkUrbG5pdnJjTDQ0MFV3?= =?utf-8?B?bDdWbzdSSjFzcnJyQVpNSGhuRjBNaFYySXBUTThKWHlIY1VsODhPbmJBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6059a2ee-0fad-4032-87e9-08dc3f70b497 X-MS-Exchange-CrossTenant-AuthSource: GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 13:07:28.0001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0283 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Steven Liu: > before patch: > test failed when using libaomdec. > TEST enhanced-flv-av1 > --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 +0800 > +++ tests/data/fate/enhanced-flv-av1 2024-03-08 17:38:25.810152322 +0800 > @@ -3,7 +3,7 @@ > #media_type 0: video > #codec_id 0: av1 > #dimensions 0: 320x176 > -#sar 0: 0/1 > +#sar 0: 1/1 > 0, 0, 0, 41, 4718, 0xc4d912ec > 0, 42, 42, 41, 5109, 0xc065dd7d, F=0x0 > 0, 83, 83, 41, 192, 0x160c5335, F=0x0 > > after patch: > test passed > > Signed-off-by: Steven Liu > --- > libavcodec/libaomdec.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c > index 69eec8b089..2df2fa6fd7 100644 > --- a/libavcodec/libaomdec.c > +++ b/libavcodec/libaomdec.c > @@ -58,6 +58,18 @@ static av_cold int aom_init(AVCodecContext *avctx, > return AVERROR(EINVAL); > } > > + if (aom_codec_decode(&ctx->decoder, avctx->extradata, avctx->extradata_size, > + NULL) != AOM_CODEC_OK) { > + const char *error = aom_codec_error(&ctx->decoder); > + const char *detail = aom_codec_error_detail(&ctx->decoder); > + > + av_log(avctx, AV_LOG_ERROR, "Failed to decode extradata: %s\n", error); > + if (detail) > + av_log(avctx, AV_LOG_ERROR, " Additional information: %s\n", detail); > + > + return AVERROR(EINVAL); > + } > + > return 0; > } > This patch is very problematic: If you change the ref file to match libaomdec, it will be broken for those that use other decoders than libaomdec. Actually, there should be no reason to use libaomdec for probing since 194414f62d987ad831654c45fff6ee27898b832e. Maybe we should add the AVOID_PROBING cap to the other AV1 decoders in case the native one is available? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".