From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E262549203 for ; Thu, 7 Mar 2024 11:33:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3472868CFA5; Thu, 7 Mar 2024 13:33:53 +0200 (EET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2044.outbound.protection.outlook.com [40.92.65.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D994F68C846 for ; Thu, 7 Mar 2024 13:33:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cSzfRoBPQ720Ycqqix13ulekI+GKfB5g0An2AMvjJa8mi6LClQeSAqONbRdYOtZUXg+/MKbc3Sfp+haLlfAHYmScAF8yt+qjmPXiD8CoeB2BCyT/eg/DEnzijSYDALDGtfUDzj1PGJ3W4KYdhknUooeHNPdffYu2A6xcmwErR1MzfDliO2El8ZWLSGM3ltsHpkLlJhR6d6zawR2rKQI99tE7Z4LlLdrxZn5b1j+u+cOEivtDQ0ZtrKjlOr073Kyo7CViJHZ55Sd7aLkFjRejvK80AsIxiuivLb9U647OSLB8NZUoEDwCrfn+Xv+wsfsWGbWInNwsRjah7ZIpiSPOKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHEtz875znU9X+F0XcI7nz/u3y5/g+MAnEXwviKQhbs=; b=NzZIwuEMTvVSOdN0Z1zcyUY2V8vOwCXlLsJO/FnQRAYgX5Sh1rsvDiPJ0KQHF9zrqA7UI/POCOy9P/yWIngLc51lT2a2mSSVRISb+b6SvoaY7jzLyvnBmSaiiVtHnMZ1J/Mpxi8wadXOThcHF7khDApZKQm4vrlhy0rBrXdTiPt4hx+K5uAxTMkxenntmFiDK3NlES+USOi6R3MG+o6827Qa/Qe5osrFlxiRoLPclhC5W4m2oPPKLNES8kl/5zAbT553oZ4ebOEH3xpAMs96NB+4SZpU/SBltv4sRd3miRlP3f53ctkSPu/HIBK7dVAAnbqHBwqSV2EZpE85psrACg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHEtz875znU9X+F0XcI7nz/u3y5/g+MAnEXwviKQhbs=; b=onl9y4y9snSP65M/FmqQPXV4wGkXqlXB+EQdNH7e82T0V1vWdzoXeaNDRyQte5vBZnsHyLQ4IRs6EeVSxzt/m+D4AKG6QLOpwgNvQgTEaJkoP7mNj+9UulzBYkfA0racggnOb76mcqyCxfeZQLMyL59nwqyke1u86cQkk2LH57jtBX23y8scBz/na5cAD01FgAIHWo3xYFVtYvC6tyMRs3cXGvu6ca8kpQuG5OeHpuf/8O8B+W7V5uGG4Nv9UKkuYicCNNyakVGL0cTmItVMls6yK1j0S9+YTDR35B3YdDx/NlrFsgana7CktOWzGpyPMdhLBlSBSUK08pILWpm6WQ== Received: from GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:109::15) by PR3P250MB0340.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Thu, 7 Mar 2024 11:19:31 +0000 Received: from GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM ([fe80::a8f2:5082:22e4:8d1b]) by GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM ([fe80::a8f2:5082:22e4:8d1b%5]) with mapi id 15.20.7339.035; Thu, 7 Mar 2024 11:19:31 +0000 Message-ID: Date: Thu, 7 Mar 2024 12:19:28 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-23-anton@khirnov.net> <170963280234.29002.12316451033069413004@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <170963280234.29002.12316451033069413004@lain.khirnov.net> X-TMN: [dDsisdV4CzmS7j4DAxAIhn+dVcv64rGG0X08m6tcROQ=] X-ClientProxiedBy: ZR0P278CA0028.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::15) To GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:109::15) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1SPRMB0052:EE_|PR3P250MB0340:EE_ X-MS-Office365-Filtering-Correlation-Id: 0748f439-212b-4875-4287-08dc3e987575 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N67f2VVv27QHT15jd9W4Vo61G2s8Rh7xazYm9J3VdrBsw3I7IAvulaOFbuZsxtj+DWX9HeUx3em8TQxFN6FHcI9bUlR61c1NrweEYUhy+qxsbkJLAzE+6b7VS+/Q88B2WPM91dIl97ZW5ckW8jjIfEZDfEUGI1omE3IkTty509k1S7lP7Q4LboCFyb0Vg7wO/IeRpHwP+xSCwqya0cMNFXdp9Z3gER3uEqd9gJ7DiNtBupjFH5wSmx5W9D70ZsgEB+zhyx48vT+4gJt94+McgbBfdjP1Ml2qgHdh7bvIuuC7l+4dNSmTTLyJ47GpudCmSNM+oxgbVJU4ocYR6W62u/l44CtzCcVMujunbgDh/tWmfG0LpobeUJEwvXySVxtKUYGiJhLLDUm0NS7XKGXOg/A5aIWYLOVUG5EAU0G2YWdX0Q1OHAsZpIa311pf1bAFRtuN4NVNTptRs6X3i4mskQnAZKByAvKW+XjEDoJJMBhRIYZPaRmNabFF+Ilf/nqev8F1Annpkx2UyooidqNm4PjVWoNdy1tpQmPXTPHce28V7n58AsgXMHW6nhzNkSkL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MW5FWEJnazV5YS92cnI5dEExajI0SDYvVnFBdXpTU0E3MEdpT0laWC90MmlB?= =?utf-8?B?dmVRR3VqZXFBQmtsREVvNnpqRStsWktyWjB4dGRmVFFnVTA3Z053NGhhTWdV?= =?utf-8?B?b1YwaTdNdTY0TmpNZHZIRDBwUnpkaTdvcTl5b2Q3N2JrVllIME9IRDJDUTMv?= =?utf-8?B?Z0VCZEJPdVE1aEU2aE1rQkw5NW1Senp4a2J2OW00azFFTW5uVS80UWw1RGlO?= =?utf-8?B?Qk94U3AydUtBUy9xWUpMMFBrcFc2eVlkbi9xMjNYd0U1bnc3YSsrWVcrR044?= =?utf-8?B?UmVOU29wS0ZqSjZvdUVDYm9kRVY0dVd5OXoyOFo1RlliQlZyTUppYktGKzFR?= =?utf-8?B?M2h5ZjA5QjFsaHJ0KzRCWnNEdmJYQTR1aXNFTHExbUVQRGNBWTl4V2xBOTlu?= =?utf-8?B?TzRnVjJUTG1MK0JtOWJKejkwb010eldUQlpMeFh4WVM0SjJ3VmRoOU1IMjNt?= =?utf-8?B?S0EyNEcycktROHpNOE84b3FXUHR4bzd4MzROUEQxeUkzdFRoV24xSG82dUFF?= =?utf-8?B?ZTRsb2xxL0d6OERwNEtZSU01S090WFFxWG9EVjB6bGFucDBBa3hUN1pVV0hS?= =?utf-8?B?SEpMVmFqWDVHclYzdnBDQnh3MVRORjJpNmwrUVBKM2UxRG1mTjd6czVDbXZ6?= =?utf-8?B?QTVSZ0ZJVGJNZUpLWU1TWTlRU2h0NmkzcHFrN3c1Zk5XbkRRUER6d2YwMUIv?= =?utf-8?B?cXpIMjY2MXNNNmFrYzF6NHVVRVF5MnBHellCZGpVcUUrTkRMREQ5aHJxTXpC?= =?utf-8?B?WTJNL0IwZjljaWFHYWd3RVhmeGMyZERkUW96L2pjRno3UlhHVHo1Z3pIMGFo?= =?utf-8?B?V0FtV2p6SVpVTTc0L2lxMzQ0UzFYRGJaWHNCU00zTHRpUzhKQlFNQk1RK0ZB?= =?utf-8?B?WkZMa01Hd2J2NUk4WGRVRlZMVHdITlVZaCtCYTZqL1NhVWpPaGhHVnVxVkRB?= =?utf-8?B?K09DeW5BdkdtRHFiUUlGWGw2MUUwTXgyejlKWkRQL3lFWWltODZMcklMUTZH?= =?utf-8?B?NlpOSDhHVXJ0VWM5Mmd2SlBEcHVBODRsd08wRDZnS0I1N3VNMG1Lb3U4U1Ur?= =?utf-8?B?UW1HWHROQlhCVTZmNkRiYXNhWjNZTlkrMnZ3TFUzb3BiL0x6Zms2QlRwYXJI?= =?utf-8?B?YUpURGFyVkpWRnFZWlNSbnhtVFN2ZjNtcFVaOGtZMFhYclJMMHVwU1RNQWc0?= =?utf-8?B?aGlEaVVlYkY0OCtUQ29jRk1OYVNsQzJ5Y25xRGtPTnZ0UlFRQVJDcEZqRHhi?= =?utf-8?B?OVBsK0lSNnRxeC9RUkhrWW5teVhlQ296OU9nN1cwOUp4dis5dTZOeDFaKzAz?= =?utf-8?B?a1NxN3E0RUxOaXpwNldqSlJZUHR5WUJEY2RnYVgxbkJodkxrc2tJMEZTYU9s?= =?utf-8?B?cHU1Vmhtc1VSc05MdmZQQVI5Vm1GajJOTDR5VjErWkwycGpMZFZTT3pGZW5a?= =?utf-8?B?Q2Rqd2VoeXA1YjNpcHpYOGhvbjR2bmZuaHhYcFdJUVcrdzFQQ1I5WE5RcWdu?= =?utf-8?B?cnFOdk9WVGNCUnFMVXduUVBLUFMvbkI3WjBPWWVyZS9NM3dUa0JrcmRDMWln?= =?utf-8?B?ZExtRWlFZitVUFNta0FnTkRpSWI2ZVRnU2VjMWN0cUZ3TnduVjlDWDhtWm5Z?= =?utf-8?B?alBjekxnZERncnhyR2JvQ01INVZkbnJjWUVDcjBQWmdoWVhWSEtoYStaQ3JC?= =?utf-8?B?WFQzR1owK2VTdDd6UkZGKzdTY3FEOHBvQmZGV2tqek50UHpsUXJBOHNnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0748f439-212b-4875-4287-08dc3e987575 X-MS-Exchange-CrossTenant-AuthSource: GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 11:19:30.8229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0340 Subject: Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-04 14:36:09) >> Anton Khirnov: >>> From: Niklas Haas >>> >>> For consistency, even though this cannot be overriden at the packet >>> level. >>> --- >>> libavcodec/mpeg12dec.c | 18 ++++++++++-------- >>> 1 file changed, 10 insertions(+), 8 deletions(-) >>> >>> diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c >>> index 3a2f17e508..aa116336dd 100644 >>> --- a/libavcodec/mpeg12dec.c >>> +++ b/libavcodec/mpeg12dec.c >>> @@ -2531,15 +2531,17 @@ static int mpeg_decode_frame(AVCodecContext *avctx, AVFrame *picture, >>> >>> if (s->timecode_frame_start != -1 && *got_output) { >>> char tcbuf[AV_TIMECODE_STR_SIZE]; >>> - AVFrameSideData *tcside = av_frame_new_side_data(picture, >>> - AV_FRAME_DATA_GOP_TIMECODE, >>> - sizeof(int64_t)); >>> - if (!tcside) >>> - return AVERROR(ENOMEM); >>> - memcpy(tcside->data, &s->timecode_frame_start, sizeof(int64_t)); >>> + AVFrameSideData *tcside; >>> + ret = ff_frame_new_side_data(avctx, picture, AV_FRAME_DATA_GOP_TIMECODE, >>> + sizeof(int64_t), &tcside); >>> + if (ret < 0) >>> + return ret; >>> + if (tcside) { >>> + memcpy(tcside->data, &s->timecode_frame_start, sizeof(int64_t)); >>> >>> - av_timecode_make_mpeg_tc_string(tcbuf, s->timecode_frame_start); >>> - av_dict_set(&picture->metadata, "timecode", tcbuf, 0); >>> + av_timecode_make_mpeg_tc_string(tcbuf, s->timecode_frame_start); >>> + av_dict_set(&picture->metadata, "timecode", tcbuf, 0); >>> + } >>> >>> s->timecode_frame_start = -1; >>> } >> >> -1 to everything that is only done for consistency. > > I prefer consistency here, otherwise the decoder authors have to choose > which function to use, and they are often not aware of the precise > implications of thise choice. Better to always use just one function. > It adds unnecessary checks and given that internal API is updated more frequently it is likely to lead to unnecessary further changes lateron. Furthermore, mjpeg still emits an allocation failure error message without knowing whether it was really allocation failure. Finally, if we really believed decoder authors to be that uninformed, we should remove ff_get_buffer() from decoders altogether and only use the ff_thread_get_buffer() wrapper. Somehow I don't remember this difference to ever be a problem. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".