Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Soft Works:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Andreas Rheinhardt
>> Sent: Sunday, July 3, 2022 12:21 AM
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> Subject: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper
>> type for NALU type
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
> 
> Nice! That's helpful for the QSV SEI parsing. The one missing bit 
> is the HDR data (AVMasteringDisplayMetadata and AVContentLightMetadata)
> assignment which still seems to remain in hevcdec. Would it make sense
> for factor this out as well?
> 

While the H.264 and HEVC syntax and semantics for these coincide, the
HEVC implementation of it is not completely spec-compliant with respect
to its persistency: The persistence ends when the coded video sequence
ends and if the new coded video sequence does not have these SEIs, then
we would need to attach an AVMasteringDisplayMetadata and/or
AVContentLightMetadata just to cancel the earlier values. I just don't
want to enter this and this includes not extending it to H.264.
Anyway, I have now rebased this patchset on top of master:
https://github.com/mkver/FFmpeg/tree/h2645_sei (with no noteworthy
conflicts; basically the only change is that the second to last commit
now adds proper newlines to the newly created files). I intend to apply
it in two days unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".