From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 19CC343DDA for ; Fri, 11 Nov 2022 17:36:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9806A68B103; Fri, 11 Nov 2022 19:36:17 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073034.outbound.protection.outlook.com [40.92.73.34]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ECD3F68ADCE for ; Fri, 11 Nov 2022 19:36:10 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJe4cBfrgcTWmd7xB7jIXBuysD2FOFHW+FhA+ty0CuR7j/9ydvhxbilcU4f3k4c8BiJJ04iHFDGWwJxnbFZ9Wxs4dvd4fpLN9hRqJB9/FeZqqWfChLl94IA71bTeEpAS2fnp9qScYge8L9BiU5cq/1G9BnIe/rB4DE0eNfj11BImzeCN0w8k91Q/wshYVY5Tc/y245gpZFQOQv8mIStwWnU+EBr5NovtZkuDA8PUJjDcd4dokMsfV7v/y7j/BL9Tt8XMvNDXikSxNRLGeBeAQqnb/Qojo27jLQRyWrCmw6HD1Uo0KgWZ5CY3klh/Yy1agXMnDNQaWs3jXdw+Je483Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GZa3/aM23IRd2gkF6IPkTi1FirFfJa4gHXxRePvwHYo=; b=T6MM3qm9ytUKJ8BXrX9OCU5laMUapa5w7wT15tCeVGRjnysFXrSCTTOGGUO6CFrpeQjjleaWRYzdmbY6b6QVn3s9/ppG+EADOrB6b9VC1juD8qTBQ/08HaWODXbT7jsIpEWcmpgyqJpNp8/KB49WThwIlqVi4e3wPZDAESKt9WcX/QOI43B+P6WHvTIErP/KBJV9ZpZamta1icF2vsAZQV7OK3mdI9KxxHXHtI3Wa1n/Jg+kmDrV6G9xRbnctVeSZ2fBLPruHzqkll9+g2s+H2XZUUrodJkHU43wmMPQfLEBtLSoAhQRPJrXqC1hz6FD6zO/LW4y1FlAnEIpzUVzDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GZa3/aM23IRd2gkF6IPkTi1FirFfJa4gHXxRePvwHYo=; b=fQvivbCOCCjaXMKA9LPyqtZP4qwXsY1F7MsntYh7zjW+iVasLw1A+NGDZqbEziFhcoCY7KbKKP0UXYbHaqiA0Es18w3Ec+xcjf1Flf1R4crZWvW7TpowXON09uI4QuVni10wFE/oUmJ2gWn4ghxxBQ5emXf1mcP86TNF2EVD1TOYYGF769RiLz+7ny1rG2h8odAT7O7SiAQ3/9aiMpm/tArzmkT9DBo/PZ8WteDgW0ycdVRdJDi5/5xx4QChO3lZYnTAzeOwgAAx33AY7GKh+9YygU5MPRtV1/PNZ0zu9QNdkocIfjS+rTus3ryzraNol0ExKoe1OyB9ysnT7CGFXA== Received: from GV1SPRMB0038.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8b::14) by PAVP250MB0978.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:305::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 17:36:09 +0000 Received: from GV1SPRMB0038.EURP250.PROD.OUTLOOK.COM ([fe80::490d:436a:77ce:3feb]) by GV1SPRMB0038.EURP250.PROD.OUTLOOK.COM ([fe80::490d:436a:77ce:3feb%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 17:36:08 +0000 Message-ID: Date: Fri, 11 Nov 2022 18:36:22 +0100 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [paZXIA/hTFHVAotzVZ6UypqDGSmWqiMlB+Ke10mikQM=] X-ClientProxiedBy: AS9PR06CA0130.eurprd06.prod.outlook.com (2603:10a6:20b:467::17) To GV1SPRMB0038.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8b::14) X-Microsoft-Original-Message-ID: <7c71d350-7516-3114-f705-9c186b7de8db@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1SPRMB0038:EE_|PAVP250MB0978:EE_ X-MS-Office365-Filtering-Correlation-Id: c917bc4b-3952-4e40-d95b-08dac40b37d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2duFlQ+ozR9lTEMo4b90uRWEpGSJa5Q+TL2XLYF8sSyFVBSknp/xCsxKiN9hbgYwkDMtBMkwXDseJ/LPL3pcgSdiAoPqc8vNuzmEVeYUTmxyNr/UH1zlrvjvqgfhikDhP+FIqHyus6EQWjxPwvdxIsh+FM+reISge6iZgfnqI0KCNBxp/VTZAkSmRwDhPoqIGUscPXYcX3b/AUIpKgu2PzjFM9fEnDthciBpUrkEnKprT7deypC2uT9ibxPhE707QIJZNgTQ0Hiq1wk8AMBntjuxR117zundqL+w3r2gGoY0fa6mA868kix88YH1EGnaFClzrOTzthYHJ82Q8qCfBpqTvZPB1V/Y4WeWVHTEWqOr79HrubPBqkkxbZUQI7ywNcjaEX+aXWp94gOhxHTJGpexRyKx2MBEiUjSd0MWjMZMcydcoWywqv8H2i7RoTiBxvItbZAAGmvAiiVvGGtclIFmp42k2Chc2cjkrRYuIQJy5j9BmZsGKwLPW59WknRSTiMHIg85Q8KIKYdSlwisW2Mkyb50kC1mYsBeyAeI53ptll1xIyMvAlSPQ04UZDmm7kHJQi0MOdOsBed91Tj5H+i3e8D0c6zLlYAtsfo4Q/QKi7cD2vIER27kQ5Rwjrk1ym0/Kxpd5kVSpMU1mRjzvLlI+dMJxU5moLwk1v448rerFnVGn7Cm5laAA25KegC6 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG9MOE5xWEJ2T1d0TzhEcHdtZzgxMys4cmFHZzRLUGs4U2tJWWhhREZVMktL?= =?utf-8?B?R3JodHgweWl1MU03bDNEM2VBLzk0WFo1SHpxc0ZycVJyTGU3UzhlOU9MdEh4?= =?utf-8?B?RDdIYzRGRTdra0E0bUd4TDl0SENES29za2k1ZVM5MUh2UjVpSTVNcERtTy90?= =?utf-8?B?T0dlN2tvYnlRRmhSVWZsM3EvVjczRjNnK2IvcFlPRDY4UHoxZzNQT0VkZytr?= =?utf-8?B?K1l0bkNGbGNXS05PbnJOc3RzQzV5OHlKZmNhUER6VjgzbFJEdEdsaFBGaGJn?= =?utf-8?B?aWM4K1BadkdndTI1RkQybEZQVVBjTGVkVUIxaDFxbXZoRHdvaTlNdFdDVWVC?= =?utf-8?B?YUdjUlZlMW45Wk5TM3Y2RWRLcWFKTWhJYi9ndm1iRGJiblZyVEt5SEV2S1R5?= =?utf-8?B?N1YwdHBLNVhJRnJNMytkUmVxY25NOTZyc0l3T3FxZ3B1RDR6T2hmWTdVOFp1?= =?utf-8?B?QnVJL3VGWGhtekhOcjlCTVNxczZmOE01RWJnS0lHM1g1dW5uR1ErZUFyN0Rv?= =?utf-8?B?bVgxUEZ2UXUwWGNxa2FkS2ZMVm5renZQWXhnV2tDY3VTNlBVUUp6Y3hwODFN?= =?utf-8?B?REJxS2Z6ZkxnWUtQTzlzTEs1MHhZQms0N0x1RDNtT3VsQ3B2T0VJVlJaVkhw?= =?utf-8?B?Y3pJaTFyeDRQY2ZrZlpRTDl3aWI0YzBpSmcwQWNKdzBIS2ZjaEt2Q3pLMS9N?= =?utf-8?B?cnVIb3VZU0RYa2RaRlVpTHNyNkIzS1B4Mm90bVJnSHFZTjlyV3JLdUZib0wr?= =?utf-8?B?RmQwbVA4TmV4S2NKNVFsWjVDb052eWRodjBIaUpjNXFadkljUUdaTWZEcFo2?= =?utf-8?B?UU5IVzBEZkhwR05yMVAwYzRyc2tOVDZSc1NoZjJpYXdVVzNXbUFPVHh3bm11?= =?utf-8?B?bXZJQzFrZlRBZ3dnTndjalRrWmhPRFlYaEpEeUN2M2sybWhyTjBIZm1DRzFP?= =?utf-8?B?Z0xhblFaSXB1S1R4NmRpbXRNUGdsb2xTdXZwWlovOVlvMXhFSFVoZk1CY3hV?= =?utf-8?B?UUJGYnpYclEzTTVWOFQ3QXZhaWdQL0FWN0RNZSt0K1gzUGJyVTkwTkNORGpD?= =?utf-8?B?QmVYemVDVnJkM0U2b1pqSHRpVXhqeHBYbHBwNzk4VFlkZTdaQTl4K3NFcGs5?= =?utf-8?B?aTBISXcwZXFsQU1DRUJ1Rld1b0lRMGVQcDloSlk4djVzVXVkdS9CT2NTMndD?= =?utf-8?B?T21SM3lUMTBhdmdqd1JOU3VGWE0zWGpLMnlNL2cxZU1mVHZMYjAxM1JncWw0?= =?utf-8?B?VCs4Vlg0QTJ2dEhTRUxDdklRWWNlUm1iVDNZcFNkTVl6MVprbjAwd2Q0c3Js?= =?utf-8?B?WEtGeUUxMlJ6TVZGZVdGRWdjeGpsN0cxNVRtMEFDTjI2VmVzRnFYeXlxdlAr?= =?utf-8?B?RGJSdCtTQzc4TzU5V3pQQ01oTldDMHJwRGFLU3N1aUlJM1grTE9TcHc4WnBI?= =?utf-8?B?WXdkZDdCQ09uNlJPSnV1aXRuSVNiRytZakt4eFNDRVlBMys4cmhKcEVCYzha?= =?utf-8?B?Ymx1RjNmUEVGeENiUjRMSitFc0RPZEpYdmhNV2U2Q2tDZHNQVzlrN016QW50?= =?utf-8?B?WEJSd2o5MVNLSFNldUxLWm5rL0xVVTZ5cFFTU1VGZGZUS1czSHdZdHVUMVhP?= =?utf-8?B?djk0clVIQ2E2UVh4Sjk2UzhXVlZGMnBlZUczNXV1Ylk4SFcrNlpBQWc3TDVK?= =?utf-8?B?OEN3empTQ0M3bWEyK2l5Q09KOUg2RkxVOWV6SGpGdis5NXNRaHN1QXU1VFJs?= =?utf-8?Q?Q7VA7WW2qGYD6p15hBDbeO0mCL+8CvruHRhUPDo?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c917bc4b-3952-4e40-d95b-08dac40b37d3 X-MS-Exchange-CrossTenant-AuthSource: GV1SPRMB0038.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 17:36:08.9317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVP250MB0978 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avfilter/af_surround: Check return value of av_tx_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Should fix Coverity issue #1516766. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_surround.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/libavfilter/af_surround.c b/libavfilter/af_surround.c > index 858fed609a..969325cf6b 100644 > --- a/libavfilter/af_surround.c > +++ b/libavfilter/af_surround.c > @@ -194,7 +194,7 @@ static int config_input(AVFilterLink *inlink) > { > AVFilterContext *ctx = inlink->dst; > AudioSurroundContext *s = ctx->priv; > - int ch; > + int ch, err; > > s->rdft = av_calloc(inlink->ch_layout.nb_channels, sizeof(*s->rdft)); > if (!s->rdft) > @@ -204,9 +204,10 @@ static int config_input(AVFilterLink *inlink) > for (ch = 0; ch < inlink->ch_layout.nb_channels; ch++) { > float scale = 1.f; > > - av_tx_init(&s->rdft[ch], &s->tx_fn, AV_TX_FLOAT_RDFT, 0, s->buf_size, &scale, 0); > - if (!s->rdft[ch]) > - return AVERROR(ENOMEM); > + err = av_tx_init(&s->rdft[ch], &s->tx_fn, AV_TX_FLOAT_RDFT, > + 0, s->buf_size, &scale, 0); > + if (err < 0) > + return err; > } > s->input_levels = av_malloc_array(s->nb_in_channels, sizeof(*s->input_levels)); > if (!s->input_levels) > @@ -263,7 +264,7 @@ static int config_output(AVFilterLink *outlink) > { > AVFilterContext *ctx = outlink->src; > AudioSurroundContext *s = ctx->priv; > - int ch; > + int ch, err; > > s->irdft = av_calloc(outlink->ch_layout.nb_channels, sizeof(*s->irdft)); > if (!s->irdft) > @@ -273,9 +274,10 @@ static int config_output(AVFilterLink *outlink) > for (ch = 0; ch < outlink->ch_layout.nb_channels; ch++) { > float iscale = 1.f; > > - av_tx_init(&s->irdft[ch], &s->itx_fn, AV_TX_FLOAT_RDFT, 1, s->buf_size, &iscale, 0); > - if (!s->irdft[ch]) > - return AVERROR(ENOMEM); > + err = av_tx_init(&s->irdft[ch], &s->itx_fn, AV_TX_FLOAT_RDFT, > + 1, s->buf_size, &iscale, 0); > + if (err < 0) > + return err; > } > s->output_levels = av_malloc_array(s->nb_out_channels, sizeof(*s->output_levels)); > if (!s->output_levels) Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".