From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F414E4C0FD for ; Wed, 5 Feb 2025 17:42:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FCE968B654; Wed, 5 Feb 2025 19:42:38 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2059.outbound.protection.outlook.com [40.92.59.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1525680A42 for ; Wed, 5 Feb 2025 19:42:31 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZmqdmWNXj1U220VZMXh7PuIG06LtWNgOygL6XeJ5fMUfh7DjMCr5l93F9cfwkZ9PZ/Egjo7oUJUcVfBCDf/c+kMAqbsid5IHt7Vjsj725SlHefzRSIEpdPkztwb8bBsjZ8hKBvpjNl5ej8wa9CUBiCcnCYQ2TKz0SFlssyOKdODEQ6KFkdyOE/FW3AkWa9dp0VU5lfkoe7WnGlbhKujSgH5bDHooPnCVHe+yMmLXum0EXvifqYYVCveONFL/DpRU1JHJskZcNNUwTkWzf6zsoqXQ0Id6OiBgQetc00Kujb7T6Ik0mEaud2XOncffUhsx8xvKo7jgwm8DP5LpGNHuWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5nJv1L0RbybBAOIHaq/LvS7Joxdoebozu4QPRJ5DIJQ=; b=SF731BKhohWxo+P35JlMX/2S3yLYHaAYgfYl1NnXcjztUzlCMBLjVE5UZNaNV48FYQR+dRKOqNqITVucBzsBZXRfP/l/PpKuAx3cZ0bNFm/raBN1an/cRqufpwaZVkD8c5I0HguAe7mJkyp0+iEw4xtI5zzUBeuxqmiPnHMUvuuGNvzveHyu6aB1LE6JHxQIbbPxTBhzn41F/V7fSLQnfsMBqnsMsen3ZSNXoq/kPc329J6uP+EkMV2yZC7P1fLJPYFAIt6K9SKJQgZF/uaOjOKLjttw5pyAYchVqwR/Ka7aNUB1apfWkf6N/5d2pv+6EON4RL2RD2NCoZq4RxunPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5nJv1L0RbybBAOIHaq/LvS7Joxdoebozu4QPRJ5DIJQ=; b=uuBeFYYwwsjuT8UuaNjWzCxX4/t+g4uVdMz0PbRs1HmqawgQJ67SvjXayjbEi2siOUb7fu+5i423x16UkmJyrmBgi+nbIFBeTomxbYzt7hq/ZvDzwwOyhr0nj7RP843X1jihMLQ/ceOHPKQgUe3FoSQiBJgjGiqtAMJ1mFlBHHtMBUG9CO2f3CVXyMyuOCh8tLJPW6UQ6V2mWB2WvpB09P7QZAegkdQQn6/YQJ6CCMq1Tlf2G0VLuT/t52zeJnovEpQjpP/PUo/eUR/Y75dMbnRiEIDYIgVlwgCvj69OBwPeuzk4KwbDMi8lsqCXj02dH0e9rQW0ikdOqTMlHtg+FA== Received: from GV1SPRMB0036.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8b::16) by AS4P250MB0657.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4bc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 17:42:30 +0000 Received: from GV1SPRMB0036.EURP250.PROD.OUTLOOK.COM ([fe80::2e14:af18:9569:bc54]) by GV1SPRMB0036.EURP250.PROD.OUTLOOK.COM ([fe80::2e14:af18:9569:bc54%4]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 17:42:30 +0000 Message-ID: Date: Wed, 5 Feb 2025 18:42:28 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: FR3P281CA0030.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::16) To GV1SPRMB0036.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8b::16) X-Microsoft-Original-Message-ID: <83d8e5a8-45dc-49a6-bbf9-8a5c2b7722a9@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1SPRMB0036:EE_|AS4P250MB0657:EE_ X-MS-Office365-Filtering-Correlation-Id: 57cc46fa-bd52-4008-54c2-08dd460c767e X-Microsoft-Antispam: BCL:0; ARA:14566002|7092599003|461199028|6090799003|15080799006|8060799006|5072599009|19110799003|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Zy92VTNlaEU0cnRWQkpLWEExSUZTUzhQUUdBKzByYWMyYnNGMGZHbGJqdG5F?= =?utf-8?B?alVFSDI1YXFRRkVIb2xJYk5yYW5ZYVlWUk00L0pCQTdPVGIzRFJlSWFOcnZv?= =?utf-8?B?U1NZdWROZW91RnN3V2U2eTN5SGkyelJkS09VNUlXRzIxNFJyM1VXd2FOaXlx?= =?utf-8?B?Y0oxR0VoY1FjdERNQXQ2aGpVWDRFaHUwT3dPRUM5b0tHTDZFSjdBcmdrb1Nh?= =?utf-8?B?UTIzcUEvUW15WktjbHVIamNWdXVhTXJhQ0gxNFVRTDMyZWpSdWJVc3cxNzE1?= =?utf-8?B?bWNiak5Od2pEKzdlaHRaSFpsZEt6STV5Qmg4c0o3bG1zV21VZ05qcFNEcWdB?= =?utf-8?B?Y3FpYWkrbmZoVFZmczhLRXRXTHpwS09CNzZRQjZMcmlkU2xEcmpsNkthdkZj?= =?utf-8?B?Qzc3U0RRMTRmSG9DYnBhcnhwWDR2OXNGUnNPVzBTZEg1VlN6UWJzYzZyRy9Z?= =?utf-8?B?bDErSjRHZzcyN2d6MW0wbGx1SSs2V2JpTUpVU3p1dHZiS0tiRDBXZUlsNFJS?= =?utf-8?B?d2NPRDliYmgzNnFzcktlQVpnTmw1WFRPbTYwZDF3OFF6SWdDay92UHBvOGdS?= =?utf-8?B?Y1pBT0JvT2tuUlBPSmxJaUF6WlQyQWowbElyRjVzOFZhTXloemJibzRhTGIv?= =?utf-8?B?OVFzejJBU2l5bGtxOFovdS9odldXRUpmdGhCanN4Znp6bUtnSlFEc1BqcU1V?= =?utf-8?B?eWx6cnQrblM5SHJaY1RoS1F3YXQyUi96NEorVTR0dnhCeHZvS2ZmY0lSQTRZ?= =?utf-8?B?OU1EeGhoeWhCNEdlKzNMcjh2TEtKaXFjbHdXUUZHM29tS283L3ZTZTFZbm9J?= =?utf-8?B?bGM0aExvVmkwdWJzL3AxTENvODd1U0RuYzg2NWpSZC9VS1R1TnBKYmc1RDcz?= =?utf-8?B?KzVKcWE0Nm1OV0RDanI2VHU2cEpCSy9FbGM5ek9zTTR0cmNOcXBPUHJQVmpF?= =?utf-8?B?b2NsUkJReVFCem9JWkhWL3llMVFJdmtrdURZQXFkVmYvdGF2KzFaWHJ4VlhP?= =?utf-8?B?Y09GWisvZDRTZTRudXBaa3RjZnBRVStuQ3psK3Y1VGs5YmtPTk54K21VUEwz?= =?utf-8?B?QmZScnRJM2F6QmJJRUZzSFNnYW9FckJtSWo2c20wcEN2VlZRMXhudm1yUXox?= =?utf-8?B?bzdVT0RPUDdlSkFTVmVINTFkTU9wR0NrLy9SdTBiU3RrS0VwR2VmWEdQM1Jt?= =?utf-8?B?VU9uaWp6NkZTRVJrTWtJUE9RVWhFUGdzdXRVNXVxcTNzTTVrckNDcGkvS3V4?= =?utf-8?B?b1F2dlJVdmM1M0tIelI0Ums4M29najZFSkFYUElvT1VTSkpqbVpmZ21nc2g4?= =?utf-8?B?SWJZQ1daT2RheFRjT01iTTBXeW9WOG1abEJTOUYwQTJiT3RUUWp4Q2thdkpS?= =?utf-8?B?U1VWS2lBb0szQU9GTi9JbTdWTUZNZS8ySXhnM0N3Tm9TVUpvWWdTVFlMT2ZW?= =?utf-8?B?YjlNUTdIc0V4UHBFdng4dGtCanFNM0tFMVd3V0hadnlJRUdZNzFCS1gwWGpM?= =?utf-8?Q?CroJsE=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnRXT0RqdTJvSVlXaEZXbGNTUkZIVHlpM2hJNElkZkUxS3U1cExEb0Joa3Ny?= =?utf-8?B?Zm1jMnU5TFBFeXNHN3UrL25ycTM5MW83S3B3bkUyOVYvY3JIaEVCN0F1dWp6?= =?utf-8?B?eXFoM2JTQ0NRSDhzeFBTL2hpVTUvUjJsM1dnSkhwM3A3c1ZLc2tGTUZwY1Ar?= =?utf-8?B?eTBlVGRqTUhFc3pmdk5zakJwbUJzbTlVSU9td2ZvRzFlRW9kemJTbzRlWENs?= =?utf-8?B?MkdxR0Y3aEhxMy9rK01obHVSdnF5RlRDSzUyNkRIdElGVEJSVGtqZ1EwbEtF?= =?utf-8?B?WFZST3htbG5pK09FUy8yRVUrNUU3d3k0aEJRS2FMYVk5TUthQmliT2MxVDFD?= =?utf-8?B?S2hpMmg0SFRQMjZpMllTSTZpOHcwOEZzV0ZaMW12NWx6N0FkckFxbWpVM0pH?= =?utf-8?B?dEl3T0NueWxHRXFEWFl6RHp4MzJDN3Fhd0ZGNkxCZG5QdVdQWUtMVC9GcGFU?= =?utf-8?B?dDNNeVhndlMwaUZPYUJSUllGYW1qSHBxU3NMTUxBTGcyQVROWmZZaXBZakI4?= =?utf-8?B?SE1kK2s4VmVtUU5FK1BEME9OZmxtekdPTGRkT2pDbUxwM2k5Ujl0bHp4S2dX?= =?utf-8?B?TytBeHZBdVMzUml2RmU0N0dSR0c0N3VlLzdLSTY2Ui94MDk4RUsxUTlPd3JL?= =?utf-8?B?d25CeEowVFRIR2tZTUZLSmVkYkJ1a295YmpGUGFsUWlmWmhaYy9CeW9OM1BH?= =?utf-8?B?b2JURjV6SkpZT3cxeHg4SHYxa3FNWWRLbGVyRHhhRWNMS2wxa2xYbnFDU1R0?= =?utf-8?B?SzJVN2ZkcTkwTGlVMko4RXVkdnZibWhLSHpWeWg3RVlvSktTOHlVdk5JcmpD?= =?utf-8?B?SFBoak1PYkRaT0U1Q3VDZ1d0Q3U5ZjN4SVd2elZLbDEzRjlNVXBqTHpHNFp6?= =?utf-8?B?NE03bUg0TFFNSS9PYWRnY1U2dE9tTm16SlFRUlVqYThpVDlsYlo2NmZJTk1D?= =?utf-8?B?R0hkRE03TjhXN0p5N3hpZWJSVnc4UEdGUWhJbU9Cc3RrL1JyUFAwRkhxeFVB?= =?utf-8?B?QjNQMnNSLzJrSHA1dEhialBETDdFaGcwRmJMcHNoakQvUWQzeDJISjhhbmV3?= =?utf-8?B?WkVrbVVIVnRLWHpOQlBjOFh6WUhsdlhCcXRlWGNTQW9lYWtJOG00Z241eEZw?= =?utf-8?B?TTlZSS9UT2VCcXNtUGNyZlV5aTYyOVNReFZHNWMrWG5RZ05ZNDcyS2dBTjgy?= =?utf-8?B?b3BJdVU0WmVjdUsrS1dUektTTmE4NU5LbFczL2N4SU1OKzk0TmRvZFBGRDl5?= =?utf-8?B?elRkdkFUcjlRNlhoaUM1b0JkeGFvRXd2VllQa0pzU3BCT2dkenlsQVdORmRE?= =?utf-8?B?ZjRINFArUnlJMU1ZNzNWL1RrQlpSMm9rNEJYVFpieUJCOUowL1F2NXN3OThx?= =?utf-8?B?VXRDMHF2d1ZOeFZuS2h5OWZxMmRzMHpJc21PT1RuMVoxSlFWYnRBZjkzUCt1?= =?utf-8?B?Yjl4VTdXK3Vnci8rSnY0MkExVTRNcHBoT3RvNTFUQ1NwYU5KTXFTRmlYVGhU?= =?utf-8?B?Q1g2QlgwcnN0a1VJZE9CcUtPZTJYQXZETGhJZldCbXNzKzRCQVV5KytKTGM2?= =?utf-8?B?UE1rRS9PMTkyMVdtVERob3YxZ1FiTlNHWjZ3b2tsaVB6citXREVadFVYd2w3?= =?utf-8?B?UFI1U3JSWTBqZlZkOTFWSXMvN3p4d3ZqaVk1L3hLUzV2STRDeEJ6MTR1N3Qw?= =?utf-8?B?OXF4aUJQZi9KeXE4QUd0eWpBdjFEYldBcEpLc2dMOFpPaHYvdFMyWTFnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57cc46fa-bd52-4008-54c2-08dd460c767e X-MS-Exchange-CrossTenant-AuthSource: GV1SPRMB0036.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 17:42:30.0566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0657 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264: Set FFCodec.pix_fmts field and fix deprecation warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > From: Zhao Zhili > > We can fix deprecation warning by not set p.pix_fmts, and copy > FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). > However, that method requires non-const FFCodec. So I decided to > set pix_fmts and p.pix_fmts both, and disable deprecation warning > explicitly. > --- > libavcodec/libx264.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 409f45fc7d..9b8b32ef4e 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/libx264.c > @@ -1633,7 +1633,10 @@ const FFCodec ff_libx264_encoder = { > .flush = X264_flush, > .close = X264_close, > .defaults = x264_defaults, > + .pix_fmts = pix_fmts_all, > +FF_DISABLE_DEPRECATION_WARNINGS > .p.pix_fmts = pix_fmts_all, > +FF_ENABLE_DEPRECATION_WARNINGS > .color_ranges = AVCOL_RANGE_MPEG | AVCOL_RANGE_JPEG, > .caps_internal = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_AUTO_THREADS > #if X264_BUILD < 158 > @@ -1659,7 +1662,10 @@ const FFCodec ff_libx264rgb_encoder = { > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | > AV_CODEC_CAP_OTHER_THREADS | > AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, > + .pix_fmts = pix_fmts_8bit_rgb, > +FF_DISABLE_DEPRECATION_WARNINGS > .p.pix_fmts = pix_fmts_8bit_rgb, > +FF_ENABLE_DEPRECATION_WARNINGS > .p.priv_class = &rgbclass, > .p.wrapper_name = "libx264", > .priv_data_size = sizeof(X264Context), > @@ -1691,7 +1697,10 @@ const FFCodec ff_libx262_encoder = { > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | > AV_CODEC_CAP_OTHER_THREADS | > AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, > + .pix_fmts = pix_fmts_8bit, > +FF_DISABLE_DEPRECATION_WARNINGS > .p.pix_fmts = pix_fmts_8bit, > +FF_ENABLE_DEPRECATION_WARNINGS > .color_ranges = AVCOL_RANGE_MPEG, > .p.priv_class = &X262_class, > .p.wrapper_name = "libx264", Only Clang emits these deprecation warnings; and IIRC GCC does not support disabling deprecation warnings inside a definition like this (compilation failure). The deprecation warnings can instead be fixed like in fdff1b9cbfd8cf5a9810c29efa4baf13a4786742. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".