From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCHv2 2/4] avcodec/mm: decode partial palette
Date: Thu, 27 Jun 2024 00:15:07 +0200
Message-ID: <GV1SPRMB0034BC56C81AE9F885DC0D3D8FD62@GV1SPRMB0034.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <089793aaa66d4fc39083cfe4332e4b294a144db9.1719439673.git.pross@xvid.org>
Peter Ross:
> Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
?
> ---
> libavcodec/mmvideo.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c
> index 3038d9ea92..933d895f96 100644
> --- a/libavcodec/mmvideo.c
> +++ b/libavcodec/mmvideo.c
> @@ -78,13 +78,10 @@ static av_cold int mm_decode_init(AVCodecContext *avctx)
>
> static void mm_decode_pal(MmContext *s)
> {
> - int i;
> -
> - bytestream2_skip(&s->gb, 4);
> - for (i = 0; i < 128; i++) {
> - s->palette[i] = 0xFFU << 24 | bytestream2_get_be24(&s->gb);
> - s->palette[i+128] = s->palette[i]<<2;
> - }
> + int start = bytestream2_get_le16(&s->gb);
> + int count = bytestream2_get_le16(&s->gb);
> + for (int i = 0; i < count; i++)
> + s->palette[start+i] = 0xFFU << 24 | (bytestream2_get_be24(&s->gb) << 2);
> }
>
> /**
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-26 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 22:08 [FFmpeg-devel] [PATCHv2 1/4] avcodec/mm: set audio pts proportionally to audio offset Peter Ross
2024-06-26 22:08 ` [FFmpeg-devel] [PATCHv2 2/4] avcodec/mm: decode partial palette Peter Ross
2024-06-26 22:15 ` Andreas Rheinhardt [this message]
2024-06-26 22:08 ` [FFmpeg-devel] [PATCHv2 3/4] avcodec/mm: don't fail if x offset exceeds frame width Peter Ross
2024-06-26 22:09 ` [FFmpeg-devel] [PATCHv2 4/4] avcodec/mm: decode raw chunk type and skip unknown audio chunk type Peter Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1SPRMB0034BC56C81AE9F885DC0D3D8FD62@GV1SPRMB0034.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git