From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevcdec: do not call export_stream_params_from_sei() in update_thread_context()
Date: Wed, 26 Jun 2024 18:13:44 +0200
Message-ID: <GV1SPRMB00346A7301FDC16B4194005B8FD62@GV1SPRMB0034.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240626124337.14478-2-anton@khirnov.net>
Anton Khirnov:
> It is redundant, since it only sets AVCodecContext fields that are
> already copied by the generic code.
> ---
> libavcodec/hevc/hevcdec.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c
> index e80f2f28c7..4a62170073 100644
> --- a/libavcodec/hevc/hevcdec.c
> +++ b/libavcodec/hevc/hevcdec.c
> @@ -3637,10 +3637,6 @@ static int hevc_update_thread_context(AVCodecContext *dst,
> s->sei.common.content_light = s0->sei.common.content_light;
> s->sei.common.aom_film_grain = s0->sei.common.aom_film_grain;
>
> - ret = export_stream_params_from_sei(s);
> - if (ret < 0)
> - return ret;
> -
> return 0;
> }
> #endif
Won't this simply reopen ticket #8610 (when only patches 1+2 are applied)?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-26 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 12:43 [FFmpeg-devel] [PATCH 1/5] lavc/hevcdec: call export_stream_params_from_sei() before ff_get_buffer() Anton Khirnov
2024-06-26 12:43 ` [FFmpeg-devel] [PATCH 2/5] lavc/hevcdec: do not call export_stream_params_from_sei() in update_thread_context() Anton Khirnov
2024-06-26 16:13 ` Andreas Rheinhardt [this message]
2024-06-26 16:23 ` Anton Khirnov
2024-06-26 12:43 ` [FFmpeg-devel] [PATCH 3/5] lavc/hevcdec: do not pass a pixel format to set_sps() Anton Khirnov
2024-06-26 12:43 ` [FFmpeg-devel] [PATCH 4/5] lavc/hevcdec: move export_stream_params() from set_sps() to hevc_frame_start() Anton Khirnov
2024-06-26 12:43 ` [FFmpeg-devel] [PATCH 5/5] lavc/hevcdec: improve check for PPS changing between slices Anton Khirnov
2024-06-26 15:45 ` Frank Plowman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1SPRMB00346A7301FDC16B4194005B8FD62@GV1SPRMB0034.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git