From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avutil/x86/pixelutils: Empty MMX state in ff_pixelutils_sad_8x8_mmxext
Date: Wed, 1 Nov 2023 12:23:33 +0100
Message-ID: <GV1SPRMB00334AB9ADBDA4C2F43B20678FA7A@GV1SPRMB0033.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAFGUN0rqqEQgOavFKFOp3eUFn_erZUMw9Wu+jvHBjvXU6YRKaQ@mail.gmail.com>
Henrik Gramner via ffmpeg-devel:
> On Wed, Nov 1, 2023 at 10:44 AM Andreas Rheinhardt
> <andreas.rheinhardt@outlook.com> wrote:
>> libavutil/x86/pixelutils.asm | 1 +
>> 1 file changed, 1 insertion(+)
>
> IIRC the emms instructions is quite slow on many systems, so if this
> is the only pixelutils function using mmx it's probably better to just
> rewrite it to use SSE2 instead (even if that means only using the
> lower half of xmm registers).
Fixing it by rewriting it in a way that avoids MMX altogether is
possible, but this doesn't change the fact that all public functions
absolutely need to abide by the ABI.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-01 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 9:45 Andreas Rheinhardt
2023-11-01 9:48 ` [FFmpeg-devel] [PATCH 2/4] avfilter/vf_mpdecimate: Remove emms_c Andreas Rheinhardt
2023-11-01 9:48 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_deshake: Remove unnecessary emms_c Andreas Rheinhardt
2023-11-01 9:48 ` [FFmpeg-devel] [PATCH 4/4] avfilter/deshake: Merge header into its only user Andreas Rheinhardt
2023-11-01 11:02 ` [FFmpeg-devel] [PATCH 1/4] avutil/x86/pixelutils: Empty MMX state in ff_pixelutils_sad_8x8_mmxext Henrik Gramner via ffmpeg-devel
2023-11-01 11:23 ` Andreas Rheinhardt [this message]
2023-11-03 11:15 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1SPRMB00334AB9ADBDA4C2F43B20678FA7A@GV1SPRMB0033.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git