From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40B7A449EB for ; Wed, 28 Sep 2022 21:59:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A40D68BC2B; Thu, 29 Sep 2022 00:59:55 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2024.outbound.protection.outlook.com [40.92.90.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3AA268BBC1 for ; Thu, 29 Sep 2022 00:59:48 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gHwXFgdPdosskBaFOFST0wdenvmppep56iP0bHKu5bo6fvpgLysKFo+3sKtk4gBaUyur9y2kbZScan6bXo3M2DdAYKP8haC+ZPHiHZhJCyAG1Uad85bFfT0a96wmtaxb8QefHdouiyd7MmrNKE1aytb/mh+kIfcz72F2RKS8NvvZ3kD1b4autaxUmBq3Smw4QQZNC8/xDukpLfVV1HKPzdN/ladBmSn+Kv1GtuAyUZI5fASg56e8LAvEYiHT5zCb2TALf8gbC0iu76Sn4wiHB1e2cfzh7Dwqabc7QwyO3D3dl2PiZntrjn3dEZ6ZrOcsLVx2LYAay/xRCQbYZZtR6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RqbkC5KqbLoc00OIML6AZC1A9iACja4CXsi34sMb7Fc=; b=NH1kVzRYGqS3uq7eQuusMar5DbHDx+iY7RzW35mX30J9FnQh3hpFUZySKQzti2WE69ZPgxLetniqbhkh7YJ1/NawS7nOr0/+EgSO6E7iPwHXUEgMg/PXmvp6ta9+tsxT0pq6M9hcSAaTeDb4O0e1OMeWnI4FGCGENx5AI+g0U3oRqIgwyk2RrrF0x7FappDnEFNS+/wTMFnADV2xRtsE2QEodyTDeVEE1janW8cjhhRk/XMHEq3yYJcWAplyaFMFcYill1tfqN6bnMVbvsJwUL4tScPjCKN3B7P6zb1eebxPqhtBVR6hPfh7xLsrRt/fNvyO5jR89Gr9tuLGvjLGmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RqbkC5KqbLoc00OIML6AZC1A9iACja4CXsi34sMb7Fc=; b=Jt3LoEyWLF1kfPoKzxNqvMp11f5HmBP+MYdklDr8uMi+9q4c3VgI4G5nkb85wxr2Hdk4MCQ14a3PjaGml71dQBvQkNG0uZGRVot4RHSHElEf/ygooRWA4fFprkmbTNLE9Q1zQosL0A1jrspRIzwocIq687ohjMSx4QSvT0QPVNT/3q0RDa2sAz4Jjued6TQKOFQozVed013tXw9N9ZbyA4BsL8GphzmGbmb4x3aAal9J8FiTs5kTbTmCY+Zwv6TjAJ2I/a2IvR55XL7eTSKrVVK97AO677ETAGFLwuJuTQl+PRTct+84dZt0zROKFd2t8sD1eX2wPxG3y4nOmOuHSA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB4P250MB0734.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:37a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 21:59:46 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8%9]) with mapi id 15.20.5654.025; Wed, 28 Sep 2022 21:59:45 +0000 Message-ID: Date: Wed, 28 Sep 2022 23:59:50 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [S55iGy4jZNz5A7NgU8Ehp3qjxQlHzneb3hQeMxqIwlc=] X-ClientProxiedBy: ZR0P278CA0176.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::21) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB4P250MB0734:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e3b00ed-0375-42ce-4d9e-08daa19cc0f5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pG0y00r+bMUgR1YMGFOTblvLwxY7MWD9ZB5NSu5Y1Hm4xCD3GFDlirNiUMEYmBRX1W9wCxKvb3LlBajhuvg7H5krpVviYnYDVJD2025ipUE2ICyALj4STRLbS28vv5W7R47Pr/EDkdkO4LWarKnmaSMbel42DxddDUOxgIzdbcMwYEs3Dijg7oZKQ+7jUOqkch7x3YYGT/ey4jGNDIMXbEkBFjnEkgUdRX94Ee2FcSZteoXjSTSsBeEfe/EPTKJCAiz/WcZ8t9DB/+D++Fiag66c6NwObqYPpKDDq5EUFErZXOVbbULISfE0M33h9304NxH3xaF29CL7IwKIuxZXzCcbRsInoAIz6WUdf6yGYVRdgO0RX+wL7jGlaV8SBY92vZ8kQjlugMpe2Ua/3gyHRY9Xq9IW5XzOGVehQ9bI0mxUyLsuJwzKu70jXLS1SfW63jP9hi+w1fnWcdBMJ4T0GSrEneWgd4jCWkYE8/BGT88o7/rgANCFUnNsS2ctEYmfJQ91qNlVhcxq4kkj+cAoZp4J23S+eWjDXXx8CzINzkRGJSRWOIyN5XeCV9JxmAfXfnGc1WJknQagqjfmPvU9t4ZJ9jrafVo4Tvbsh1EcAccmHYf0wlQr11dX5I4Lt4C9Xfzhvz6cpT7IE9ztRsTMBuQb5e+u/rXvPEylyLh4gAx0Jg1rtiU3jwvPoT3N8Ai+ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlE0SDkzVm5UdFVLUlZpREgyRGg3Smt6ei9QckVFeHFUUk9uRTdwSWp1MmJB?= =?utf-8?B?d3hUWmZnRjByL3dFRmROajFiNW1vVGJ2dFRZV2pzeU5wNzVxcGg2cFg1dTV2?= =?utf-8?B?b0E4WmVCU3NHUEJKQ0g3NlNhUU8zbC9YVmJONkZnZ083MjV5c3RDbXIrYWUw?= =?utf-8?B?aS9jK0sraWV5akNuQzZhTzZZMk9ETEtmZUVoYi9pYnZCVXE4aC9weWpucjN4?= =?utf-8?B?eW5DcGUyd3lrK0J5TzgzTkw5Q1o4a3RzdERMZmE1Q0FZeUJJTEppdHFYYVRB?= =?utf-8?B?ZUZ0bk93MmZLNFlOSFNWdmVxd28vR3ZNWklLTzNaUVJJTmtJUEt0ZGE2MWtM?= =?utf-8?B?ZzhSTEVVTFZkTHNPZWVTSE1kY3psbldORlRpVWFqUm5hTWZpSXhkcStkeHd0?= =?utf-8?B?ejZua1ZmTlp1UmNYUUl1Rm1iUlEvV25Sak5hYXI2THJkVnV3TkVYSHR2Mm5V?= =?utf-8?B?ZEJxeDRIazMxeGtLL0x2Q0xzTlFzbldFcVVqMGErU1oydlAyWmpSWm5ZMTYv?= =?utf-8?B?WlZSS3pneWpKMnlCZEszZllkNTJqcHFoT1J1djFPVURwMUU3KzV1dmtqdk5K?= =?utf-8?B?czZ4YVNuWXUxNlFmdVJqVXpXZHBnZFU2VHU1TG9UZkxYY3lDWjc0bFl2ekRJ?= =?utf-8?B?a3lueHRmSC9IUEdIMEZ6V1ZDZ1pNMUpveEZ4MnRtTHh6eWZLbDFoOEdoOUxY?= =?utf-8?B?TEZaZndWUkQ2dHkvdndBbkdZemNBM2VQc0tEbk9CUTRLbkxja1Q0ekx6TXdo?= =?utf-8?B?RDE5Y2N4Q3lVMHAyY3hjVHRGRkZjQzNBblpJYUxMckhQUi93UzcrZE8wUHR2?= =?utf-8?B?cmg1eFpucXZQTG52NU13M1E4dVNrRzVPa0loMHFrbG1MU2pXYi9qK1lINzN5?= =?utf-8?B?VmEzWmN1Z2Q0RU5GcVlkWWZ6VzliYzBYMU1yYzFoLzdlaGJtUnZSUkhWbTNk?= =?utf-8?B?WFplTE5wYzJwVmNFekZ4V3M1dzU4aTc1c01DMzZSN3BHbEkrL0dRRndIeFc1?= =?utf-8?B?MEtHTFhNOXNZQXVqNVdjQWhSc0N0UGh1alNjbFhxNTNHd2t3empkTUFZajdO?= =?utf-8?B?eU1vSUpDMllmZEpDTUNpSUpNcm9nNmk2SE42NGZoOUFMc2tmcEl2WjVUc0Zt?= =?utf-8?B?bzhCYy8yQnhGaGFMcXo0RmZBN0hEbm5Tc2NZMGs0alIvOElsYkVjMmRrM29H?= =?utf-8?B?OS9DTnVuQTA0S0dHZjNNeFZoV1FwRG1NWjh0SU9Ga0MxOFVzeVFZK0hYZk82?= =?utf-8?B?MXptdGU0K0lTYWNxZmd3eU1nSyswLytITEhISW9aaE5KZUJFY290VVpUL2FT?= =?utf-8?B?U2h3d2ZEUmJrUGd5OTdQK1orRVRZOC9GcDQxUXJTL1Q3eDFrNC9OZ1hRdzdl?= =?utf-8?B?SWNrSDVhUkdkZ0RVWHN2bE5zTkpkS215N3BZMGJ3MkdvL0lQeURINGV6YmhU?= =?utf-8?B?SVU1YmM4TmFZVUZEUXhFTUNUeWdtUmd2SHBBRTJ0dDREVjhldk5yWG1EZ3dx?= =?utf-8?B?dmhOZFgzTWtaNFY2OEZScG1UWHYzVDNNK0sydVZTUWVNbC9UVGZna3lPSnl6?= =?utf-8?B?TGQ2eWkxQWF4S293RVhpMjRKVms5aGVHQ0djaWVkQTRaSFQ2N1Z1Z0NZSWZC?= =?utf-8?B?aG1NQ0JSZDZTVTh3aHhLNDV0Z1hVQWNHb2d3NzVNeFpyb3JXUjI1U1l2T3ND?= =?utf-8?B?bkJlZlVwOFBEOGtZbVJIYmkwZzlRaVBCbTFCSmFZQTBPdTRmd0ZwNnZiUjNS?= =?utf-8?Q?Vnffxd8xOKBrzRG9f2aoUbSY1gQ+ewit6mq2mKg?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3b00ed-0375-42ce-4d9e-08daa19cc0f5 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 21:59:45.2493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4P250MB0734 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ac3dsp: Remove unused parameter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Forgotten in fd98594a8831ce037a495b6d7e090bd8f81e83a1. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ac3dec.c | 2 +- > libavcodec/ac3dsp.c | 8 ++++---- > libavcodec/ac3dsp.h | 8 ++++---- > libavcodec/ac3enc.c | 2 +- > libavcodec/arm/ac3dsp_init_arm.c | 2 +- > libavcodec/mips/ac3dsp_mips.c | 3 ++- > libavcodec/x86/ac3dsp_init.c | 2 +- > 7 files changed, 14 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index aba8e0fb7f..340f6e1e37 100644 > --- a/libavcodec/ac3dec.c > +++ b/libavcodec/ac3dec.c > @@ -236,7 +236,7 @@ static av_cold int ac3_decode_init(AVCodecContext *avctx) > if (!s->fdsp) > return AVERROR(ENOMEM); > > - ff_ac3dsp_init(&s->ac3dsp, avctx->flags & AV_CODEC_FLAG_BITEXACT); > + ff_ac3dsp_init(&s->ac3dsp); > av_lfg_init(&s->dith_state, 0); > > if (USE_FIXED) > diff --git a/libavcodec/ac3dsp.c b/libavcodec/ac3dsp.c > index afd6b557bf..22cb5f242e 100644 > --- a/libavcodec/ac3dsp.c > +++ b/libavcodec/ac3dsp.c > @@ -374,7 +374,7 @@ void ff_ac3dsp_downmix(AC3DSPContext *c, float **samples, float **matrix, > ac3_downmix_c(samples, matrix, out_ch, in_ch, len); > } > > -av_cold void ff_ac3dsp_init(AC3DSPContext *c, int bit_exact) > +av_cold void ff_ac3dsp_init(AC3DSPContext *c) > { > c->ac3_exponent_min = ac3_exponent_min_c; > c->float_to_fixed24 = float_to_fixed24_c; > @@ -390,10 +390,10 @@ av_cold void ff_ac3dsp_init(AC3DSPContext *c, int bit_exact) > c->downmix_fixed = NULL; > > #if ARCH_ARM > - ff_ac3dsp_init_arm(c, bit_exact); > + ff_ac3dsp_init_arm(c); > #elif ARCH_X86 > - ff_ac3dsp_init_x86(c, bit_exact); > + ff_ac3dsp_init_x86(c); > #elif ARCH_MIPS > - ff_ac3dsp_init_mips(c, bit_exact); > + ff_ac3dsp_init_mips(c); > #endif > } > diff --git a/libavcodec/ac3dsp.h b/libavcodec/ac3dsp.h > index a23b11526e..33e51e202e 100644 > --- a/libavcodec/ac3dsp.h > +++ b/libavcodec/ac3dsp.h > @@ -105,10 +105,10 @@ typedef struct AC3DSPContext { > void (*downmix_fixed)(int32_t **samples, int16_t **matrix, int len); > } AC3DSPContext; > > -void ff_ac3dsp_init (AC3DSPContext *c, int bit_exact); > -void ff_ac3dsp_init_arm(AC3DSPContext *c, int bit_exact); > -void ff_ac3dsp_init_x86(AC3DSPContext *c, int bit_exact); > -void ff_ac3dsp_init_mips(AC3DSPContext *c, int bit_exact); > +void ff_ac3dsp_init (AC3DSPContext *c); > +void ff_ac3dsp_init_arm(AC3DSPContext *c); > +void ff_ac3dsp_init_x86(AC3DSPContext *c); > +void ff_ac3dsp_init_mips(AC3DSPContext *c); > > void ff_ac3dsp_downmix(AC3DSPContext *c, float **samples, float **matrix, > int out_ch, int in_ch, int len); > diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c > index a090576823..279dd5c20e 100644 > --- a/libavcodec/ac3enc.c > +++ b/libavcodec/ac3enc.c > @@ -2613,7 +2613,7 @@ av_cold int ff_ac3_encode_init(AVCodecContext *avctx) > > ff_audiodsp_init(&s->adsp); > ff_me_cmp_init(&s->mecc, avctx); > - ff_ac3dsp_init(&s->ac3dsp, avctx->flags & AV_CODEC_FLAG_BITEXACT); > + ff_ac3dsp_init(&s->ac3dsp); > > dprint_options(s); > > diff --git a/libavcodec/arm/ac3dsp_init_arm.c b/libavcodec/arm/ac3dsp_init_arm.c > index 9217a7d0c2..a64aa6ae82 100644 > --- a/libavcodec/arm/ac3dsp_init_arm.c > +++ b/libavcodec/arm/ac3dsp_init_arm.c > @@ -44,7 +44,7 @@ void ff_ac3_bit_alloc_calc_bap_armv6(int16_t *mask, int16_t *psd, > > void ff_ac3_update_bap_counts_arm(uint16_t mant_cnt[16], uint8_t *bap, int len); > > -av_cold void ff_ac3dsp_init_arm(AC3DSPContext *c, int bit_exact) > +av_cold void ff_ac3dsp_init_arm(AC3DSPContext *c) > { > int cpu_flags = av_get_cpu_flags(); > > diff --git a/libavcodec/mips/ac3dsp_mips.c b/libavcodec/mips/ac3dsp_mips.c > index 8f62c03aaf..a5eaaf8eb2 100644 > --- a/libavcodec/mips/ac3dsp_mips.c > +++ b/libavcodec/mips/ac3dsp_mips.c > @@ -401,7 +401,8 @@ static void ac3_downmix_mips(float **samples, float (*matrix)[2], > #endif /* HAVE_MIPSFPU */ > #endif /* HAVE_INLINE_ASM */ > > -void ff_ac3dsp_init_mips(AC3DSPContext *c, int bit_exact) { > +void ff_ac3dsp_init_mips(AC3DSPContext *c) > +{ > #if HAVE_INLINE_ASM > #if HAVE_MIPSDSP > c->bit_alloc_calc_bap = ac3_bit_alloc_calc_bap_mips; > diff --git a/libavcodec/x86/ac3dsp_init.c b/libavcodec/x86/ac3dsp_init.c > index 75a341bc95..43b3b4ac85 100644 > --- a/libavcodec/x86/ac3dsp_init.c > +++ b/libavcodec/x86/ac3dsp_init.c > @@ -33,7 +33,7 @@ int ff_ac3_compute_mantissa_size_sse2(uint16_t mant_cnt[6][16]); > void ff_ac3_extract_exponents_sse2 (uint8_t *exp, int32_t *coef, int nb_coefs); > void ff_ac3_extract_exponents_ssse3(uint8_t *exp, int32_t *coef, int nb_coefs); > > -av_cold void ff_ac3dsp_init_x86(AC3DSPContext *c, int bit_exact) > +av_cold void ff_ac3dsp_init_x86(AC3DSPContext *c) > { > int cpu_flags = av_get_cpu_flags(); > Will apply this patch later tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".