Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 6/7] avcodec/dsd: Hoist branch out of loop
Date: Tue,  2 Apr 2024 03:37:07 +0200
Message-ID: <GV1P250MB0737FD45A2FEB3E6D28CEE3E8F3E2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737D9E8D64211A49774E5828F3E2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

This is possible by not converting from LSBF to MSBF; instead
add LSBF LUTs.
This approach necessitates reversing the initial values.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/dsd.c    | 12 ++++++++----
 libavcodec/dsddec.c |  3 ++-
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/libavcodec/dsd.c b/libavcodec/dsd.c
index ec63a706f6..1093c5e2dd 100644
--- a/libavcodec/dsd.c
+++ b/libavcodec/dsd.c
@@ -68,7 +68,8 @@ static const double htaps[HTAPS] = {
      3.423230509967409e-07,  1.244182214744588e-07,  3.130441005359396e-08
 };
 
-static double ctables[CTABLES][256];
+static double ctables_lsbf[CTABLES][256];
+static double ctables_msbf[CTABLES][256];
 
 static av_cold void dsd_ctables_tableinit(void)
 {
@@ -81,8 +82,10 @@ static av_cold void dsd_ctables_tableinit(void)
             for (t = 0; t < CTABLES; ++t)
                 acc[t] += sign * htaps[t * 8 + m];
         }
-        for (t = 0; t < CTABLES; ++t)
-            ctables[CTABLES - 1 - t][e] = acc[t];
+        for (t = 0; t < CTABLES; ++t) {
+            ctables_msbf[CTABLES - 1 - t][e] = acc[t];
+            ctables_lsbf[CTABLES - 1 - t][ff_reverse[e]] = acc[t];
+        }
     }
 }
 
@@ -100,13 +103,14 @@ void ff_dsd2pcm_translate(DSDContext* s, size_t samples, int lsbf,
     unsigned pos, i;
     uint8_t* p;
     double sum;
+    const double (*const ctables)[256] = lsbf ? ctables_lsbf : ctables_msbf;
 
     pos = s->pos;
 
     memcpy(buf, s->buf, sizeof(buf));
 
     while (samples-- > 0) {
-        buf[pos] = lsbf ? ff_reverse[*src] : *src;
+        buf[pos] = *src;
         src += src_stride;
 
         p = buf + ((pos - CTABLES) & FIFOMASK);
diff --git a/libavcodec/dsddec.c b/libavcodec/dsddec.c
index 2bb2e73b75..dd1ea83784 100644
--- a/libavcodec/dsddec.c
+++ b/libavcodec/dsddec.c
@@ -56,7 +56,8 @@ static av_cold int decode_init(AVCodecContext *avctx)
     if (!s)
         return AVERROR(ENOMEM);
 
-    silence = DSD_SILENCE;
+    silence = avctx->codec_id == AV_CODEC_ID_DSD_LSBF_PLANAR ||
+              avctx->codec_id == AV_CODEC_ID_DSD_LSBF ? DSD_SILENCE_REVERSED : DSD_SILENCE;
     for (i = 0; i < avctx->ch_layout.nb_channels; i++) {
         s[i].pos = 0;
         memset(s[i].buf, silence, sizeof(s[i].buf));
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-04-02  1:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02  1:35 [FFmpeg-devel] [PATCH 1/7] avcodec/wavpack: Fix leak and segfault on reallocation error Andreas Rheinhardt
2024-04-02  1:37 ` [FFmpeg-devel] [PATCH 2/7] avcodec/dsd: Use double for LUTs Andreas Rheinhardt
2024-04-02  1:37 ` [FFmpeg-devel] [PATCH 3/7] fate/wavpack: Add test for DSD Andreas Rheinhardt
2024-04-02  1:37 ` [FFmpeg-devel] [PATCH 4/7] avcodec/wavpack: Only initialize DSD data when encountering DSD Andreas Rheinhardt
2024-04-02  1:37 ` [FFmpeg-devel] [PATCH 5/7] avcodec/dsddec: Fix decoding LSBF samples Andreas Rheinhardt
2024-04-02  7:21   ` Peter Ross
2024-04-02 10:16     ` Andreas Rheinhardt
2024-04-02  1:37 ` Andreas Rheinhardt [this message]
2024-04-02  1:37 ` [FFmpeg-devel] [PATCH 7/7] avcodec/wavpack: Remove always-false check Andreas Rheinhardt
2024-04-03 22:07 ` [FFmpeg-devel] [PATCH 1/7] avcodec/wavpack: Fix leak and segfault on reallocation error Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB0737FD45A2FEB3E6D28CEE3E8F3E2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git