From 709443e00fb342aaf2263c78e755dfde3c90f22d Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Date: Fri, 18 Apr 2025 13:02:47 +0200 Subject: [PATCH 06/13] avcodec/cbs: Use put_bits63() It is better when BUF_BITS == 64 (i.e. on x64), because the underlying put_bits can then handle 0..63 bits naturally. It does not worsen the code when BUF_BITS != 64, because the compiler can optimize this to the same code as now (due to the assert). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/cbs.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index ba1034a72e..398d286a92 100644 --- a/libavcodec/cbs.c +++ b/libavcodec/cbs.c @@ -674,10 +674,7 @@ int CBS_FUNC(write_unsigned)(CodedBitstreamContext *ctx, PutBitContext *pbc, if (put_bits_left(pbc) < width) return AVERROR(ENOSPC); - if (width < 32) - put_bits(pbc, width, value); - else - put_bits32(pbc, value); + put_bits63(pbc, width, value); CBS_TRACE_WRITE_END(); @@ -746,10 +743,7 @@ int CBS_FUNC(write_signed)(CodedBitstreamContext *ctx, PutBitContext *pbc, if (put_bits_left(pbc) < width) return AVERROR(ENOSPC); - if (width < 32) - put_sbits(pbc, width, value); - else - put_bits32(pbc, value); + put_bits63(pbc, width, zero_extend(value, width)); CBS_TRACE_WRITE_END(); -- 2.45.2