[FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault

[FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault

[Armin Hasitzka via ffmpeg-devel]

[-- Attachment #1: Type: text/plain, Size: 72 bytes --]

Hi,

we found this when testing with rejected RTMP streams.

Best
Armin

[-- Attachment #2: 0001-avformat-rtmpproto-Fix-segfault.patch --]
[-- Type: application/octet-stream, Size: 793 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault

[Andreas Rheinhardt]

Armin Hasitzka via ffmpeg-devel:
> Hi,
> 
> we found this when testing with rejected RTMP streams.
> 
> Best
> Armin

Thanks for the report and the patch; yet actually freeing them manually
is not only harmful, but also unnecessary, as these strings can be set
via AVOptions; therefore they will be freed generically (which is also
the reason why rtmp_close() does not have code to free them). I sent a
patch for this here:
https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/324509.html Would
be nice if you could test it.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault

[Armin Hasitzka via ffmpeg-devel]

Ooooh interesting, I see (makes a lot of sense)! I can confirm, btw; your
updated fix (from 324509) works for me (no segfault + clean shutdown)! ...
I will comment on the other thread as soon as the email comes through!

Thanks a lot!
Armin

On Wed, 27 Mar 2024 at 18:21, Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Armin Hasitzka via ffmpeg-devel:
> > Hi,
> >
> > we found this when testing with rejected RTMP streams.
> >
> > Best
> > Armin
>
> Thanks for the report and the patch; yet actually freeing them manually
> is not only harmful, but also unnecessary, as these strings can be set
> via AVOptions; therefore they will be freed generically (which is also
> the reason why rtmp_close() does not have code to free them). I sent a
> patch for this here:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/324509.html Would
> be nice if you could test it.
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".