From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3D0E14B428 for ; Wed, 5 Jun 2024 13:23:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02A9968D6A6; Wed, 5 Jun 2024 16:23:06 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2088.outbound.protection.outlook.com [40.92.65.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8490A68D52A for ; Wed, 5 Jun 2024 16:22:59 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUezefH1LDYD/a0CYQWCeBnyl+1UXDP97KqlSMJZS9hrZVTr5YINDW4sUa2tQFQzVXXBI3vNaL8VZR8kDcMlL3cTfgp1VveJ2rKXm1Ax1ofXg2THlPZefkgXEc+txprqQukB/1/fVxFQ4vz88VVxWIxOU+MHBf19QNgHSnrFsAOL/EBLELjiXt5X+bBCruPHZPmiGh54Hcin2GHlg/F7Dfu9jfcFDhBAw6IvDDWmyRnqdc9YV9ksWogbqJyeXw8Q4XwRyFT3Pc2F1tASmSbM+bsInngSsEE3WIVdu5DpK2tp5Gs7P93IUsYUH+ESHfowN4Mx5sJLCU3EV+Moi0l4Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5mQFI1aBuKZOaClBaSxv2JYjeihJE7W326z52XhePhw=; b=Bql6UXz8VQAyUxXDBv0KNk8s3HVUNO9bKp5zcPfCiFMHgcdjs24RRPb4GV78j70e7dZDwRFw1Wz+zooxVn+7pee/IUu0TYiKuUaESPRUey52eAB9HrZWRsGFyJKXJJq0uFCLveA36hLM1dg7HPdXTnzg20eUT5rxqNsnXig/Tng9DfFQjdxGhOvWlkUcFukJNdQtuNAtEL4NeeSXLZ0JeR7J8H5ebKT6GaHxFwhiVuHAOt14ml6ZL4cyn+SlEg1xKW3EGxzxP57Vr+ivPp4NcRTpwrRc5uDNb61Fkypknt1T//x4M0KPu81wKwx4oAPiJOpVUqELvgvca39fHJUUOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5mQFI1aBuKZOaClBaSxv2JYjeihJE7W326z52XhePhw=; b=FYtjK8o+oJdjZmNtHV4skuTOvX/dP71YLTwLJmOSUChQd99YuwLnkV6uGQKuQqBJKbDuYM8lyumETU5hipA38vm1xsxpZwHBSEo2RzxCtSp7WroTqrN1eDjmG4xUqx4lNBd7vCAV/XhDXz1IFKs+UcRuVl0ZX+WhdqG01wQ4tvJjqEONVIaGIYkiIDEekIVi/0wI91D7avhjOSUwubn7GPjRj1pk58lpmAEMmyyJlHC/Vo2xTe8XhHFjq0bwZVMWqwqoL2BoK7W+7BipAgxXx49ZOMdHXIR5LeDa8n7tTGeoTi7x1Jib11ki8zc4xqkW7d5BWP4M3biU4hebB2MZPA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0358.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Wed, 5 Jun 2024 13:22:56 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%4]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 13:22:56 +0000 Message-ID: Date: Wed, 5 Jun 2024 15:22:55 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240604222835.166462-1-marcus@marcusspencer.xyz> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [vh+7GhFRbpqcodmHihuM9S+fNubfIkob2YChf/YmR8M=] X-ClientProxiedBy: FR2P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::11) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <579073d8-a96f-4746-be23-93cbf267665c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0358:EE_ X-MS-Office365-Filtering-Correlation-Id: 018a85c8-0a5a-44d0-0ac7-08dc85629cd9 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: L+zSBhBEW7vqx9rz7KEdLKWiFuHRo34CB9ODHakPiribEfGkCXQYeR/Qam43Xf0uiWqx6GKpDr69u9uomzi+EmlKeHZtsxC5hXWAQTZNhJGO5vgjf9RIKdFN+2EXWN+33I4D+ErgK8ILtOytwFxuQunOV+wsQapxhMzQYUq99yzU3qCztCjQVQ1I2m0DOAQ65oEwJFy85ZcLLPYvVPluHKyTaicUE3yDGuIVVw8dgmy12rLN4lvb1o4qspmNz0I1x6KhJ2zPTe6VvhnRSmnWWjevmQ/mUvaeoErPH75re1YqbnDlO3sxgftFYwneb0V+iXEiCdlDOZABWvr2I0c/lwUBPmnn9EhT9NjOo9aHbuii2H2b1EUHyd//d4YOgThiRzsOxb90OfOoVtz2Ri/G5c3pTfmNxtAUTICkwJl76glBARP9mBscNiK5+pVmb5+/ph7EP6+zeOjppojF6ti0oGnSMrBlF950F4iMoQpsHzlOy28I0xW5cL0TGyuTx5vyAPFDNuJ04Xt74UxQPJZ0SgRF9SvUgomIMj0ltnx7szdCA+JJQkKpT5E5M5hTlbLu X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a294QzZjTWhiZTV3UVJONWtNdXMxZlgzVkFscXUvcFc1cGl4MlJCeVM4M21p?= =?utf-8?B?UHhxaVQ3U3FzbnFqbDM1OU03VU1EQVVzT0tlUWFESGsxOSs2NnpWa0V0TUxy?= =?utf-8?B?V2ZHRjVWMzg3Q21EaTVKamMwN1RLMEU4cklPdFJIRWliY3dKREkzbk9LVVNK?= =?utf-8?B?ZDBKOVlFVnJtczZzcjhVak5EM1dwMWg5V3B3RkVmZmc4OWJsczdXRGtTTFVP?= =?utf-8?B?QXVIY1FPM25ZcVp0TE1WL29jU3Jrd0tjc2FrYXBCYjk2UVRyTkpSam92NWlZ?= =?utf-8?B?M2xZdnVveUtyK0VmNmRzQlgyRWxtR0R2anVwbXB4Q1phSjdVTTh3dElrSzdF?= =?utf-8?B?Yy9LUEMybEZzdDIxbGpIbk1SSUtXUVc2MEJsbCtnNWI0ZkhaMm0wV2oraHoz?= =?utf-8?B?TEx3ZHF3R3ZhTDN5N1J0Szd2OHJlYXZiVmFOUDB5Y2grOVlYd1Z0QmNIRGJL?= =?utf-8?B?UjZ6YTRJZjZXQ0tDdTdzdGVVS1lCcnJUaE5XVGVtYjhSYUwrM2dibEdHVlpr?= =?utf-8?B?ZDNwakFZUjBSQXo5MWtGVlJnYkwvcEJiTS9lQ1lWZlBQaGI4aFFuVDlsUnlI?= =?utf-8?B?N016SjBIMUdrSC9adEV5RnBXNUh6UWdMNXorTkF0UzhqVmhDNVBzOTNPeXVU?= =?utf-8?B?SkNvU1lXNExtRWhCOHFYVjYrRWlRZEZTZi9WQi84UDN6VDRDdXJIT25kditN?= =?utf-8?B?NEJReEJ5Yk4rTXpTTTAwcXNSQ1JGSFVsVUtQYzl6QitDbDhMcWpMeUxSRFVy?= =?utf-8?B?WWdYZFJZcFppc1NkeCszSWYyQW04ek1wOXVteFdyQnZzdEJPR0ROVnBERUVl?= =?utf-8?B?TGFHUjNzbzBRVWtrYldlaVphSVNxQnpJaXhyU1JhSUJ1a0ExTVFtcGZrNVJy?= =?utf-8?B?UFBWQS9zREpmK2ZibU9acG9CdDhyU1R5d2FNV2taRC96YWQ2M1BoRWZQQzFa?= =?utf-8?B?cW1FVUl1d3V1ZVFRZTJCalpxcVp4RGFTU29DZ2NCOXU2VnBZNFhOclJpcGJT?= =?utf-8?B?N2xqVSt6d1lHZFdPM0haUDdwcGl6YVJoUGw1NGdzRElCMmJHb2NNdHowMlB4?= =?utf-8?B?RWswbFdjL1l0eTh2YmdGN0NzVGwxU3pCV0VZNEZwNzJtU0RFTDdQVEphMyt4?= =?utf-8?B?RWVSUDhwQkNvOGhZRmVHcXRLWjNGdzR6bXF1YnNWeGlpd2V4UVQ1VlpTRmlw?= =?utf-8?B?Ynhtd0VTalVWTFlxQ1JPZEkwZmRZWmh2c3FvQmxlYkdRZW9LWFVpd3Jta1BI?= =?utf-8?B?RGV4QmVNNmdnand6Q1ZtQmJGRG9LOTl3aHNHbittVWN1d0VuU0JNS1krVGZZ?= =?utf-8?B?L3owNFJvQyt0V0E5UnlsL21wQmswUVJZMGh3TnZFUjNCV2pSNTU4ekpiOFhH?= =?utf-8?B?cnY3YWM5SHd1Wk4xRFQ5clZDVDczbDlsRUdoelBLajY2S2xCRkpXRTFwd1FF?= =?utf-8?B?Q2J4K1U1RVZOVllyKzhoSW9FUHJJQmE3UDJnbG41NVBldmJKYlNRbUo4cjdH?= =?utf-8?B?L0k0L3JvUFpYd2xKak1yZkpFTjc1VGxJazdQdGttZ2MxUDJXL21oNGpSVkdM?= =?utf-8?B?VzVDSnpEUG1XcW83QjFiTkNmcU9FRjhBZVpZUk9Tc0JuY1ZXMklZNjVldnlE?= =?utf-8?B?a3FrSUdRYXZkbDVtcVFrZDJ0YU96alJKbFFwaGpKdis4cEp1NGdPUWN3QVdZ?= =?utf-8?B?MmdIc014RTc1MXZZREtaZzFYZ3RLcWR0YlhQdU10Q01MSWtYRDcwZW1nPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 018a85c8-0a5a-44d0-0ac7-08dc85629cd9 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 13:22:56.6568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0358 Subject: Re: [FFmpeg-devel] [PATCH v6] avcodec: add farbfeld encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Stefano Sabatini: > On date Wednesday 2024-06-05 13:14:01 +0200, Andreas Rheinhardt wrote: >> Stefano Sabatini: > [...] >>>> One does not need two checks as long as int is 32 bits (because then one >>>> can just perform the addition in 64bits). >>> >>> sizeof(int) is not defined by the C standard, so you cannot assume it >>> is 32 bits (even if on most platforms/compilers it will be) >>> >> > >> Did you even read the following? It handles the case where simply using >> 64bits is not enough. > > Yes, but there is no need to mix types, introduce ifdeffery and make > more assumptions when there is a simpler solution, please let's stick > at that. > Your "simpler solution" adds a (mostly) avoidable branch. >>>> Just use the following (#if >>>> has been used because compilers have a tendency to emit warnings if a >>>> particular check is tautologically false): >>>> >>>> #if INT_MAX > INT64_MAX - HEADER_SIZE >>>> if (raw_img_size > INT64_MAX - HEADER_SIZE) >>>> return AVERROR(ERANGE); >>>> #endif _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".