Re: [FFmpeg-devel] [PATCH v2 02/11] avcodec/dovi_rpu: properly replace context header

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 02/11] avcodec/dovi_rpu: properly replace context header
Date: Tue, 9 Apr 2024 17:36:30 +0200
Message-ID: <GV1P250MB0737F6CDAA815113042AEFA88F072@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240409125914.61149-3-ffmpeg@haasn.xyz>

Niklas Haas:
> From: Niklas Haas <git@haasn.dev>
> 
> This was never set in ff_dovi_ctx_replace(), leading to possibly
> out-of-date when copying from a sub-thread to the main thread.
> ---

Sub-thread to the main thread? update_thread_context is not called with
the main (user-facing) AVCodecContext.

>  libavcodec/dovi_rpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c
> index d95c7e03af9..bfb7b9fe661 100644
> --- a/libavcodec/dovi_rpu.c
> +++ b/libavcodec/dovi_rpu.c
> @@ -75,6 +75,7 @@ void ff_dovi_ctx_replace(DOVIContext *s, const DOVIContext *s0)
>  {
>      s->logctx = s0->logctx;
>      s->cfg = s0->cfg;
> +    s->header = s0->header;
>      s->mapping = s0->mapping;
>      s->color = s0->color;
>      for (int i = 0; i <= DOVI_MAX_DM_ID; i++)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".