From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9BA294E2DE for ; Wed, 30 Apr 2025 21:56:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 35C2B68B07F; Thu, 1 May 2025 00:56:49 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2104.outbound.protection.outlook.com [40.92.90.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 257FB687BF9 for ; Thu, 1 May 2025 00:56:43 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eBtnGjH2f+9ONywP6GbAD1G8CbOgXaU2INcZC2oLaCJDyuZ+180dOyvJXsvpGop3MuNFppBE6uDYt7QRKIFryOyDquT9W/bQjRGnjZnUCg8Ws0QK92AbjRKCkrdxJZljzLJhp1+dWnvMOSyPB8CR5OUw85zWC47EGv05cpH+cIoqhzJW+/aSjQSPmbqCDmGlBvog62ufyZcmz36u7kGuS+6IVuB5PO9abz2/wyXwI54DdvZTDQaIsRJB69TiOl1jn4KHE8CEW0VqaJr6ulioDNCsbvOfab3y7ZOGxXea+ziWuR1TYcunbIpfRN8YWi2VHoi+JfigGWvAw/GThjG8xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q5UDEmh28nuNEzIEiKQETjULoYTlDMNDubmdjtJHhbU=; b=dZ83rJsEDxgkxlrGCqcnZQRtlhfQ8KslA8p7s3vWeoX/wd2jKRU+X9c5euQO7JUhM+8woygTn7UhWPOvQEEHchr/+1id4nERxDMLeomYmc2WJpwwdrk1yFphJmNtUaOANL37dpSJvdUYrPTUk7ivv5cFU8M276i7hNa+DsCD7xCDxvwP1CIlAr+NK8a2ao1hNP94J2HIwEIKbjUVZjzNXAM2/Vqkhkanp/+Io+ivgf5Hp320lP0WqPhBCafeSgj2wOeLiETBf+o7XXzJV/IqIH5unPMcAUdMPUnlGkvxZbWnyAnzlZ30poG0wwR0At+BTvNBHvcnkgdDa6RGjw+gng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5UDEmh28nuNEzIEiKQETjULoYTlDMNDubmdjtJHhbU=; b=btkr5ehImrSncLmrrW8FXsN7hl4zqJN6bTLunU4+ao64kgmJMF9TfKRm/iVyR657ZfSKy6F6v/y2cl9fQdlnz3Zr2ECmzE08iaFhOtL/6/esDUmnMVR5erk90YeCaTNkl64m36ip75vrPjix06Q2Krdno1tTTEaPJRiVhFmVn82IyHpTIvVuvRRbjWmXLz1F20fcbcw6Q+7V/Z7HvvAxShsXfrfvcqP5XznpCLtkc1funqxxwH4aKYrTD/Who3MlvQ+7p4ZUalC8nLC1iCYz7YDAryPzm2uvfLzCJUMnF2njihllW5GhGKzpj4oWAc4PwZmk5B32bD5jl+AQrcevfA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PRAP250MB0514.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:291::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.20; Wed, 30 Apr 2025 21:56:40 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8699.021; Wed, 30 Apr 2025 21:56:40 +0000 Message-ID: Date: Wed, 30 Apr 2025 23:56:39 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <1770fdfc-7434-4928-b504-c64487baa43e@jkqxz.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <1770fdfc-7434-4928-b504-c64487baa43e@jkqxz.net> X-ClientProxiedBy: FR2P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::12) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PRAP250MB0514:EE_ X-MS-Office365-Filtering-Correlation-Id: 3aae073b-1df5-4211-5e63-08dd8831e327 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmpI8tRyoOXaSUmOkLVCBKasmxG6LDfY2X0gwzUwu4HkAcfQAXBAQqq94VqxCYz5uuiAHp2ycb78jNcKtzHmaN6TLf/qEsyCuKrQ91niP70hA7uFyKvjfGB+zTMoOLk6Yj0SNabMxqMFaQOJGLBrnqpi3BrZTJVqfXPHqt/lT4r0BluQ2r2XLeg7AlbDPAeucGyulFmnIiS6MtlSQrBZV9YJzdCSz19ovX/utcGo5kKd1JgNahul3jVbtjEBYFUS36r9p1D1Ax4u2BsAFHxs7u4BhkFkNz3VWBi08Kwz5IZraB5sJhuo3iOrqHqr+bxNuEjNpsMPGBHZtl3ABBOP5JavOupIphhXSfk02+XRLkZKDg56iavMm5YijL2AlOSbeCezdfbUy5IgRzy8Pk7VF4zTUk2mqGAzgHYBznA2DV7NM6vtYiA0JLixupaYh341mjh4enuFmNRy/u6ZKpxdWym3WfYs+IGCmm1SFAPHkcEg4ydeVXEG4BD5TezqghtCwryILemclPXg7aYjS6wmm88EbzEhUCahZR6yZMTuCGeLcn8IrWG+2KpW5NSEfmymD94v0a75nqMtFho4Kcf9XBPHhjUkfbOKXF2K4mXrvQkTsUQD3JhMA2yVgUS6PScYYIPnPHoByBL9t+NCv/Y9gOTY5xvZpVEnYEpoi1Li4neZIjcBF8DmjcdZBfz/fS5aW5pNzlDdIsMdqT5OTYTiM+n6UK2KvGDwIFVBQ9NITivWvOqhTjveKs6Trg5jHUUw6Yk= X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799006|461199028|6090799003|7092599003|5072599009|19110799003|8060799006|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T2ZTM0w0c01BN0hES2hSSktlWUt6L1FGckxTbkZOeVZBV1o0Q3FxNVhmZmEw?= =?utf-8?B?dEprMk0xMnlqc1VEZVJDczVaUytMOTFPV2NyMHp1UHRkWGVJaU1XNmpWQ2tW?= =?utf-8?B?eFljdzFhMDVGd1NESnF1b29ZVXlYVzNxcEUxQ3F1M010d1JsY0RpZzMvK1Vy?= =?utf-8?B?L3JrM0xQUHlKVnVoRWtPbkFyUm45Vk5GVDY3czVVbkVOdGN3SUZvOXQ0eFZr?= =?utf-8?B?S0gwK0J2aWkwOVhSVHc5aW04K0xLREpVbWdZWklJY29UQkcySFUzMzYxMG5H?= =?utf-8?B?ai9RZEMrNTIwTDFBaHdTWjVHRUo0dk1WeHNVWXpiZUhxNmpIYS9zOFNHRnlX?= =?utf-8?B?N0hoaEQzR3VMTUs1N2hDdVFnSXZ3V3FKQnVjNlB5OUJlbWQxVkIxT2FzUXhS?= =?utf-8?B?d00xQ3F5ZEFYQkhlRm9CdlRSNjlyM3RUVlQwa043YTRBcmc2Wk92RXdkVFd3?= =?utf-8?B?QlFjQ2tQVEdqa0V2RFpkbUdxMHJnOE04eVRNWEoyOTVFVWJPZitLRmFJR3g2?= =?utf-8?B?TUZCSGV3SS9ERUJGdGdoR3lVemswN1lGbG1MaU9LQnkzV25Rcjc0UnpmelRx?= =?utf-8?B?T0Z0OGFVeFJUZ3diR3hvYTF6TEVmM2RkTU9ibEJQY0NhNUc3UkFYbmRGV1JL?= =?utf-8?B?OVFjaFg3bWwrMksyRTFGODc2cmZFelhVYWpxelVORWxCL25XVkVyang3YWsz?= =?utf-8?B?TmVnZE44K2pxZlFvdnVuRkkxSWxtVmR0c3NtTUxhTVJyQzZPNFM5Vk4vQm5E?= =?utf-8?B?MXZGeWlUY3crTjZVSURCdEtUYzRsbEpiOVc1RXNkR0pOQ09sODVxUXJ0Tnl6?= =?utf-8?B?blBZK1BvOGo1bjcrSkVEVXV2K0xnWFBmYy9WcUlZcDNDYTlrU2JOeU1ieXhW?= =?utf-8?B?eEZTTmQyNldjb202bXcrZXVGMTR6SnM4aEI4RW1RaGMvMTNoKzZ5Tm92WHJk?= =?utf-8?B?b24zcW13aDloNkcrMmtoTkpMV1ppSkFXNjVMV0M3NzFMSUN5VTA2RFhSUkRB?= =?utf-8?B?aHNsdGsvc20rYWtIMXFMTlo4VHVOUnZjZUNvWklhaGJ5VWN5QUU4eTdCaWZJ?= =?utf-8?B?SHZmTTNkdWl6MXhlSUM4aVZWdE96bDRVaFFpSHRMK2lScVQ3NEIvZ29MTHlU?= =?utf-8?B?Q2d1VW9oZ2E0YjFDVHQ1bWNuSStEMmhUYVVON0J5bmtNbGZCbEp6dkNSR1pU?= =?utf-8?B?bGIvckkxVnNGQTN0NDdva1NETmpobDZ5NFZ5VGJDbllYeHlteHpaczhKbmVl?= =?utf-8?B?eTlYL0J3WVlIZFJ4MTRiRUpvQS9qbW1lT2hVVm0wc1RqUGVzWDAxL25ld2k2?= =?utf-8?B?MnR5aml5SUtwTlNMV3pFTkxtKzZQZ2xrNkFZY0N6NDBCWXBmcktVTVNxUlhk?= =?utf-8?B?cXhCSGZFRm00cWNnNWJ3RjBSMURzWE9pU25ORnBCSU1FWktiSlB6VEtydUlW?= =?utf-8?B?WmpkT2pHWFNTUjhYdjRCSlhMcTVuVUtJK0RSQTdxVmVoMjIzbTkxdElNK0tx?= =?utf-8?B?L25ORWJLdE9Uc3NjZmQyRUlUVE5WOVZidE4xV3dKY29KYWxQbWdpRGt3NHdw?= =?utf-8?B?RTM0dz09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGY3ODhRVGk4bDRMdHpPa1dhQnJyT2xWYy9VT2kwb09XNDJVOEQxV25SeW5T?= =?utf-8?B?VVphMk9MQS9xZWFtVWhyVm1TaGRwYUZUazVsQ0hMUXdaaXJGU08xSWhHRmVx?= =?utf-8?B?MmV1c0hCVFZRWW4rQ3p0a0x3a3RxVnVRd3d5aFhrZ3AySkY4a3JKaUVKWUw5?= =?utf-8?B?dEp3SDJXY1gvYUpIQ0RtK3VuL0lqUG5mVmM1akVIOVcxRkk4Q0IzMUcyYVJB?= =?utf-8?B?dUEzMFJIdHlzODdRL25sbXBDRUtnV3hrZ2tlZXJabGdtczMzVlJ3VEZZZTRx?= =?utf-8?B?Z2ZOZkpLU3N6UHhQY3hGRUZEZ00yTjR5dTBTMU9lTThZQmE0L1ZyRDFFdDl1?= =?utf-8?B?enplczNab2NiOSt0dGhwR2hhUWhFb05NNFV0WXREdlBXaXFZNzJlT1hiSER0?= =?utf-8?B?ME4zdS83eVhUZ0dhQTdEY0RhNDd4S3U5YUkrd1loT0J2VFBhaGFXWldOdWRh?= =?utf-8?B?Z0ZPOWZ3aENXcGx0OEF4ZitPZmQ3dUl2dUlHVDBWMTU2NWhPNGl6WXhXQ0RK?= =?utf-8?B?d3RWdFVlbzdDczlteERNMUhBMnN6WVJpcGlWREszbFREdkc0SVczVTlWcnpJ?= =?utf-8?B?UE1aOXJPdHY0RGw0N3h4Um83RUlEcnh1aTNvNlhtdTUxbDF0NFVnK1FnZmYx?= =?utf-8?B?eWVBbGtmUjlOSEtGSzc0RlcvSituVHlYbllkNkdmQU1lRTRHekhWQjlGbkI5?= =?utf-8?B?VUVSenQwTlcybGprT2pGanlvSGhROVg3cUVYTE9LZXczWWsxS2k5RlNaZ3dW?= =?utf-8?B?RE1ZeFdVajA3WDZuUEZUNkN6dW9EU0tBNkVDYjhYazdMTnh3N2VUNThZTFV5?= =?utf-8?B?Rmc0Z1hzcXNDR1VHZlJlcHFxSk1DdnpWVnY0WUlRelk1VUo5a2VlUVh0MEM5?= =?utf-8?B?N3VMV0tHVlljR2xaSkUxZkpCbytnb0Y2UHRmRkNBOERuazNHcEUyVngySE1C?= =?utf-8?B?ekJDcWhqYzl5OEpWcHFYRUxkeEhOUUIrNzRYblQyL25LK3VpKzJwNnNXN0gx?= =?utf-8?B?TlNDamt2ZzRYNEFyVC9hd0N1RWlCWmRPWEJoZnJkQVQrQWNJeDA5djRWVGJZ?= =?utf-8?B?TW9kN2JMa05PUmRodjFkSVlGVkRDaHkwMS93cDRvTUNib25YcS9MRys1anRC?= =?utf-8?B?TUhvaTIveFprWDg2dFZVRE1Gbnc1Q2M2aUp0anpGenRSNy9UejZKU0w4RjUr?= =?utf-8?B?Y203TFpXNDVGbHBobkhzbnZVREpCTDlDQWh4c2w1TzFGc1hDQ2lHTG5aOUwr?= =?utf-8?B?WHJLcGtUWGo2citiZnU3Uk40cnZiZEk1aEtXYVplV2RISjZva0NsZm13QnRL?= =?utf-8?B?SUtLZithTXJOVzROT1RtdXlidVU5ajBNYUo2OWttRTB5Rm1ES3Z1UkpiNzlF?= =?utf-8?B?ekJIcmgvNnQ3ZHlQUnhsOEdZZ1dic3l6ckppVGpwMEQ5OXM4d1dhMGordzNG?= =?utf-8?B?SzZxcnlXQ2lRNStuTDA4Z2ErWDgzdFd0Qmw0SVBlVkt2WVhxbVFvelZNZ2g3?= =?utf-8?B?V1l6cEZpNFVKTTVZTnhMNmF1YkJmUGRYNFdYdVVkTnFRTFZYUUdCeWNRYWIx?= =?utf-8?B?cnBySnFZdTU4N0ZVdjErNjgyN0xOZkdWZjk1aW5JU214NnV6ODVZVXNLdDQ2?= =?utf-8?B?bHh5blhEQWk1dDVYM3lZR3lMZU5Fa2pvbXltSFdlSUs0NFF2NWVGMEJNcGhq?= =?utf-8?B?dW44YmFnUjRzcm5ZNjh1dVZkWFdvT0EyN2N3c3hNUEhVMXg2S0MrQWN6bHZl?= =?utf-8?B?bXFwd216MGN6TjJMRU5meWdmSld0SktRMFFtbTRab2tDdVJKdEN6WC84a1c0?= =?utf-8?B?b0NNVkNrMmcvVE5ZN3JPdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3aae073b-1df5-4211-5e63-08dd8831e327 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2025 21:56:40.5883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0514 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/apv_dsp: Fix left-shift of negative value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Mark Thompson: > On 30/04/2025 19:26, Andreas Rheinhardt wrote: >> Patch attached. >> >> - Andreas > > Hmm, the spec does write exactly this but also defines << as arithmetic left shift of a two's complement representation so it works. > > Seems fair, LGTM. > > More generally this line is not robust to extreme values (can integer overflow 32 bits), but the cases which do this are not useful and won't be in real streams (if calculated at full precision they would always be far outside the possible coefficient range from a forward transform, so it takes a crafted encoder to make them). > > Possibly a pre-clip to a calculated range which ensures it doesn't go too far outside the following clip range is the right answer to avoid the overflow? I will think about this a bit more. > If it does not happen for real files, our usual answer is to use unsigned types where overflow is defined. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".