From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A4CD4B754 for ; Wed, 12 Jun 2024 13:58:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B0A468DAF4; Wed, 12 Jun 2024 16:57:25 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2043.outbound.protection.outlook.com [40.92.75.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C61BE68DAF3 for ; Wed, 12 Jun 2024 16:57:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVFhGiGva2iAEt82Pz7vCiv04DynHtY3odobniEsjyb3iC3TwRxRMwlZtUymC2dytbRT01GfTVH+Ym9rAudYNKdGyxNFWKz0hKtGI1yYmarckrbvrHOckjnKjDc8imHIE/cX3eCSQGODZ5MCttItanYpdipRTHtRO2OLeFqRG8rq2TRJlAUDP/88AiSd7hc02u69pxqAsIbY77DKvbbbdVvFcPAvuUDD7Y/nrjnkVICEq8JWlgoZ2wjCIrLt1o9KhAkrlAx3hnz4s8tGDSPRq3ua+Lvcwp+GjYW8dZSgmWg+uvK4GjtDVCitHI5nDZFdXfgkgBR6KM1nqIxWAoy/9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8yX3Civ26jX0d5ZP1Up3qyOVA/Y1VtaXp15DQKI1RqI=; b=cYci83BR3SCXMux4bCbYydJ6UikgqUxd5i0QtQ+gxUi60SYK32DDjv5diIoQHYhkSLo3bpSIY66Bt/eCuyUYaA+Ut29KGaIkrBGYQqGX9K4gEljrXhbKJpHReyMTxK9X/DwvvlCrZByHg8qtwsgqf9MqLScuJPnF+XSHKf4aLzcb3ZhvrQL1X2YrIzPT+SpEjYu1vf258mzeUEMm9sWWWdtRgYEMxzAJCmvqjwnjjmqUZtU35jCiOCG2UU7l2ouuVtHQSMytKVjDoB918Eh4huyTf/terMqXEvbXH6S/WIxrbMEHd36LmZllAJR/0s7VGHW8ZlRva3VWN4G3n3yp7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8yX3Civ26jX0d5ZP1Up3qyOVA/Y1VtaXp15DQKI1RqI=; b=oqls9FjG/IOE5P705Q3XcS7nfF1iw8UWGD84SKxSe9TYrH90IItGO1qU45GSQej0/R+ZK6Vge/Wos/8oZ2Dm2BoRXow1MM/ifyzJn1IVgTFt6i0uZZ1/otWW4BAfyKirI9A9wY4WFv2mWZTyjIPYti4j1aOwwkcT5xqoag1IpUxB+tMi8oSMTfEyGKqPtaCV0iP2pWKC33E7WWzWgcydU+J9ex0qZcDHWqv7GxhB5B4e5oTPe7TTiT7mBmvREuB3rVHyPKg1Hbf6YaVEYG8h15NSXo4dZfSfYal2zDBerwE2shgfxs4iDit1BAavWVlWLbalB+VA7WfHMhFM+E84Ig== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0232.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:327::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.37; Wed, 12 Jun 2024 13:57:21 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7633.036; Wed, 12 Jun 2024 13:57:21 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 12 Jun 2024 15:48:53 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [GoWrL7ZknhAxqthaIBx2/y3OtjypmSUV9+5W1/oKlZo=] X-ClientProxiedBy: ZR0P278CA0189.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240612134853.2102377-56-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0232:EE_ X-MS-Office365-Filtering-Correlation-Id: 2aaa9891-7dad-4bfa-77bb-08dc8ae7944f X-Microsoft-Antispam: BCL:0; ARA:14566002|461199020|440099020|3412199017|1710799020; X-Microsoft-Antispam-Message-Info: FF6S5mVY1SyHhUZ0SckjTmTfy/ba6lQ53nPSTry+qQIvvJNW9ano3zD1Tc5MC2W5k4Q3Wo/zl9WvkbJmxgkDea3Y/cQBWhs6hH5yUeDl2OzzFgXcu54+zJ03wbnvIOMPGfIK3OknkH4U2K98ctvLO9KUnhcYuXdoV5JN2b2Q376C0tn1JKZT1J0Z7rlbyRn0GW8AxZFYoUix5OV4s4CnZnTt7eDVmxoww4Nlk7rp2sKzFmGkxCHwcrUqVkDpNBS9QIfLVcHDsDreWINRtPLeGCvu0oTmkpKx6s0YWFwexbBDa/8N7Tl/aSD8EbjE/L8jO6KJFU4dcZPfQwc5JcKBy2ibFAj3LdcNNvL/tRh2ogi6GllgYnCXwrL9kya/jZ1mn8dtaNr/lfUMUdLOg5xTVO8aTtoAie1gc2jkgPg2PFkETOuB4W9cWm/x4vcWnjIGklmeRNwxH1w9V3Ncgy29Zh4m7057/zshuJruP+OonZtncoAZr+30fyvLQhtFyCSCuLlJg7HGgbNRqlCm1nVjyC2PkKv/2f1zfumXdbXlauF/tNjTfqehNK2EnO+ENOEajHBpg1AodloGQQVy/1hUWIjALoKJJUmO1xB+MwHxJEIEphs/tuPMap0WtPvLivrx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5SG6BJD4DzVjZ7cpQl2d1Ew70a1t4vioDfNyM1Jz1dm9jro0vKN7W7ehef5i?= =?us-ascii?Q?PteCVlqrlx4T42jEkgQQ34FbITUkjYrD7e8D/eFO8uxClP0L53NCWTUCr+Yx?= =?us-ascii?Q?axzFWt0A87XBL5jPBYWaCRfnQOziqFN6VdgdLwb6Nz5KudIo0MLwZMAuUwgO?= =?us-ascii?Q?LlgeNXNi3yhw7MdmGFsEmEFLpTwQa08bp9PfrBj+2V8wkJf0Lo5wUh6MXo4t?= =?us-ascii?Q?+rcPeZ5RTyn6ukay14N8SHIKrWbKFhYsYB+NhK9d1ZF/UyAoH2sJCoJZppG6?= =?us-ascii?Q?g8A6t8ZhrF6SvIs0sEKkjuMu619PWEqvAuQNPeDZF0Qvw6iOaNlW16ILES5F?= =?us-ascii?Q?NiBfSLF9xt8jI5x9WnbeEbEoPJRFsVn/2o82crn59TnkWnAHjywGCmGYvPjK?= =?us-ascii?Q?EhVuex2TviuHRp/jc6fAF4bUcbG09MA8DKKmRHfB9kSoYP5E7ueF3Wm9PFHs?= =?us-ascii?Q?q/bBxnW14vCrGIXCC2qiODpy6nHhyLfeFV9penVq8RHE7nUoh0l9hR9pZ3ib?= =?us-ascii?Q?QgSPfurXd+9ONsU7xGLFIjLycptGmVR841OqKqr0XkA47/aUpxhPjOx4Oe4y?= =?us-ascii?Q?fbDwyHjk6w1hDo2zkG0UpCcedt8PYPeFkR05moi8hbyRlrvsxliESf4ARFk0?= =?us-ascii?Q?FnJxpy7rK1vWRWEOOxEnzFZIiVTnd9sbIlXGZ0fDEKDypzh0gnA0y2CFG40+?= =?us-ascii?Q?SMZe2AjVP5Uq+JkLDntPfxfetEotAAxcIYivdJ/VAI6Yg6PGMXCNZBn3lZ3q?= =?us-ascii?Q?KKqCfMCmxkE7mkcHtRpK9ft0G2QCylcwOrwOrlJJ7ONDe3s+85DZnsXZD63S?= =?us-ascii?Q?k5giDSJZodaHs0kY4FOlryh6A+vhc8+LCRo63O1RWrgbdykAawbV5vcWK+94?= =?us-ascii?Q?OrbwfoxW2HsPsEk0lyj1WAEKuXA3S31yGcGZ66EAQ2SVcjpGl3OafiBuVbxD?= =?us-ascii?Q?8VKXqqRLNcbFp5aDpOYbFB8Z+Ca/P/HRBcO7aPM2ljTbthO3M7MSkLY4+YRG?= =?us-ascii?Q?fogSnBF/as9T4BZS114IeQRc7E5H23+3+mqiq0qLnjS9lnukWDO+mr/iugHa?= =?us-ascii?Q?ORJfqdKHhJJg9s57vBU5Lgd/fLLK7tr39OHmcWzywiXETIQr3GYe5NYqtlR0?= =?us-ascii?Q?PdtiVumcJBFbs/c+BlBcLGMHWWImt7tiBWrY+qqZy6eje/JwZaTIwG9KqT14?= =?us-ascii?Q?12KtdPaLAfl9/bpeNz32k4zrBIK+ogc6p9emo/1s5w8vXwCekCt2dz6YA+k5?= =?us-ascii?Q?4DtbR6X73Ls3OH5P3e77r11lESAGNU1rLrWO9a2Srw=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aaa9891-7dad-4bfa-77bb-08dc8ae7944f X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 13:57:21.3029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0232 Subject: [FFmpeg-devel] [PATCH 57/57] avcodec/mpeg_er: Don't set block_index unnecessarily X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ff_init_block_index() sets MpegEncContext.dest and MpegEncContext.block_index. The latter is unused by ff_mpv_reconstruct_mb() (which is what this code is preparatory for) and dest is overwritten a few lines below. So don't initialize block_index at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg_er.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libavcodec/mpeg_er.c b/libavcodec/mpeg_er.c index e7b3197bb1..fe7dcd7efb 100644 --- a/libavcodec/mpeg_er.c +++ b/libavcodec/mpeg_er.c @@ -76,10 +76,6 @@ static void mpeg_er_decode_mb(void *opaque, int ref, int mv_dir, int mv_type, s->mcsel = 0; memcpy(s->mv, mv, sizeof(*mv)); - ff_init_block_index(s); - ff_update_block_index(s, s->avctx->bits_per_raw_sample, - s->avctx->lowres, s->chroma_x_shift); - s->bdsp.clear_blocks(s->block[0]); if (!s->chroma_y_shift) s->bdsp.clear_blocks(s->block[6]); -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".