From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9262D4A5EB for ; Mon, 1 Apr 2024 18:41:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2828D68CF19; Mon, 1 Apr 2024 21:41:12 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2014.outbound.protection.outlook.com [40.92.65.14]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1FCE568CBAD for ; Mon, 1 Apr 2024 21:41:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7DoaNKgiQONgSn8S00Y3lcH2eQSMJwmUN7h3F0brDoSDcrhY3pGcsJ8s3JEiMdM+fWQ25ooXvfPowPgNIrdxXZHCzEtZAWovpkRnua0rvhBfPDinbUQ1x88jSCyLeESl+9ufGFSGxAjoV0L2pZO+RgzN9R/Nq9WLN66XauHnqwBNI2I/t9O9PrnpV73pa9g8CPgfB1yD1s6EPcgSMgmwXXxWoRDekiqqCjFU0BdIwkpfjILTfYPiULtELM8gObm8VQd2feOzgYeq4Vmn7+EdOxnB+x0FC/+tEzlgjC8lKwaXtNbvAFxDNJ7mi658TYxR5LN0LNUtma4L/9BxVrR+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qnd2XBH789j1nVoKz+66vVsx4Yf5mZ18zMqzRb+/2ik=; b=DGSlejLyMH6dw3db2Soc76aUJ/PKrwTHftUdPHeC3q3Q7K4kIY6KLw+tk8NTddvpzO9lNSamuAu0RjQWO9PCumrmO5VNlO5fje+l+vtUf0+hLFw9ESaSBOYCXB+VEqZRx0GUi/2jfB4VJL7DeYGFtA7s/AuAqO4d0nwKzFqcpevLCa5xkJbAUryHq0/0efD7sAGdxPay+6DZkjpZJ/tondgEWaEd7vzKhXkyGtvl9zjozggijPLX8WgYhILUoMcLZl+JYl+UjBrQeUqB2UaQ7rSuAylgCoLJMWxW/hh0F1CiHnWVRHP13gs/1/5q0qUaMn3HxAx4jGjJ0qYX7dCXDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qnd2XBH789j1nVoKz+66vVsx4Yf5mZ18zMqzRb+/2ik=; b=Tt2sfrTdMQ9ZJ+YXVYN2Un9C+xLCMBnZ+6K2pBI6USVH0vUHBSuzCp5xDbPeN5IFMryNj7uYedpwJCZh+ubXGdyBGW6HcB9rNxowCv/ON4zXpPLvXHE7aNcEiS9LZ6qxWiuMzNORpB2oD4mStDWC/tUzWmxm5SbMwEEhyagtc3XeHSpzRnkJgJp58EVtE7ciAKszWtN8+7aSrJfjwlP9Vv7mEA/+BliTI0P/Eliv4NzQU9NMTP7dD8n7pqsObFFexXxQIvW6BXK2zEaDKvhC+l7ODXch0KzkC5yCsV4xYJXPRqQR3L9PAE94cthF7T+Blp004hn3lH6E/F9NCRSAsQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0021.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 18:41:02 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 18:41:02 +0000 Message-ID: Date: Mon, 1 Apr 2024 20:41:00 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [mccWEVVXaVDHuRTC0KrQAFNJq8ezCQaK9hAfGKnSbfQ=] X-ClientProxiedBy: ZR0P278CA0122.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0021:EE_ X-MS-Office365-Filtering-Correlation-Id: 834bae92-b74d-4ff4-b21f-08dc527b482b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vPWH7zgKxOMUF7Ng410o776XfYc2cPLkh69Vf3z7HHS1qjO77g5JZiEJvwLdKXPJynTGlu0YIvwuxQ1q5Cwl53bIyLUyQWWdVfs0tQHqwAPrlgHAeqnPdjOxpyT9PcC6rdK6eL2LmXZALrKKfi+K10Pf5WneqZnMEl/u5Oe7DmMs05uXms2Ivz+oJpMLn7aEQL7A/7DcBkF1OmSXYSHvEo2/aWTRB2wRK+e/HvgH95iZ1W+FEU7DuIWU2tmdqkXth651HDb4P3ydCVUGKbK8eu8MPv2nXYzEvuJonPKiz8KCKWHIWmsYW+ZvlFruV1ntxO1YikY7o92rijlNQJPKX+XoUSoDj8Mhe7Z5yeH8IRp7Jf5RrEH1HtOMwN8jqlsbru3uZ07Hn17Ts6BrNuezL6esbHYnQ6WUL4ZSNfn1WG7umAw3lIZgQxgVsHtFw69k20npmPTBx+HKd3R58qz/AwhLpkqdaAbfbYBe2qrxbMCy/g87431OY0NgWyv22AmWG+5Pr9qa0I3kK8vTnWTUlil45wiae/QuLrWQziVJnR2eMkPh2vxRVQqprfli9RZbJUCKn6J/RDe2kP/aTfmdMwt5+3lDLS5eDoYFuTK/hHJws/RsUIBRxR41ZFlJ5useNBhmadc4kH6rjiUkM0gvPc09oro5nluYp4eeXm07b78= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWU2S1hyWFZTeWxhMzRRYjNxSDg4L1U0M1FiQXcrcktHK296U1ZBWGk1OUZn?= =?utf-8?B?YTNnaDJjQTlZcFphdlVQcUFtZ0FwT2wvREtFNk1Ka0ZMK2NQVUhoMjdhZDNE?= =?utf-8?B?bktFYTBlalBQak4rYjNOc2pFVE55SW4reUdPMXoyMTFHKzBQNXVzT21BeXpm?= =?utf-8?B?aWE3MStRYktNUGlRVGNjcU82MEVIVHd0Rk1ab3BTWnNBZHpzdThDeEdBd1lB?= =?utf-8?B?TFhpM2RDSU5tcG14QzBuMk9kMGdNM2tocDZtdjNtRlBIbktXSVdXUVpiUHNO?= =?utf-8?B?M0I4eVhlR3p6MEl3elhyQ2szSTFxckc3blhUZFVFemtnUGltRWh5N2FOQXdh?= =?utf-8?B?Mzc1UnBpL0h5TllCTTR2MXVpenM4M1RxY3pxZU10RUhrc0RKdTFmMGxFejlE?= =?utf-8?B?ZlVXREQ1YXZYT3dObC9ZemMweDlOdjhhU2oybkhwU0U0a2xUUEtOZmtoVEF3?= =?utf-8?B?TytPdnA1WmZ0NUVWcG11bjJWbUYrUjNGc3BaR1N0bmZRNC9mVEdDcnNNVnkx?= =?utf-8?B?L2lqeGMrUUxyTFJtbmE5VHRjY1RvcHY2RXFrQWxndG9mbmFxNWxIUGJnVURZ?= =?utf-8?B?Rk5sZ0NEV1E0d0VOWGhUR0ZaRVV2NTNMWDAvL1R3V1FkZG5ITFBieGNGSEhD?= =?utf-8?B?aTYzczZBd3VSTDR1aHoyeXV4UjhWVHREU1p1Y3Z1TmRXRDljZzZLMHBnMVVV?= =?utf-8?B?bHJwZXpLcEZFYkNvQnBwbmlyQlBRTTgxdXpUelY4WXJFOUNoNmlSVzV4VmdK?= =?utf-8?B?VjNEU2o5NTRxemN4QkhFeU1hL1hnSjhuRDNIeTVUY0N6Y0grQ0pYRmFCellj?= =?utf-8?B?OTRlL0dNUm5FM1BKOVRISEFJZHp3K2NQaFpqZTA3VFl4NlBkYWFrTHROTDNJ?= =?utf-8?B?dlhhQmJKa2ZyWXh1VmV2Q29kTTVKekxQRGw2dEY1K0p3c3NzVmVNRG92WkJm?= =?utf-8?B?OFMycGN1RUlhNklyZmRVV21FVlVPSHFNMGtrZ1JJUzNBT1ZJWkJmSjhubHM0?= =?utf-8?B?bkZyenY5Nm9SYkdLWU82TS9saXBBenlBT1hkMFZDbUJqZTJhWGtCemNXcmoz?= =?utf-8?B?ZlJ3SGhzc204OFBPeEtlZmc0OGplajcyakxhMjlWcUxLNlZ6YXVya2lEZlpv?= =?utf-8?B?TVozRzJzWG85QVBxTCsvTUsza2hsOFFJVFpwazhwM1cxMnVxVWNsUGVtdXln?= =?utf-8?B?Wkc3L25LUjZLTVNoMHFGWWFhalJsRzZzUkFCQ1Jhczc4NFkzMmRMNFlrRVVm?= =?utf-8?B?S09rTzdCSjlZUUVJaWI5SXJIUEYvb1p3VWdxVTJHcm5DVHg4aGtIQndqRFJ4?= =?utf-8?B?QXQydW9aZnBHVlA1WnVhUkl3Y0N5eUlwdW5oWTBpNGl5SzNwK0YxVGE3RzJ1?= =?utf-8?B?Ymh2dXFCZkdzRHNRWmwrRFQyRXNtTWZVM3hxdVNTb08wWWduSzd1eFBsbUlm?= =?utf-8?B?YWhad0FEUTZLUUwwQTE0UjltYmt5YnU1clhiTDhXQWFHbW1McDY3TGxHK3dp?= =?utf-8?B?cFpselZ0eU1hWXBwRHpPNU9VL3FtZDI3dDJPcWV1NG4xc3hpWG1sVkI5SDFy?= =?utf-8?B?cS9PejJnUy9XMU9DeW84WndQSFZsMEoxUmRXQ05yeEEzT1plS0kyRlIvekV6?= =?utf-8?B?VHc2WDVKaExBU1RNbi81anNQTXZUdERYNXJhYk9wd0pjRjFYTFNrcE9GMGhO?= =?utf-8?B?RjZ0QmdIVlRsUllhWmFhQmNjZWlQd1NFMUoyblhURlhIVGVRZXlTalZBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 834bae92-b74d-4ff4-b21f-08dc527b482b X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 18:41:02.7816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0021 Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/ppc/hpeldsp_altivec: Fix left-shift of negative number X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It is UB and affected e.g. the vp5 and vp61 FATE tests: > https://fate.ffmpeg.org/report.cgi?time=20240327083327&slot=ppc-linux-gcc-13.2-ubsan-altivec-qemu > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ppc/hpeldsp_altivec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/ppc/hpeldsp_altivec.c b/libavcodec/ppc/hpeldsp_altivec.c > index a531b6b6ec..4bf6b28ed6 100644 > --- a/libavcodec/ppc/hpeldsp_altivec.c > +++ b/libavcodec/ppc/hpeldsp_altivec.c > @@ -41,9 +41,9 @@ void ff_put_pixels16_altivec(uint8_t *block, const uint8_t *pixels, ptrdiff_t li > register vector unsigned char pixelsv1D; > > int i; > - register ptrdiff_t line_size_2 = line_size << 1; > + register ptrdiff_t line_size_2 = line_size * (1 << 1); > register ptrdiff_t line_size_3 = line_size + line_size_2; > - register ptrdiff_t line_size_4 = line_size << 2; > + register ptrdiff_t line_size_4 = line_size * (1 << 2); > > // hand-unrolling the loop by 4 gains about 15% > // mininum execution time goes from 74 to 60 cycles Will apply the remainder of this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".