From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 2/3] avformat/evcdec: Check that enough data has been read Date: Thu, 6 Jul 2023 23:08:28 +0200 Message-ID: <GV1P250MB0737F127E8B0D4869D3CFCE78F2CA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw) In-Reply-To: <GV1P250MB0737A5B6C108D1223DD82FBF8F2CA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Fixes potential use of uninitialized values in evc_read_nal_unit_length(). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavformat/evcdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c index 9886542311..0f464930f7 100644 --- a/libavformat/evcdec.c +++ b/libavformat/evcdec.c @@ -162,6 +162,8 @@ static int evc_read_packet(AVFormatContext *s, AVPacket *pkt) ret = avio_read(s->pb, buf, EVC_NALU_LENGTH_PREFIX_SIZE); if (ret < 0) return ret; + if (ret != EVC_NALU_LENGTH_PREFIX_SIZE) + return AVERROR_INVALIDDATA; nalu_size = evc_read_nal_unit_length(buf, EVC_NALU_LENGTH_PREFIX_SIZE); if (!nalu_size || nalu_size > INT_MAX) -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-06 21:07 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-06 21:06 [FFmpeg-devel] [PATCH 1/3] avformat/evcdec: Avoid nonsense casts Andreas Rheinhardt 2023-07-06 21:08 ` Andreas Rheinhardt [this message] 2023-07-07 1:14 ` [FFmpeg-devel] [PATCH 2/3] avformat/evcdec: Check that enough data has been read James Almer 2023-07-07 1:20 ` James Almer 2023-07-07 1:30 ` Andreas Rheinhardt 2023-07-07 1:31 ` James Almer 2023-07-07 1:52 ` Andreas Rheinhardt 2023-07-07 1:24 ` Andreas Rheinhardt 2023-07-07 2:12 ` James Almer 2023-07-06 21:08 ` [FFmpeg-devel] [PATCH 3/3] avformat/evc: Don't cast const away, avoid loop Andreas Rheinhardt 2023-07-07 1:15 ` [FFmpeg-devel] [PATCH 1/3] avformat/evcdec: Avoid nonsense casts James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=GV1P250MB0737F127E8B0D4869D3CFCE78F2CA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git