From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 42B1C4A76D for ; Sat, 6 Apr 2024 11:26:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCBC268D07E; Sat, 6 Apr 2024 14:26:00 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2029.outbound.protection.outlook.com [40.92.89.29]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 738D568CA3D for ; Sat, 6 Apr 2024 14:25:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/SrKg3BIMQQASJXJE/26PcTJGlJ5Wmi/K/i3xmQx1wMVPywSAnHMeeilBVDIzku0YkhD2U3EI9T4KS2Anm+40e9FBd6RG5WVhmCkgCUj/j24BIeQtxjM0Dk4nNokkS0EPjrSwaHnasZspTpbxnHJZ2woEMwno4gJvXy+k/FOpV8QZ/RgmtX/sEhUPdlLnr9Opu2Onc23A/OUSf9guyiRSD3d72JNMhNz/R5zlydiXTa20als3MnzdD6TALEJbIVAOH7YHYGVXJorKkm8kusJFMlgxqBT5VnHuAgYrqLVSlrPOUocgry+eIQzs/sz6Kj3eyKmmfKH4ecswgUR5oI/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCGNTFfs43ik1TBO0bn11r6VrTEvymJw5cVZDMwj3Ak=; b=RhYfV9TOGl2lUTkIOrVHAUkaCGBxbUivxjrzsVpITuJAXkap+lAirXZVqeYrOLIxBuFC/I5gvzJxHiCsmk/hiGuLIFRlHUse6RWWCuDK5x6m+S2/2iqGQRmGkMHw/BFnAozQd/i2JtoaHJj7HDm6/AVtQuMZsSfuasFgcC3Lzs7x1+H2S+e2pVr7btmTQJCW/WPd8oPeXjCbFwywmtChFIUD4hjmKI7zCZvpleIlbvD/Ls/XGlbBBYjTXeq9ziJ6L3g6le4VxAcChLHlxytBZ+5K3YU4Q2r0vYPRAqQyITdR6cFEq1vdkOmBDnjtzQ1ZGbdWwHr+ffXWDfJrTKGdXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OCGNTFfs43ik1TBO0bn11r6VrTEvymJw5cVZDMwj3Ak=; b=n7fKxZ9KOFp88Sgo2PnEsm8V09Az3fYXEm0cm8AAMxP0qMzJR647sTQqN0P7qBiCfeQGj0ASYoQkszhjYwB2Eystprh1VMCiK/sb6uoTzSNkEBMlcTquF2KFuutS6Xa9MW9sMpD7Wb41oXA1ioN1AHUGLC1FXeQqGhs6l6BU86oRdGkzkx/36SFW0/eeKOK26ZYZdXHWd7ro9kU5MHY+rfgIrr0JNIzMJ3gPZpJt8aT2eYWibFTnNstYQUFmwa8A3uR5vK/gkx1hB/N7mTroaG90aQuTLmRkJuYjyeagf4HQVJru6MRi6O9nh3SgDW9uRLLFtFmO68ywwdIxYJmtag== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0374.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 6 Apr 2024 11:25:52 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Sat, 6 Apr 2024 11:25:52 +0000 Message-ID: Date: Sat, 6 Apr 2024 13:25:49 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240406111014.6916-1-stefasab@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240406111014.6916-1-stefasab@gmail.com> X-TMN: [TYcLLyWmfxGwsv2Y86wTPMSq9b6GuPZqkNLBQh2+pKc=] X-ClientProxiedBy: ZR2P278CA0066.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::20) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0374:EE_ X-MS-Office365-Filtering-Correlation-Id: fb3a81d5-befa-4fdc-2223-08dc562c5123 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qcsnm/nO7SZ/Y03Ta+KymTQ4blwrnTsyCN6OjiKDCtb/egBcEQ3JNz/RTsXEkFg5unSr2wG0raQWcxQNRshpFc/OGbgIB+uXI/hdHt1OF3NH+XbackUYiO2kTf0jeFDFzZpBFu2tY6tiazPkBJAUhSz7XJ/KJNIkH4ZAOmq3QArQbJRFSZARV/FysgHrC5jD+XRfczOK4s4gahQzPbGP0p1DiNxM23LF6sbP4haekc4CFQBf98F/5MKXjemJbQCKK41o7s9f6BJJuWSJvR4f0pKVULy64s0GJX92utJu9cpVi3z5+9pIDUsiBd9OvkfKYIR5vGt136j7Pets4p8fMycy+0R6hI7vJUz/dW2tFcfLMCP6e+sFn3LNKSkA3Edv1AmXTTT4qCmMxl3nUTGKcsi0wa4DhRr00KtUc0tq7Ru7kutFdMaHXdrysONI31oU+VXje8ao83rJgbPLx+D6hjkD7uaPrE6t3B9Ecf3MLcsexqeSIef8nH3ZXoLYhnL8+tp8nYnYFTwUooR4Hh5LxSXbkhK6ZQPfEx6Srv3VRhqa5XlCp4dFlPquohRUl2tfDoW+CaRyXWCRO2xoq6EJtxal1oV7fTKncIyyQwcQ7PprACZZ/IJWQgmG+nA7l/sC5FwLlenxY7jD3mY6dGL3TgsOmfXYAwIjDK9GsB2qmp0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0tJa3RKSVNUV1FJVTVkSEJwVXZlTjdzb0Eya2NmcndGNGhZMU1kdXQyaEJ1?= =?utf-8?B?M2RnWXRxNE85OE1qUWdDUW9Pc0dxOW4yOVZjLzNobjFjUm53RXFtUE9yVFRW?= =?utf-8?B?MkRKem90dUJYR0ZTUmVUZm9vT2NmQldsTEVpTkpuVzd5eFBBT3ppeTJjRCto?= =?utf-8?B?KzhpSHNwK0pXL3NKM3lWdm1iOWJTMzhTejBJTXIrNU1lVlhKcnNBajIrVVZp?= =?utf-8?B?ZEN3MHJVeGVTajZwaWM2MEV5Q2cwV1FmMkc0ZTg2VzkxbEhwcGNRZjNtYnhP?= =?utf-8?B?a3c4NndEdmhudEhVRmRJRDVxbFRrNDh2b2pPQlFKZCt6N2UraVNyTExXWHda?= =?utf-8?B?WHJPS0VlSDZmdGtPK1M3VVBPSEFwOUh4bDU0R2Nncjhoby93ekZYV09vVUg3?= =?utf-8?B?OFM4bVpwZlVSRENlejFXam1ITzJCTEVSRnRIL2puMXg5WStXcjVWMXRPMXlC?= =?utf-8?B?TVh1akx2VlpIUWovNEFEK2h5OWpCK2YyK1F1eEtCR0RMZ0Jjb3AzL1RWOENR?= =?utf-8?B?dXQzc3Y0Zm1XWkhFN2xhVHZFTUNORUxYRU8vTUhzVlo0UGtvQTVzZEE4YVZq?= =?utf-8?B?cHhML0ljbS9sSTN5ZDJTdkdoTXdYL1YxUTBucVptYndzSWs2ekg4UWZ1dzVF?= =?utf-8?B?L3R1MVd2bUp5Y0VDQUVQanIvaUM0cVFONGh2Vzc4QUpZaUJGWTZOK25BSXBC?= =?utf-8?B?ZEQyZUJzSXVrTTRBY2JYRmtTRTl3bUUyaHV6bzE2ZEFvc3h6T0svNU5LZ2cr?= =?utf-8?B?MUhhYVVDNkVhM2hXa2Y4SUEwNmVjUjdsVy9OL2loR0dtbEk3U2c2d0hWQmMy?= =?utf-8?B?cW9ySERENGNiN1M2MU4vc0thZkdiZ0g5VitXUlBvVkNwMlBQaitZbWhrb1Ra?= =?utf-8?B?SDg2MnhFcTdPeHQzbEhYN2Y1d2lDd25DeUlMUWc3b3ltekhpSkgwRDVRNDV4?= =?utf-8?B?cCt3VW5PTlU0VTdDeC9MRjZIN0RJbjFpTCtySWtVdDNMUkpyNXNDNWxwZEwv?= =?utf-8?B?TVdFQmJuZ2xKbm5qMU5Ea1U5RFRuRjhsMDd1SXpsajluWjF6clVlUk8xRklu?= =?utf-8?B?VEF4UnRGUTFjZ3MxR2V3aHNIOG1DdXVFcWExQUJtYzBXMWRRcm0rOFUwcVFa?= =?utf-8?B?elpEaVVsMHBqd1ViSFhhTWtCbzFZMjhqa2gwNllkV2lKdVR6dmU0TlBldll6?= =?utf-8?B?R0luVXhYY2hxV01jeTVOckdJSDJpanJXWFBHRm5ibXJaT1VEelY4ZW1EZ2Zp?= =?utf-8?B?MnpzOTAxb1VESHVkVmgyUUlTNmtUL1NUaWlGRmc0NnZhTFRya1FCYkxzei9T?= =?utf-8?B?bEhNUVpLTncwZUo1WWpTOWhDK0VZRWlHdGtodXZ5cmRYd2JLV2M4WmdaVzlK?= =?utf-8?B?OFRDUlVNdVN2SE52RWVBYVh4R2Z3SVZrUWdyZ29ua2Z2WVNyS2FIalZJaG0y?= =?utf-8?B?amV0RGNaQ2FyQ1VXcEwycFd2M0gwM1FNS0ZXWTFSckNjYVpCdUF4WWNKYVhm?= =?utf-8?B?em53a3R0dFBha2JSSm80UC9OcWdETThPcVB2QllWc01mT0VxeVhsaXZxSnMw?= =?utf-8?B?Nk5WRzdQT0RHc0FWSTF5aUVMVW9oQmR4MGs1UFN6OFRub2JTUDB0eE1Id1Fz?= =?utf-8?B?RmozSGNwS0dJSEExUjdVUTFjZEx5bXUwbktvT2IwMDBvcTJrb2gxdFZMRGl3?= =?utf-8?B?dWlWUDAxUFNERmtockdSVmhteUpVOU9xK09DZCtjaTVra002YnpDOExBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb3a81d5-befa-4fdc-2223-08dc562c5123 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2024 11:25:52.2256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0374 Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: sort options by name X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Stefano Sabatini: > --- > libavformat/matroskaenc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 566e9f4981..8ebe6e4334 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matroskaenc.c > @@ -3500,20 +3500,20 @@ static const AVCodecTag additional_subtitle_tags[] = { > #define OFFSET(x) offsetof(MatroskaMuxContext, x) > #define FLAGS AV_OPT_FLAG_ENCODING_PARAM > static const AVOption options[] = { > - { "reserve_index_space", "Reserve a given amount of space (in bytes) at the beginning of the file for the index (cues).", OFFSET(reserve_cues_space), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, > - { "cues_to_front", "Move Cues (the index) to the front by shifting data if necessary", OFFSET(move_cues_to_front), AV_OPT_TYPE_BOOL, { .i64 = 0}, 0, 1, FLAGS }, > + { "allow_raw_vfw", "allow RAW VFW mode", OFFSET(allow_raw_vfw), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > { "cluster_size_limit", "Store at most the provided amount of bytes in a cluster. ", OFFSET(cluster_size_limit), AV_OPT_TYPE_INT , { .i64 = -1 }, -1, INT_MAX, FLAGS }, > { "cluster_time_limit", "Store at most the provided number of milliseconds in a cluster.", OFFSET(cluster_time_limit), AV_OPT_TYPE_INT64, { .i64 = -1 }, -1, INT64_MAX, FLAGS }, > + { "cues_to_front", "Move Cues (the index) to the front by shifting data if necessary", OFFSET(move_cues_to_front), AV_OPT_TYPE_BOOL, { .i64 = 0}, 0, 1, FLAGS }, > { "dash", "Create a WebM file conforming to WebM DASH specification", OFFSET(is_dash), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > { "dash_track_number", "Track number for the DASH stream", OFFSET(dash_track_number), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, > - { "live", "Write files assuming it is a live stream.", OFFSET(is_live), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "allow_raw_vfw", "allow RAW VFW mode", OFFSET(allow_raw_vfw), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "flipped_raw_rgb", "Raw RGB bitmaps in VFW mode are stored bottom-up", OFFSET(flipped_raw_rgb), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "write_crc32", "write a CRC32 element inside every Level 1 element", OFFSET(write_crc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, FLAGS }, > { "default_mode", "Controls how a track's FlagDefault is inferred", OFFSET(default_mode), AV_OPT_TYPE_INT, { .i64 = DEFAULT_MODE_PASSTHROUGH }, DEFAULT_MODE_INFER, DEFAULT_MODE_PASSTHROUGH, FLAGS, .unit = "default_mode" }, > + { "flipped_raw_rgb", "Raw RGB bitmaps in VFW mode are stored bottom-up", OFFSET(flipped_raw_rgb), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > { "infer", "For each track type, mark each track of disposition default as default; if none exists, mark the first track as default.", 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_INFER }, 0, 0, FLAGS, .unit = "default_mode" }, > { "infer_no_subs", "For each track type, mark each track of disposition default as default; for audio and video: if none exists, mark the first track as default.", 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_INFER_NO_SUBS }, 0, 0, FLAGS, .unit = "default_mode" }, > + { "live", "Write files assuming it is a live stream.", OFFSET(is_live), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > { "passthrough", "Use the disposition flag as-is", 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_PASSTHROUGH }, 0, 0, FLAGS, .unit = "default_mode" }, > + { "reserve_index_space", "Reserve a given amount of space (in bytes) at the beginning of the file for the index (cues).", OFFSET(reserve_cues_space), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, > + { "write_crc32", "write a CRC32 element inside every Level 1 element", OFFSET(write_crc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, FLAGS }, > { NULL }, > }; > See https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320849.html Additionally I do not agree that sorting options by name is the best way; it should be sorted by what are (believed to be) the most commonly used options. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".