From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3F2394AB80 for ; Thu, 13 Jun 2024 08:49:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AAFBA68D96B; Thu, 13 Jun 2024 11:49:25 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2105.outbound.protection.outlook.com [40.92.75.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7E52F68D854 for ; Thu, 13 Jun 2024 11:49:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUfecu68D0Sg4lHiAikzoFG2UODE9kv3hUexkdg/YYL8/tahDN/g/g7FVqIp++sQXdBN8UezjZhD5R3LB1aQyyDc3vWW8VwnEVeWoh94DIjWIlDGQZHC0lZRcUiXEdGF4jupO+wZLr/x0lGBiDwp+db1E9uBoSR6fVZf0ZGq/ww1evHpSCqju70jIUuqNJUjiLnVGBAjgd7uyAhc7vXr8klYZ84QbO9zEchkEorHqTnaI5DYYtT1bZrGHCpKZ7wgL+JY1h8VB8ZSustCJyOglweWxZvC0W61qXSVWIcEbwdr2OqV0FaSICaJYc1GSqKEaqSukjb3F7QqCHqm1hHG5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F1z/UOTnZASQECmDNZR5RFwF9cmFmnKGbjBjNevS1tw=; b=kOU6SRI3pM6jD5N/Ihp3jKCnd4K8v9HuPvYxBZoX6HZncSZh45ruvI9PuVX87ahPa+owETsRvnigFJHMNYxDjjk9Gc6nXuPJ1b4yG26fu1wJfLT+Q0zyOmX6JYFy1mr5WXwkbbY2EfTihnF2WwKpoyaJef5n+0zHX3fq/YHJAVTpPcEUjAiVp/zj9DbqLtqatxAzb78oV7dlilD0/HHqqqfFaSD84+6SUB2ztuxK7CHHcE9/eF0JnGMxQnYos3pOJfqnlKhA22t57u7Z68GsKMTvq91ow09s4V+edAF5YimtHcjjIZkc/5lvkr17byiwBThjAMHc9fXtxUVPiz7/3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F1z/UOTnZASQECmDNZR5RFwF9cmFmnKGbjBjNevS1tw=; b=CczqydtZi3QMknYJbBpo4MqX2f2UCH0fZ+hxNhsx3fuVdMBs8DiY/OdNfRII1dxJdYs1ooWZZ6T6oaCchvCg9ZLEKNh4N4UzKZ+naCq02D/zzxKIXS/RazNXDn/t2KE/AxbAscyng4AeYjLVW7xOf6MByYrnDiWiZt+TrtJjC6ulQgoDscF5UxHXisSojZ1NgQT9bzn8vNYooJkd6awPWScgVrjCr760tQYnCC+Y6cHG8fIAhs6zAG9CJFyZLmpm0g9XEqrMDk3SadFG2MAHrB31Fzh0ilsSEzfBkUwhmuV/fgT0eq+EarOJwuDPUqDp8fr10HNerr+Rl3JLefYxAg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0282.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:371::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.24; Thu, 13 Jun 2024 08:49:17 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7633.036; Thu, 13 Jun 2024 08:49:17 +0000 Message-ID: Date: Thu, 13 Jun 2024 10:49:15 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240613082325.GD2821752@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240613082325.GD2821752@pb2> X-TMN: [tyt33GDzOYgEQ9z1g5dOQvz72dKSnbnq2UffLkTps4w=] X-ClientProxiedBy: ZR0P278CA0158.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::17) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <508ae6a8-03c6-4cc3-a0fa-51af4fd1d146@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0282:EE_ X-MS-Office365-Filtering-Correlation-Id: 51c7bdfa-ede5-4255-1ca2-08dc8b85b5bd X-Microsoft-Antispam: BCL:0;ARA:14566002|461199022|3412199019|440099022; X-Microsoft-Antispam-Message-Info: voeOQvPjUpda1cQjOH5iCFLhAKv+S1hUs+Hjf9HNxdBLnfa0DfwS8q2kmgwLYwZyh+UZD+4MeKfZ9kmG16yTvcAb1m4Ws/VPdqJuUE8AiMyZTN2BYaMbfS+TU7D4F5deKch7gGeNMOEVRQoNvNKwbdX5Ui5a95ZMe5xS9kT+QgwqyQz/2zt76XUc9OMWSiLoYiHmwSIVbA3WJxtVgo9pMiG7PClDg07xi52M86MX6dR8xoehpJpbQk4hmkQreR7jlgu+wTl06zvCBZCqOMzhDhVoj2LpxjIkvU9OBvsn7oDTX5RYZ1zGI0LhMEVHpJSJoQpOTCWldBmyR6p2eK9rDi00Czl7LdRdeRPzZnRfir0tLt7r9N+GBgfi6uMB9TJ4IYyYvLIY1kYrL2FeuwVAYLhHSkFmIRo1O0ON1opA/LCgoI/RD3V+/An/ur1YV92ejcKTYek1KvCjFu/qYf17N8VZ1swfBTUCmu6qHdkqJgxoi4lfwWGayhuVlinRfa2TsQhv1ovdaPyDqE3Hv+moN7EqsfuJLA4uskcmqPohnlWKQJNkqHfpKLxqIpt8Hd1w X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDBtZXc0S0NzenB5QkFQcHhzNThSLzdid2w4TVZnQTBKUjBjUGtjTzUvUXZU?= =?utf-8?B?eklzYm5TRTdpcWVBRXJGdmhheXhlQVlvOEdBK3M1VFJHS2VRNnhDZ0c1aTZk?= =?utf-8?B?L1ZWbWg3VklsejVlZFN2WFV0c0FvL1R1aXNSdzF4NG1tRXFhUTZ4dDlNbk5n?= =?utf-8?B?Q1dQbkcrVEJoUEdoa25peUdWMGl2SnZpbXhWNnI2aTVLZEl6S1VkbXZxMXFZ?= =?utf-8?B?WHFDdWtpc0EzMkRYQWUxZG91dVBzcXE2SEhqRTJzNitJVFlJRzNKZW9LQ0sr?= =?utf-8?B?aFhiUlJzRzMzM3ArbWErYzlreThRZFNFS3pmYWpUeGdCblRqaEZnZXJoR3kz?= =?utf-8?B?aENiRDBrcmRWUVZOdTJHRmF4bFVQdXE0WFRCaTQ0cmRIUzU3T1Y2V0w1U0pj?= =?utf-8?B?VjRXZExNbURLN1k2dVZ4Z0ZtbDhlSkJPYUY2Ty9GOVVyaEhnRkhzcTJ4MVlO?= =?utf-8?B?YkIrc2xxK3I4MndUN2p4YndRcEdNbis3NjNkUU5pNXJEL3VOS2R5MEpkdGNs?= =?utf-8?B?eVdUSGdJQ1c1M3JzVk5lUUNsckk2MmZIVXROMHptaDdTcktMUFJ0RzB2OEJx?= =?utf-8?B?Y1BGZ0ZxaC9mWjl3VElVWkhkZzVPdnFpWGxNTHdNUmFJR2tYNjhoWmRLOVNF?= =?utf-8?B?NCtRa2JDZXpLY05MWXpKSHJ4Y0lJcGhPbVNUNDkzNU85ZFVjNEMzbWNzVURV?= =?utf-8?B?SEpPTE5iMWY5dTlzNGFlVlltZCtVVEwzWnd1b04rZ2RhRmIwQTJCbmMzY05P?= =?utf-8?B?dkhPeDVOOFhsTFRMUGxKTDgrWVNwd2xFUE5jOWJIQjFFNmRMTDM5c0lKR0lO?= =?utf-8?B?NmxwRVdhL2l1dVB2KzVuR2lkV3IvcmdUM3EzWVpZamJKc3RyYldmdTdrZWJT?= =?utf-8?B?T2IxcjVjcCtuQU9sc1B1N01nNjJXNm9iYkZIOTBMdCtwNDZ5bDRDZGZ3RU5S?= =?utf-8?B?aEU3MmpWR29Wci9UZUliNm9WTjFsaU5VRUVOSkpMcVhqVkJiVlhKSDgzcktM?= =?utf-8?B?UG01MytWbnpVYUloQS9wZDNjdysrQzhqNXB3YVNnZEtMZlA3ZlN0akthc0Iv?= =?utf-8?B?YS9NQTlPcWhkMGdtZ1g5Ri9lVjQ1RzhIVlBXNVB2NGVCWVZTUWpQMFlnTm10?= =?utf-8?B?ZFkxSFROd0hRSmNFUGoySVgzeGpLdnVseUlzR1pJVVpSQ0ZtQTNCWk1aTFM1?= =?utf-8?B?aWpVSEpSUndnSTNxTlJ6aDlUM1h6Ynl1MWxocGdSOFRBUzNWSjN4RW93dFli?= =?utf-8?B?b09Vdjl4WlI1akN4eDErWlpBVVZqMkdrL28wd3FiVnpXMGh5M25nbjJKUktU?= =?utf-8?B?N2xPS2NST1dEdnhUWk50ZjhyVkp0MmllWC9kWVY3L1gweHdvajBSWGlaNXRR?= =?utf-8?B?REJCUkN0bmdpb0Jwd3lvdTdsVUNpQUlTRHlZMlJIZW1nWU0xa1FoZkNRb3ll?= =?utf-8?B?Sm5oZFZML3FGaXVyZ2FmdGgvZ1dHck04bUdJeE82cFlTck4rN25NdURHcDhK?= =?utf-8?B?bHZOZDBZbU5mbVVPTGtlQnJZNnQ4MzdEWk5VNGNxZ1FYSFZxVnd4OC9BR0dM?= =?utf-8?B?cGM1MVc3MVFJaXV4WUJwbDVrTEVwUitVK1k5RmxhTHNCWHVTQlBZSHBoczAx?= =?utf-8?B?dUJ2cFZNUHh5T1ZtemFDSGovQTBrOXVRS3JoN1NFcmNRVXdBUStDOXltRnk2?= =?utf-8?B?bTNVTng1VDZBS0s2ckNsaGxrNXlJallkUk5wUkFISXVRQXZhWkJhZXJ3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51c7bdfa-ede5-4255-1ca2-08dc8b85b5bd X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 08:49:17.8213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0282 Subject: Re: [FFmpeg-devel] [PATCH 12/57] avcodec/mpegutils: Don't use MB_TYPE_L[01] for mpegvideo X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Jun 12, 2024 at 03:48:08PM +0200, Andreas Rheinhardt wrote: >> MB_TYPE_L[01] is based upon H.264 terminology (it stands for >> list); yet the mpegvideo based decoders don't have lists >> of reference frames, they have at most one forward and one >> backward reference. So use terminology based upon this. >> >> This also has a second advantage: MB_TYPE_L[01] is actually >> an OR of two flags (which are set independently for H.264, >> but aren't for mpegvideo). Switching to different flags >> makes the flags fit into an int16_t, which will be useful >> in future commits. >> >> The only downside to this is a very small amount of code >> in error_resilience.c and mpegutils.c (the only code shared >> between the H.264 decoder and mpegvideo). > > Cant you just call the flags differently but leave them nummerically > the same, if you dont like L0L1 terminology ? > > Having each codec be different does not seem to me to be a good thing > It adds burden to every bit of common code. It may be thats error_resilience > ATM, but there are other things people may want to add, like an universal > encoder for all the block based transform + MC formats 1. The terminology is only one part of this: Using the same flags currently adds a burden to the mpegvideo-decoders, because their mb_types don't fit into an int16_t, so that they can't use symbols tables. See the following patches for this. 2. Furthermore, it is not "each codec" that has its own system of defines; it is only H.264 vs. the rest. And even these two systems are mostly the same. 3. If you create a universal encoder, then you'd be better off to use your own MB_TYPE_ defines for it and not to reuse this system here. In fact, mpegvideoenc does not really use it (it uses its CANDIDATE_MB_TYPE_* system). 4. And I don't think that a "universal" encoder is even a desirable idea. An in-tree H.264 encoder would be very complex and all encoders would benefit if it were not tied to the other encoders. Apart from that, x264 is a thing. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".