From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4D0F54407A for ; Sat, 25 Mar 2023 04:46:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3848868C761; Sat, 25 Mar 2023 06:46:34 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2038.outbound.protection.outlook.com [40.92.73.38]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C67E68C761 for ; Sat, 25 Mar 2023 06:46:27 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGx/D1/AvXZS5HSNBxAExtIex+R1km11EIv+dnP5m/tEhN2aVEmFITDaCeWwv1ybP38VypDsQfvtUxFBOppYfHzhg3ZYOXBAqszyToaZWYwH4eZruzf+bTeEEDXiSdB4KW+C3ymgMEJoNAhjed8wIpWmIibBp2l1yas9dLmNWBL6zdFNaq7F/ebCZXFli7KTyWPeUMecm9KriK1c6aEAxcI3RW8BlVZq5gaXAijSRGCZwHnzEUVePZ6So9ReYFjz8/DSNvbyIjBvzrMALV36qFBLz5PFAxofYxrIP5bFYYDLLjUnZ12PYR9hzm+wB04Qqvf6Ed836+ENijLORb2+kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M7kyOTYDSse+HB5LfkQpGcwrfCY+eyYsX/hxjKTFuDE=; b=SXrT6jIgJld1joH7sZgy9sa2RZO4zfU3vloBvgdcFIdYAicQu3fojF47Nu6frc8/vMjrHWHhOx3HKn5fCbJIneObKuYgdHtoYLREg5Z7ZeyHVv78pC9KrAYEDp9cn8NsFavExPus5yO2/mVZ1aDyMMcoTxiFj9oXN+Hpt6D7ESFv0ZUAJ8OukGJSobw2jUrOI2IDWOHBlkMZqu6TLFP7WzSxZzTBnasM8bmp2loJr57ZLWx/P1sWG3xeMpsSxFZZxNK8YFku2VpBggsoDJdRIDh8OlGKsf0edA8PzssQ2JixNT6TO2n4qwQHvPkNqTOkQJ4Sya19OIKlcs4zFm8hxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7kyOTYDSse+HB5LfkQpGcwrfCY+eyYsX/hxjKTFuDE=; b=TjXLfB+f7hfArhCuAMvRHQbteH1xCHiLND/7K0A0zgw1W1PWLC95vNl55VfE04fu5ywkWndB5T61nBdHiGDroAwtpVSQ0dlneSQ8S5VMYaoig7ti5QUuJ17cZ6V6tNpjyacgoX230zgca0FBCm/839qIIf3rzmh5OZhXQp1KikP07KknvAR2b+eX2v6Yr+aEu9sjRFtEghVFtbN/iRkPFgqMnAEl5COZ14A37ypvMnwDIwFhcrRGelk0OsFMcH/HLVqeB0vwAX9j0xsRnlNYDIL08UzPTHsqW8aaP1tF58yTtUhSsM9Sr5CpvRbRKHt5/EZjX0QlT2UZ1KGVkuseZA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0370.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.8; Sat, 25 Mar 2023 04:46:25 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::bd9b:b9f7:e94a:109e]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::bd9b:b9f7:e94a:109e%8]) with mapi id 15.20.6222.010; Sat, 25 Mar 2023 04:46:25 +0000 Message-ID: Date: Sat, 25 Mar 2023 05:47:01 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230317150232.17804-1-dheitmueller@ltnglobal.com> From: Andreas Rheinhardt In-Reply-To: <20230317150232.17804-1-dheitmueller@ltnglobal.com> X-TMN: [LteZasZJWzVHFCy8wV1zXU962oMl/MdfbDEhy/sVBzo=] X-ClientProxiedBy: ZR0P278CA0056.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <04bca278-0691-0ec7-8cd1-c9ba8bf695a9@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0370:EE_ X-MS-Office365-Filtering-Correlation-Id: f3eff33a-c83e-403b-9ecb-08db2cebe364 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yhJ47On02JvrwxV5DbhJi/hs0r/A41pJxkSzG6K/0Ibh432RS1SQ3LAyDbvEZDVWduY1C1eeK/b+vTqT9ki6FLgQZB93ZiJ7/Knn/4K5n76WX4xRAMrkefVEXPyy2E4lx8Cu2RQTPmSbcyIb8LcV2ZfA0w9cYFqh3BmKXXZsznefYJseWPR/k47lz+7K4u6FUPC0oogr59GFPpyQseYahidNP08ny8T/oufPG2CsV537WJpmHctj6gNxJF1mF4h3ojopCJO7jVn5UvS7c/kCbNL6I95qf5qZVUC8bxbzTCunI25GboCAEmEXHm/uGMlq5kGaimCXR7ZomZlph0/qxDmn9hvof0GG2xIVcg6VY38rthlOSuqEH3kANX0ukp/iCcPyCOi6L+0GhFAYlbcIbtLdt31LwHiZ3MHnYYHb/jYpB7idQnbsdHzIdKyYvVBNczAHKtzwQ+jbi53X6LNdolwsk+bTpY1r7ETmG77nIPz3/kwfA4R93VJ0oEZlQiu3wytXMyhdZ9JxVxbfAebuCjLw1GzmOpUveMkPcOeLDh6L2LaMrP5V89t2puPE6w5rIn5pla3YGLHdYq4K8rmp1Irp3W3LGQGQkBlECFYIlujAL1u4JqMLrNrWhxWCEApq X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUNsWlFpUk9xeXoreU9yeTJXV3h3S1RpdTJpdG9uTHNRQU5jU0xuaXVablh0?= =?utf-8?B?UnFtUCtrYmZnM1l2Y3d2VUpSMFhab1FFQ2lya3NVQlRvb1I3cGpyQ0dKZ1hi?= =?utf-8?B?L1ZMcmt1SGw1VUV0eTRZNU5zRjVJaWwzdnlvenpkUkozTVUwNmQ2RlJ1Nm1R?= =?utf-8?B?RTZ5UWk2QndBVjk2VEs0MldDRC8zdWFGVHRNSzB5eWMwcFNISlI2R2EzeVdO?= =?utf-8?B?K25Vcm5TNnltVUlIM29tVGQ4ejdCLzAya1RYSkJWRnVrS1JoMVpqNzdscWp0?= =?utf-8?B?LzFKcy9memtOMWQyaThnQXMrNUI3d3J1cDZkVU1aMndDaUx1VFQxUVJabGxu?= =?utf-8?B?Q2V6Vm81TWlWQklEMGZEVERVMUI4cER4Uk15OTF0bGZONWpFQzdTZ21QSjRR?= =?utf-8?B?WEtOc0s1S0dtSENsSGFZcmZSNUdqQ2tpMGoraEhzNEp2YnpoV3grZklocmRt?= =?utf-8?B?N3JPVWh5RmNldENtWkVsKzZzQTF1WnE4V0wvK1VJbGNKQWgzNkpMQ05LdktN?= =?utf-8?B?MlBYdU8xTk1ranFNQnNaUDNVZ3ZGVWpEalFKN01DdUpicDBTcDRaNUJsZDA2?= =?utf-8?B?b2FMZSs0emVXcWxid1EzOWhVZ0liekJ3UXJIdjg4QTlVQ0N1T3VrTlZmQ3Ju?= =?utf-8?B?ZnM0a2hhcUtVRGVDV2hyVmhzUFl5UXVlck9HZElUM0hkYWtNNndiMDdMc3dm?= =?utf-8?B?YWVvNmZ0MzF6SXJGazhnU2RjTUw3NDl2U2ZBallXM2R5OG1WUjZhVjk0eUJi?= =?utf-8?B?dlJrV0tyT1BLQW5KVkZZTFYzaE9qTnc3VTM5TndGdXNmUzBnVjBDZEFmNmFN?= =?utf-8?B?bFdPOEVMZFdoeWgzRE1Ga1Vvc2pwSlRHMmQ0b2d5c1BpaG5zb2U3dzFodklO?= =?utf-8?B?V21uQ0l2TnZxQ2p6NDlRK1k3bmlLdHZZL2Z2RTF1SFpocDQ2VkU3OWVBL0p2?= =?utf-8?B?K0RZa09TcU8rNmlDa0JESXQvVklsMmI0cFRGUTcyVHdzeFhsak4zMlFYVExG?= =?utf-8?B?dS9PaFdXQXVVRlhQNEFPa2pCeVplLzR2dkVvVDNiZFdMNVM2Q2c0ellRdldV?= =?utf-8?B?ZW1TSXBIS0ZXdXpiRTIvbkpIZmQzUUladXB5UlY5ekM3dlM3QnR5ODVEejdk?= =?utf-8?B?TUVkSkl6SjUyTHBSYmJCRHN3TjBWYkx2bTZtS1JkTWJPMytaQ3NGRGk0SEN6?= =?utf-8?B?UjRVSFFwbjltWTltcEdEVEFzRnpFS2QrYXlNWUtTQnVJell3RnZHNnVTV0R1?= =?utf-8?B?V3ByRmpRcC91YmszeXRJL2xGY1djOHpRZk9XK2d3c203REI4Vm1Nd1d4c0cy?= =?utf-8?B?SHRkZHVobm9EdWpTK2w3ZXNLVm1DQnl5VEtQa2VHTkU0YWNEeXFWY0RkaUFw?= =?utf-8?B?SjIycjNnRS93cDRJS2ltUmo5RnRhQ1VWM1Q3S00yakk4YzJaYUpKcy9mRWNJ?= =?utf-8?B?UGo5ajloVXNxRUpsU28zczBJMmJNeHAzaFIxNTBzU2g4dXltYjA5cWI2WUVU?= =?utf-8?B?QmtoTjV5cys4QzIrVG9KWTFFbmNwbkhOTTFoditHYmZONkcyYWxPOFlzbVFr?= =?utf-8?B?Y1k0RUVpbmNIUUdNRnBGM3BqelpMN2VXNkYyTm9KdURCTE80T1FjSHdvSnZR?= =?utf-8?B?ZkdMaEdSMGVtUm02U3dFMzVWWkVJTW9RZEU3UXZTcnY1WGJFdCtzWFEzY1pu?= =?utf-8?Q?RDkFF6teuZO5+xd0CYuG?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3eff33a-c83e-403b-9ecb-08db2cebe364 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2023 04:46:24.9471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0370 Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: Fix warnings with signed/unsigned compare in bitstream.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Devin Heitmueller: > When including the header in decklink_enc.cpp it would be fed > through the C++ compiler rather than the C compiler, which has > more strict warnings when comparing signed/unsigned values. > > Make the local variables unsigned to match the arguments they are > being passed for those functions. > > Signed-off-by: Devin Heitmueller > --- > libavcodec/bytestream.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/bytestream.h b/libavcodec/bytestream.h > index d0033f14f3..67080604b9 100644 > --- a/libavcodec/bytestream.h > +++ b/libavcodec/bytestream.h > @@ -180,7 +180,7 @@ static av_always_inline void bytestream2_skipu(GetByteContext *g, > static av_always_inline void bytestream2_skip_p(PutByteContext *p, > unsigned int size) > { > - int size2; > + unsigned int size2; > if (p->eof) > return; > size2 = FFMIN(p->buffer_end - p->buffer, size); > @@ -268,7 +268,7 @@ static av_always_inline unsigned int bytestream2_get_buffer(GetByteContext *g, > uint8_t *dst, > unsigned int size) > { > - int size2 = FFMIN(g->buffer_end - g->buffer, size); > + unsigned int size2 = FFMIN(g->buffer_end - g->buffer, size); > memcpy(dst, g->buffer, size2); > g->buffer += size2; > return size2; > @@ -287,7 +287,7 @@ static av_always_inline unsigned int bytestream2_put_buffer(PutByteContext *p, > const uint8_t *src, > unsigned int size) > { > - int size2; > + unsigned int size2; > if (p->eof) > return 0; > size2 = FFMIN(p->buffer_end - p->buffer, size); > @@ -311,7 +311,7 @@ static av_always_inline void bytestream2_set_buffer(PutByteContext *p, > const uint8_t c, > unsigned int size) > { > - int size2; > + unsigned int size2; > if (p->eof) > return; > size2 = FFMIN(p->buffer_end - p->buffer, size); > @@ -348,7 +348,7 @@ static av_always_inline unsigned int bytestream2_copy_buffer(PutByteContext *p, > GetByteContext *g, > unsigned int size) > { > - int size2; > + unsigned int size2; > > if (p->eof) > return 0; The bytestream APIs are allowed to overread if the buffer is padded and the user manages this himself. So you are not allowed to presume that g->buffer_end - g->buffer is positive. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".