Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 2/9] avcodec/utils: Support APTX (HD) in av_get_audio_frame_duration()
Date: Thu, 15 Sep 2022 21:28:02 +0200
Message-ID: <GV1P250MB0737E5369D253437B5A382D58F499@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB07379524B6965693D412DE238F499@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

APTX decodes four bytes of input to four stereo samples; APTX HD
does the same with six bytes of input. So it can be easily supported
in av_get_audio_frame_duration().

This fixes invalid durations and (derived) timestamps of demuxed
APTX HD packets and therefore fixed the timestamp in the aptx-hd
FATE test.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/utils.c     |  4 ++++
 tests/ref/fate/aptx-hd | 17 ++++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 2f57418ff7..ba64aaf32d 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -682,6 +682,10 @@ static int get_audio_frame_duration(enum AVCodecID id, int sr, int ch, int ba,
             return 256 * (frame_bytes / 64);
         if (id == AV_CODEC_ID_RA_144)
             return 160 * (frame_bytes / 20);
+        if (id == AV_CODEC_ID_APTX)
+            return 4 * (frame_bytes / 4);
+        if (id == AV_CODEC_ID_APTX_HD)
+            return 4 * (frame_bytes / 6);
 
         if (bps > 0) {
             /* calc from frame_bytes and bits_per_coded_sample */
diff --git a/tests/ref/fate/aptx-hd b/tests/ref/fate/aptx-hd
index 0691f33c86..498b9131a6 100644
--- a/tests/ref/fate/aptx-hd
+++ b/tests/ref/fate/aptx-hd
@@ -6,10 +6,13 @@
 #sample_rate 0: 44100
 #channel_layout_name 0: 2 channels
 0,          0,          0,     1024,     8192, 0xa99888c6
-0,       1536,       1536,     1024,     8192, 0xc3e03a3c
-0,       3072,       3072,     1024,     8192, 0x3f06e090
-0,       4608,       4608,     1024,     8192, 0x92fb18f3
-0,       6144,       6144,     1024,     8192, 0x3d5603a2
-0,       7680,       7680,     1024,     8192, 0xcc3d3101
-0,       9216,       9216,     1024,     8192, 0xbcc022ef
-0,      10752,      10752,      273,     2184, 0x9873af57
+0,       1024,       1024,     1024,     8192, 0xc3e03a3c
+0,       2048,       2048,     1024,     8192, 0x3f06e090
+0,       3072,       3072,     1024,     8192, 0x92fb18f3
+0,       4096,       4096,     1024,     8192, 0x3d5603a2
+0,       5120,       5120,     1024,     8192, 0xcc3d3101
+0,       6144,       6144,     1024,     8192, 0xbcc022ef
+0,       7168,       7168,     1024,     8192, 0x600cbb73
+0,       8192,       8192,     1024,     8192, 0xdc938cbb
+0,       9216,       9216,     1024,     8192, 0x37d968bc
+0,      10240,      10240,      785,     6280, 0x48243144
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-09-15 19:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 19:23 [FFmpeg-devel] [PATCH 1/9] fate/audio: Add tests for APTX (HD) Andreas Rheinhardt
2022-09-15 19:28 ` Andreas Rheinhardt [this message]
     [not found] ` <20220915192809.2761301-1-andreas.rheinhardt@outlook.com>
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 3/9] avcodec/aptx: Use AVCodecContext.frame_size according to the API Andreas Rheinhardt
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 4/9] avformat/aptxdec: Don't set AVCodecParameters.frame_size Andreas Rheinhardt
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 5/9] avformat/aptxdec: Don't set AV_PKT_FLAG_CORRUPT mistakenly Andreas Rheinhardt
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 6/9] avcodec/aptxdec: Process data in complete blocks only Andreas Rheinhardt
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 7/9] avcodec/encode: Redo checks for small last audio frame Andreas Rheinhardt
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 8/9] avcodec/encode: Enable encoders to control padding of last frame Andreas Rheinhardt
2022-09-15 19:28   ` [FFmpeg-devel] [PATCH 9/9] avcodec/aptxenc: Process data in complete blocks of four samples only Andreas Rheinhardt
2022-09-18 20:46 ` [FFmpeg-devel] [PATCH 1/9] fate/audio: Add tests for APTX (HD) Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB0737E5369D253437B5A382D58F499@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git