From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D48EA4A34C for ; Tue, 26 Mar 2024 21:40:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2323468D67E; Tue, 26 Mar 2024 23:40:06 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2034.outbound.protection.outlook.com [40.92.73.34]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 49B1A68D677 for ; Tue, 26 Mar 2024 23:40:00 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6hsHJAuFkDsJVXcM6cOPEy9wKSaxVhbBfiHrZn2ZqX8RytWCoZRX7hdU3vmStK9hi5PBp9af44kb8J4j1gGgK6BLKwmLXDWDF0vMLMoMWUzartQZGG6W6e9KP+2jc96P5Z/rZrpQpRQXSg3fRSawhcmpJy6hoZ1X8LUwl7MiXZNZaGLJFiGanFs6aPV3J2zeOZantdhPhJ/eG++dkTS90MsYIO/NiYUU6gbAVeAhERNz76KoAqsiRtHUV4cCjjY+QruLhk5K7d2VukFN5WdoM2agczzrBi6OEIKdxFLGHokziNYvpXvn9vcVy7EeHj2wQUXUCPL0d93N2P6sITIlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nv0G7pNc+oJx4oxMIq5AfOwqt4hOXe2g+t4xWDoMRaM=; b=el1w+keZFs0Y96cTKc4pjt7wFhKw9H30UW8kx140ni5E6RMF/332KIshZKID2zKMGn2wZcNqvKO4XGV2+tY5wnnZDQ+0a6GSgrU2BMnrMExfWrMz4EVSx0rEQOMAL8DwoQKTrQt1XE15s5svsN7Qq663ZDuDp/xm8FsWwdnH6vSETCEai8rGMiPApemTEl/5D/s7EVyn9dCkwkWUgD9oeJaASGVbzKudJAzGkIgX+mAntjj/wqkQMDfqbFqZtr5TKYrMu4m0UYaSS4AsqUvEKc2+bVdSEdz+a9NEU4BakpPORTDFGDG0tmtaYLbq0p/tOnK/YA4N6wcllg9oOWSaFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nv0G7pNc+oJx4oxMIq5AfOwqt4hOXe2g+t4xWDoMRaM=; b=ZO6gT1U6FC8munekltc5rqfpWsVNeFzJGPpVmu2oMUZMWfM8hTSuKBYJZKk3wiuHdR5QaWdGrWoJRoShhK0y2cCRP5ndzgefPsfsL21eer6GbpXrlL8mwVyg9+rfCa7Mp1uHuCL1i/1Diu2eNBfK0sUx00eb5T3+D9Jt47DoRWoyBic0FIM7EZf55yQXH66fejj7J+BxgiDqG5TOzMfXDTfz9cJ4MwMHzaxa3QQYpBUjrTDIWi1wC8ol3r7yOwL2mXy7Fz3EF7yp4kVgW7vz+sy9BwcCifYULq4Abh+Qvs7QQw8KP4Zg7wgrk+PZaW3BROZ9G4RVWbc+/dG11+yekQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU0P250MB0530.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:34e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 21:39:58 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.028; Tue, 26 Mar 2024 21:39:58 +0000 Message-ID: Date: Tue, 26 Mar 2024 22:39:55 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240326164739.153011-1-asoulier@google.com> <20240326164739.153011-2-asoulier@google.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [2OkBLJkZezBAqs2I6yn8vazaKaR8AA05UK1HUebnJI0=] X-ClientProxiedBy: ZR0P278CA0086.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU0P250MB0530:EE_ X-MS-Office365-Filtering-Correlation-Id: 401956e2-acc2-4637-2a42-08dc4ddd4895 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 07HLxBrOqXMNiEYTMEd0qjwER8c2g3D6HAidJAVoWVJqbOkOgVUcIiGgJwHJMliWqskwK7HZGIRPQbcDPRGtMorGwYDSNEjH6UqBBu7XwnucDmpZWXtwqRmjRlgRhBWtHF6GsbCqqzNxDBe18gJrWwHeQKuo3CiXGR1Ja5bciA9vy2eNS7ZNREppiRGmxaWOT0uH382bVkuabCsb3bx6wV2Zt6WZgDSq6MVvbuMuKWONy2JyICWji2LK3bbToivYke5Uu/r9eg9cETU++DhUE+qeSKlmYhvnZsKlQ5SnT9duUq8ifu5/JfGOWFm2F0+VgY1nUdO+Dt6MbVdcPaA/QjcW+bUxn/02YtIFoUfqxF8R6XDmh6RYen4CtkLUDXpMJ+5Zqas+qAODCkxXS6o7MqDNs9CSML/sxVPie20BwRks2nRW7oIjbVwSKF37N/4KyMXVBnTFF1WQpDjqravjBfhtaElu6sNkwGixQIkyZvgbIRp7wTupFsM0KiFx/pC2GKle6kryO4JFb2YFA4L7KR+l8jFlNo72VvqnA0CDQyzL7wUlUfz2pkFuud0X1nz1 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmR4NHJjeTM2T0swZTIwT3hhS1RpWWRYQnlnNlVsSzNiVWxyQnoxRm1ZaWxN?= =?utf-8?B?VmJaMFZWZXdCL2VxLzBsZDZzWDdhSDIyVlpWeHVOQ0FPaFhVb0hQMlpNcEp3?= =?utf-8?B?eERXS0dacUY5MWFyekp3NVdZNndKdVcyQytMdHBRVTRvNTF6cC9qV3VrL2Yv?= =?utf-8?B?QkdzMjF6anJlbFhkK3NKTFU0VXI3V1hDZ2hEbG5ZckV6dEpKV1ZkaTYxS1JW?= =?utf-8?B?aHNCSDgyWWJFS014ZGNmcmNuMUc4VkxiblVxWS9ZdVZ6TW55R3Z2UENjTFFE?= =?utf-8?B?empPZm1RRGRWYUY4ais3ZEJDcXNITVc4RHMxRVVLU0hlUTM1bG1zelZGOWdh?= =?utf-8?B?SVdKQVFwTW44MFh4dzBWK2hpQnRjWDJqZ2lUM1RoRWJZNG54S1Z2Z0JrVGJi?= =?utf-8?B?V1BBeHllR0FpNFh3NFE1Qmo0dlBxMEF0djdEbVBXa2tDdERqbmdaaG9tN1NR?= =?utf-8?B?ZkVzZ212TTFtT1BhRDZVNlpMczRjZ3JQMFZyempzWTF5RThVeGIvWEFxZFlQ?= =?utf-8?B?Zko5N0JUUjJUR3BHU3MvdlRCdXVwaVpyTmRwUXVRQk1RSWZkV1VkUFkvV04x?= =?utf-8?B?MzY1dnd0eWUwK05oRFhPbmxFZU55aEhISkF2VitnQXNXamVMSDBPVjl2VU0w?= =?utf-8?B?bjA2cTVzaDVjNEVEaGs3VWg3REVaU2VvODAxMnRDejBkb283UGhUbWc4WjlK?= =?utf-8?B?Rmd0WGZETzFxRS9JeDkvaDU2alh5SW9MOVB5S1o0RFdnWG9aeDdKREtLcjMr?= =?utf-8?B?NGI5Vkd2SjFvSmwwSnRkV3EreHB0cTlOZmR2Nk5hNUR1aWh5dzVZbjFEWlZN?= =?utf-8?B?c1pjSVJZdVZRRmZiNVQ5NjFsSWF4VTRmMWVqaFNhQ3NYVFRVUG95cTlEU2dT?= =?utf-8?B?b0ZrV0hzd3RVanA0alV6UldObWhNZDFyVzR2cUtjU2dCRDJkZXg3RWFiUEJ4?= =?utf-8?B?aU9RQkVGbmxVODdQanIwOEZ4NlRFL3J2bTUxSWc3TUJpR1dQRGp0R3pVRzd5?= =?utf-8?B?eDhmL2hXa05JUUtHSnJqQnFrMmFQeUZ6emQ0V1laTS9VUlk1K1crby9qbWs5?= =?utf-8?B?QjZQalBJck5WYk5oMzgzbkVLaFZ6S1JkY2tLV0ZQUkhFOTFBdXdkZjg2Zi8v?= =?utf-8?B?N0tzRndQOHkvRmg2WmxVVUs1TndEbXZRN25sOE9Wa2YrWm85N3lxU1EvV1VE?= =?utf-8?B?cE50UjRuOS83WXp6dkxJbDZNVEhBOEYyTlcrSnJlQ0NySkNtNnVDRlJtY0U3?= =?utf-8?B?WTJpLzFDV25nV29xY3Y5VXBIVU0wZXVaSGd5L3VZNWpMVzhETTBxUG5zK1J3?= =?utf-8?B?TS85S29IVDQ1dWpqWUlZamtjdVB6TDBxejEzZ2Y1V0ZtZExBdUw1ay8vNGM0?= =?utf-8?B?U3lrWU5ZT051djVxQnZySjNxdEtqVGJMWkN0WnFOMzY4emRMRDdCR3BYVEls?= =?utf-8?B?N3UzYkY5UnEzRmk0WXo2cG01RW5PQUpOMzFtZlNvcVFWN3RmdFpWL0ZualZs?= =?utf-8?B?cnZ0MTFuWnlCMlNhblZISlFPZGxDVVI3OTV2cFNxaTRzL05Pcmsxc2x5OGE5?= =?utf-8?B?OWFWVkQxRzc5R0N0Y1RwOEVoTnhqTUJWYXB6b0JqYUxOYnJiUUszYm1zSzdP?= =?utf-8?B?L1BGdkhOWGRWNkxvc2VYSHlreld0R3hHUExVWTZQQ2lJZjRoNk5tVmNlSzZD?= =?utf-8?B?cVpwU0tHakJPczNzQ21aRTRpOUFqcHowS01VZlIzZjNTTlR4UTBJK3hRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 401956e2-acc2-4637-2a42-08dc4ddd4895 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 21:39:58.2205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P250MB0530 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Antoine Soulier via ffmpeg-devel: > 1. Thanks, I will add the caps. > 2. Yes, the `lc3_hr_setup_decoder()` returns the given memory address (And > do not write anything when 'NULL'). > But bad parameters also return `NULL`, even if parameters are already > validated elsewhere, I will change this call to be more clean. >> "What makes you believe that this is the only error that can happen?" > The "lc3_hr_encoder_size()" validates the other parameters. > 3. Yes, I will. > > For the change of the codec ID, I did not know how to implement it. > There are 2 codecs covered: > - LC3, standardized by the Bluetooth SIG, free to use over Bluetooth, and > should only be used over Bluetooth. > - LC3plus, a sibling of LC3, defined by another standard, (ETSI TS 103 > 634), that can be used anywhere. The chosen parameters conform to one or > other. > Should I declare a second FFCodec and add an option "lc3plus" ? > 1. Stop top-posting. 2. I would rather use only one codec id. There is no point in distinguishing them on the AVCodecID level. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".