Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Antoine Soulier via ffmpeg-devel:
> 1. Thanks, I will add the caps.
> 2. Yes, the `lc3_hr_setup_decoder()` returns the given memory address (And
> do not write anything when 'NULL').
> But bad parameters also return `NULL`, even if parameters are already
> validated elsewhere, I will change this call to be more clean.
>> "What makes you believe that this is the only error that can happen?"
> The "lc3_hr_encoder_size()" validates the other parameters.
> 3. Yes, I will.
> 
> For the change of the codec ID, I did not know how to implement it.
> There are 2 codecs covered:
> - LC3, standardized by the Bluetooth SIG, free to use over Bluetooth, and
> should only be used over Bluetooth.
> - LC3plus, a sibling of LC3, defined by another standard, (ETSI TS 103
> 634), that can be used anywhere. The chosen parameters conform to one or
> other.
> Should I declare a second FFCodec and add an option "lc3plus" ?
> 

1. Stop top-posting.
2. I would rather use only one codec id. There is no point in
distinguishing them on the AVCodecID level.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".