[FFmpeg-devel] [PATCH 1/2] avdevice/android_camera: fix missing include for usleep

[FFmpeg-devel] [PATCH 1/2] avdevice/android_camera: fix missing include for usleep

[Zhao Zhili]

From: Zhao Zhili <zhilizhao@tencent.com>

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
 libavdevice/android_camera.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c
index 1934999c18..0425b27518 100644
--- a/libavdevice/android_camera.c
+++ b/libavdevice/android_camera.c
@@ -25,6 +25,7 @@
 #include <stdatomic.h>
 #include <stdbool.h>
 #include <stdint.h>
+#include <unistd.h>
 
 #include <camera/NdkCameraDevice.h>
 #include <camera/NdkCameraManager.h>
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/android_camera: fix missing include for usleep

[Andreas Rheinhardt]

Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> ---
>  libavdevice/android_camera.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c
> index 1934999c18..0425b27518 100644
> --- a/libavdevice/android_camera.c
> +++ b/libavdevice/android_camera.c
> @@ -25,6 +25,7 @@
>  #include <stdatomic.h>
>  #include <stdbool.h>
>  #include <stdint.h>
> +#include <unistd.h>
>  
>  #include <camera/NdkCameraDevice.h>
>  #include <camera/NdkCameraManager.h>

Sorry for having broken this in
ee485b4051c24e2cebe46b426294b346f0f5fff4. When creating this patch, I
just looked at what os_support.h directly provided (namely redefinitions
of lseek and fstat etc.) and checked what files used any of this. I
don't not check for indirect includes that are not redefined by
os_support.h. (And honestly, if something relies on indirect includes,
then that's the bug.)

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".