From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avdevice/android_camera: fix missing include for usleep
Date: Sun, 17 Sep 2023 10:48:25 +0200
Message-ID: <GV1P250MB0737E3BD5F19BF8956E122E68FF4A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <tencent_D70EE0EA5B2635D9805A34393E8F56D59C09@qq.com>
Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> ---
> libavdevice/android_camera.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavdevice/android_camera.c b/libavdevice/android_camera.c
> index 1934999c18..0425b27518 100644
> --- a/libavdevice/android_camera.c
> +++ b/libavdevice/android_camera.c
> @@ -25,6 +25,7 @@
> #include <stdatomic.h>
> #include <stdbool.h>
> #include <stdint.h>
> +#include <unistd.h>
>
> #include <camera/NdkCameraDevice.h>
> #include <camera/NdkCameraManager.h>
Sorry for having broken this in
ee485b4051c24e2cebe46b426294b346f0f5fff4. When creating this patch, I
just looked at what os_support.h directly provided (namely redefinitions
of lseek and fstat etc.) and checked what files used any of this. I
don't not check for indirect includes that are not redefined by
os_support.h. (And honestly, if something relies on indirect includes,
then that's the bug.)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-09-17 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 3:37 Zhao Zhili
2023-09-17 8:48 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB0737E3BD5F19BF8956E122E68FF4A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git