[FFmpeg-devel] [PATCH] avcodec/evc_ps: Replace av_malloc+memset by av_mallocz

[FFmpeg-devel] [PATCH] avcodec/evc_ps: Replace av_malloc+memset by av_mallocz

[Andreas Rheinhardt]

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/evc_ps.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c
index ec405345ae..fc2105b352 100644
--- a/libavcodec/evc_ps.c
+++ b/libavcodec/evc_ps.c
@@ -143,12 +143,10 @@ int ff_evc_parse_sps(GetBitContext *gb, EVCParamSets *ps)
     if (sps_seq_parameter_set_id >= EVC_MAX_SPS_COUNT)
         return AVERROR_INVALIDDATA;
 
-    sps = av_malloc(sizeof(*sps));
+    sps = av_mallocz(sizeof(*sps));
     if (!sps)
         return AVERROR(ENOMEM);
 
-    memset(sps, 0, sizeof(*sps));
-
     sps->sps_seq_parameter_set_id = sps_seq_parameter_set_id;
 
     // the Baseline profile is indicated by profile_idc eqal to 0
@@ -318,12 +316,10 @@ int ff_evc_parse_pps(GetBitContext *gb, EVCParamSets *ps)
     if (pps_pic_parameter_set_id >= EVC_MAX_PPS_COUNT)
         return AVERROR_INVALIDDATA;
 
-    pps = av_malloc(sizeof(*pps));
+    pps = av_mallocz(sizeof(*pps));
     if (!pps)
         return AVERROR(ENOMEM);
 
-    memset(pps, 0, sizeof(*pps));
-
     pps->pps_pic_parameter_set_id = pps_pic_parameter_set_id;
 
     pps->pps_seq_parameter_set_id = get_ue_golomb(gb);
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/evc_ps: Replace av_malloc+memset by av_mallocz

[James Almer]

On 6/29/2023 7:28 PM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavcodec/evc_ps.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c
> index ec405345ae..fc2105b352 100644
> --- a/libavcodec/evc_ps.c
> +++ b/libavcodec/evc_ps.c
> @@ -143,12 +143,10 @@ int ff_evc_parse_sps(GetBitContext *gb, EVCParamSets *ps)
>       if (sps_seq_parameter_set_id >= EVC_MAX_SPS_COUNT)
>           return AVERROR_INVALIDDATA;
>   
> -    sps = av_malloc(sizeof(*sps));
> +    sps = av_mallocz(sizeof(*sps));
>       if (!sps)
>           return AVERROR(ENOMEM);
>   
> -    memset(sps, 0, sizeof(*sps));
> -
>       sps->sps_seq_parameter_set_id = sps_seq_parameter_set_id;
>   
>       // the Baseline profile is indicated by profile_idc eqal to 0
> @@ -318,12 +316,10 @@ int ff_evc_parse_pps(GetBitContext *gb, EVCParamSets *ps)
>       if (pps_pic_parameter_set_id >= EVC_MAX_PPS_COUNT)
>           return AVERROR_INVALIDDATA;
>   
> -    pps = av_malloc(sizeof(*pps));
> +    pps = av_mallocz(sizeof(*pps));
>       if (!pps)
>           return AVERROR(ENOMEM);
>   
> -    memset(pps, 0, sizeof(*pps));
> -
>       pps->pps_pic_parameter_set_id = pps_pic_parameter_set_id;
>   
>       pps->pps_seq_parameter_set_id = get_ue_golomb(gb);

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".