[FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Fix left-shift of negative value

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Fix left-shift of negative value

[Andreas Rheinhardt]

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_ssim360.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c
index a0bf73da1e..89f5100740 100644
--- a/libavfilter/vf_ssim360.c
+++ b/libavfilter/vf_ssim360.c
@@ -547,7 +547,7 @@ static double ssim360_db(double ssim360, double weight)
 static int get_bilinear_sample(const uint8_t *data, BilinearMap *m, int max_value)
 {
     static const int fixed_point_half = 1 << (FIXED_POINT_PRECISION - 1);
-    static const int inv_byte_mask = (-1) << 8;
+    static const int inv_byte_mask = UINT_MAX << 8;
 
     int tl, tr, bl, br, v;
 
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_ssim360: Don't initialize twice

[Andreas Rheinhardt]

The FILTER_INPUTS and FILTER_OUTPUTS macros already set
AVFilter.(inputs|outputs); Clang therefore emits a warning for
this: "initializer overrides prior initialization of this subobject
[-Winitializer-overrides]"

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_ssim360.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c
index 89f5100740..35b0819d5f 100644
--- a/libavfilter/vf_ssim360.c
+++ b/libavfilter/vf_ssim360.c
@@ -1760,8 +1760,6 @@ AVFilter ff_vf_ssim360 = {
     .activate      = activate,
     .priv_size     = sizeof(SSIM360Context),
     .priv_class    = &ssim360_class,
-    .inputs        = ssim360_inputs,
-    .outputs       = ssim360_outputs,
     FILTER_INPUTS(ssim360_inputs),
     FILTER_OUTPUTS(ssim360_outputs),
     FILTER_PIXFMTS_ARRAY(ssim360_pixfmts),
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_ssim369: Constify AVFilter

[Andreas Rheinhardt]

This brings ff_vf_ssim360 in line with its declaration in allfilters.c;
this discrepancy is actually undefined behaviour.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_ssim360.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_ssim360.c b/libavfilter/vf_ssim360.c
index 35b0819d5f..3eb8e43bbc 100644
--- a/libavfilter/vf_ssim360.c
+++ b/libavfilter/vf_ssim360.c
@@ -1751,7 +1751,7 @@ static const AVFilterPad ssim360_outputs[] = {
     },
 };
 
-AVFilter ff_vf_ssim360 = {
+const AVFilter ff_vf_ssim360 = {
     .name          = "ssim360",
     .description   = NULL_IF_CONFIG_SMALL("Calculate the SSIM between two 360 video streams."),
     .preinit       = ssim360_framesync_preinit,
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".